Invalid POM for isomorphic-sql

[Crack]

Version: SmartClient_v100p_2015-11-14_PowerEdition

isomorphic-sql.pom defines conditional dependency on commons-dbcp, but it's a hard dependency of SQLConnectionManager:

13:04:11.991 [ppr][qtp1258527853-23] ERROR com.isomorphic.taglib.LoadDSTag - Exception while attempting to process a loadDS tag.
java.lang.NoClassDefFoundError: org/apache/commons/dbcp/PoolableConnection
    at com.isomorphic.sql.SQLConnectionManager.free(SQLConnectionManager.java:308) ~[isomorphic_sql-10.0-PE-20151114.jar:na]
    at com.isomorphic.sql.SQLConnectionManager.free(SQLConnectionManager.java:280) ~[isomorphic_sql-10.0-PE-20151114.jar:na]
    at com.isomorphic.sql.SQLDSGenerator.generate(SQLDSGenerator.java:211) ~[isomorphic_sql-10.0-PE-20151114.jar:na]
    at com.isomorphic.sql.SQLDataSource.getConfigFromTable(SQLDataSource.java:3876) ~[isomorphic_sql-10.0-PE-20151114.jar:na]
    at com.isomorphic.sql.SQLDataSource.fromTable(SQLDataSource.java:3825) ~[isomorphic_sql-10.0-PE-20151114.jar:na]
    at com.isomorphic.sql.SQLDataSource.init(SQLDataSource.java:247) ~[isomorphic_sql-10.0-PE-20151114.jar:na]

It shouldn't be declared as optional.

[Isomorphic]

DBCP is still optional, although the conditions under which it's required did change in the 10.x line. We've updated the doc to point out that you'll need it if you plan to use the autoDeriveSchema or similar features. Thanks for the report.