Announcement

**Isomorphic** · 12 Feb 2014, 12:25

This suggests you've got client-side code that tries to access rows in the vicinity of 1000 while data is still being loaded. That code needs to check whether data is available instead via resultSet.lengthIsKnown(), or be postponed until the DataArrived event fires.

What you're seeing in the logs is two threads interleaving log statements as they execute one request each (note the thread IDs in each statement: [c-35] and [c-26]). Each request only leads to one data fetch from SQL, as expected.

**Blama** · 12 Feb 2014, 14:21

Hi Isomorphic,

it seems to be related to groupBy(String fieldName).

I changed setGroupByMaxRecords(456); and now the 2nd request is: ..., startRow:0, endRow:457, ....

I know I can set setGroupByField(String fieldName) before calling setFields(...), but my use-case here is the following:

I have a RadioItem configuring my ListGrid. On change I call the following code (see bold parts):

Code:

public void configure(final boolean activeLeads) {
	setFetchOperation("fetchMyPickedLeads");
	setGroupByMaxRecords(456);
	if (activeLeads) {
		setShowRecordComponents(true);
		setShowRecordComponentsByCell(true);
		setHilites(new Hilite[] { new DateFieldHilite(earliestStartLGF.getName()), new DateFieldHilite(latestEndLGF.getName()) });
		setFields(leadstatusLGFHidden, pickedDateLGF, statusDateLGF, companyAndContactLGF, countryZipCodeCity, campaignLGF,
				leadtemperatureLGF, potrevResellerLGF, earliestStartLGF, latestEndLGF, createdByLGF, createdAtLGF, modifiedByLGF, modifiedAtLGF,
				createdByCompanyLGF, createdByDistributorLGF, createdByResellerLGF, assignStatusLGF);
	} else {
		setShowRecordComponents(false);
		setShowRecordComponentsByCell(false);
		setHilites(null);
		setFields(wonLostTypeLGF, wonLostNameLGF, pickedDateLGF, statusDateLGF, companyAndContactLGF, countryZipCodeCity, campaignLGF,
				leadtemperatureLGF, potrevResellerLGF, earliestStartLGF, latestEndLGF, createdByLGF, createdAtLGF, modifiedByLGF, modifiedAtLGF,
				createdByCompanyLGF, createdByDistributorLGF, createdByResellerLGF);
	}

	if (!viewStateHelper.applySavedViewStates()) { [B]//returns false if no persisted settings for fields and sort are found[/B]
		if (activeLeads) {
			setSort(new SortSpecifier[] { new SortSpecifier("STATUS_SHORTNAME", SortDirection.ASCENDING),
					new SortSpecifier("PICKED_DATE", SortDirection.ASCENDING) });
		} else {
			setSort(new SortSpecifier[] { new SortSpecifier("STATUS_WONLOST_TYPE", SortDirection.ASCENDING),
					new SortSpecifier("STATUS_WONLOST_NAME", SortDirection.ASCENDING), new SortSpecifier("PICKED_DATE", SortDirection.ASCENDING) });
		}
	}

	//[B]Here the grouping happens[/B]
	if (activeLeads) {
		groupBy("STATUS_SHORTNAME");
		fetchData(new AdvancedCriteria("STATUS_WONLOST_ID", OperatorId.IS_NULL), new ListGridIsLoadedCallBack(viewStateHelper));
	} else {
		groupBy("STATUS_WONLOST_TYPE");
		fetchData(new AdvancedCriteria("STATUS_WONLOST_ID", OperatorId.NOT_NULL), new ListGridIsLoadedCallBack(viewStateHelper));
	}
}

As you can see the ListGrid is not destroyed and recreated, but reused. Otherwise I could use setGroupByField(String fieldName) before calling setFields(...), but now it is this way.

Is this use case supported? If not, I will destroy and recreate the ListGrid.
By the way: Do I have to call

Code:

[I]this.listGridmemberVariable.destroy();[/I]

or is

this.listGridmemberVariable = new ListGrid();
myLayout.setMembers(this.listGridmemberVariable);

enough?

Thank you,
Blama

**Blama** · 12 Feb 2014, 14:44

Further investigation:

It also happens for this order of calls (with setGroupByField("...") for a new MyListGrid extends ListGrid (no "reconfiguring"):

Code:

super();
setCanAutoFitFields(false);
setAutoFetchData(false);
setShowFilterEditor(true);
setShowRecordComponents(true);
setShowRecordComponentsByCell(true);
setHilites(new Hilite[] { ... });
setDataSource(myDS);
setCanGroupBy(false);
setGroupStartOpen(GroupStartOpen.ALL);
[B]setGroupByField(...);[/B] //setGroupByField before setFields! 
[B]setFields(...);[/B]
setFieldState(...);
setSortState(...);
[B]fetchData(...);[/B]

Can you reproduce with this code? What might be important:
The fetch-RPC for rows 0-75 and returning 0 rows takes around 2,5 sec.
The 2nd fetch-RPC for rows 0-1001 and returning 0 rows takes around 1 sec. The 2nd starts at about the time the 1st finishes.

Best regards,
Blama

**Isomorphic** · 12 Feb 2014, 14:47

It's probably simplest to destroy() and re-create the grid since the new grid has little in common with the old - you are pretty much changing everything. By changing each setting one at a time you will likely cause more work to be done than would be involved in creating an entirely new grid.

Not to mention the potential for duplicate fetches, as each of your settings (grouping, sort, etc) could require the grid to get new data from the server.

If you did need to keep the original grid for some reason, probably the best way to do it would be to temporarily provide it with empty RecordList (*not* ResultSet) so that no fetches will take place, then place your fetchData() call last.

**Blama** · 12 Feb 2014, 15:02

Hi Isomorphic,

thanks for the answer. I'll do so, then.

Best regards,
Blama

**Blama** · 12 Feb 2014, 15:04

Hi Isomorphic,

could you reproduce the two fetches from my 15:44-post?

These were generated by a fresh ListGrid.

Best regards,
Blama

**Isomorphic** · 12 Feb 2014, 15:06

We didn't actually try, but we believe it would happen. The thing is that you should call setFields() before you apply grouping (which definitely depends on the fields).

**Blama** · 12 Feb 2014, 15:49

Hi Isomorphic,

I just tried with reversed order and see the same behaviour. Only If I don't setGroupByField("..."), the 2nd call goes away.

Best regards,
Blama

**Blama** · 12 Feb 2014, 16:26

Hi Isomorphic,

I almost grew desperate. Here I minimal testcase based on current BuiltInDS:

animal.ds.xml addition:

Code:

<serverObject lookupStyle="new" className="com.smartgwt.sample.server.listener.MyDMI" />

MyDMI.java:

Code:

package com.smartgwt.sample.server.listener;

import javax.servlet.http.HttpServletRequest;

import com.isomorphic.datasource.DSRequest;
import com.isomorphic.datasource.DSResponse;


public class MyDMI {
	public DSResponse fetch(DSRequest dsRequest, HttpServletRequest servletRequest) throws Exception {
		Thread.sleep(4000);
		return dsRequest.execute();
	}
};

BuiltInDS.java:

Code:

package com.smartgwt.sample.client;

import com.google.gwt.core.client.EntryPoint;
import com.smartgwt.client.core.KeyIdentifier;
import com.smartgwt.client.data.DataSource;
import com.smartgwt.client.util.PageKeyHandler;
import com.smartgwt.client.util.Page;
import com.smartgwt.client.util.SC;
import com.smartgwt.client.widgets.grid.ListGrid;
import com.smartgwt.client.widgets.grid.ListGridField;
import com.smartgwt.client.widgets.layout.VStack;

/**
 * Entry point classes define <code>onModuleLoad()</code>.
 */
public class BuiltInDS implements EntryPoint {
	private ListGrid boundList;

	/**
	 * This is the entry point method.
	 */
	public void onModuleLoad() {
		KeyIdentifier debugKey = new KeyIdentifier();
		debugKey.setCtrlKey(true);
		debugKey.setKeyName("D");

		Page.registerKey(debugKey, new PageKeyHandler() {
			public void execute(String keyName) {
				SC.showConsole();
			}
		});

		VStack vStack = new VStack();
		vStack.setLeft(175);
		vStack.setTop(75);
		vStack.setWidth("70%");
		vStack.setMembersMargin(20);

		boundList = new ListGrid();

		boundList.setDataSource(DataSource.get("animals"));
		boundList.setHeight(200);
		boundList.setCanEdit(true);
		ListGridField lifeSpanLGF = new ListGridField("lifeSpan");
		ListGridField dietLGF = new ListGridField("diet");
		boundList.setFields(lifeSpanLGF, dietLGF);
		boundList.setGroupByField("lifeSpan");
		boundList.fetchData();
		vStack.addMember(boundList);
		vStack.draw();
	}
}

You can see the resulting Console screenshot in the attachment:

Best regards,
Blama

Attached Files

**Isomorphic** · 13 Feb 2014, 11:34

Thanks for sticking with this - this issue has been fixed. What you will now see is that if you configure grouping and then call fetchData() on a grid that has never fetched before, you'll see a single fetchData() the server retrieving rows from 0 to groupByMaxRecords.

This may be suboptimal as this still may not be enough records to allow client-side grouping, but it's the best the ListGrid can do when provided these settings.

**Blama** · 13 Feb 2014, 16:07

Hi Isomorphic,

thanks for the fix, I'll try with tomorrow's build.

Regarding the general behavior, isn't this possible:

ListGrid with fields a...f
Sort by b,e (SortNormalizer or sort by valueField or sort by DisplayField)
Group by c (no SortNormalizer used (even if defined), sort by valueField or sort by DisplayField)
fetchData()
Results in query: rows 0-75(!): SELECT ...ORDER BY c, b, e
If SortNormalizer set for b, e: Clientside re-sort

That way you'd get a grouped ListGrid with the values you'd expect in the order you'd expect without transfering to much records. Is this a possible improvement, perhaps for 10.0/5.0?

Best regards,
Blama

EDIT:
I created an own thread for this here, but it might not be as simple as I thought with respect to setGroupValueFunction() and setGroupTitleRenderer.

**Blama** · 5 Aug 2014, 05:26

revisited thread

Originally posted by Isomorphic View Post

Thanks for sticking with this - this issue has been fixed. What you will now see is that if you configure grouping and then call fetchData() on a grid that has never fetched before, you'll see a single fetchData() the server retrieving rows from 0 to groupByMaxRecords.

This may be suboptimal as this still may not be enough records to allow client-side grouping, but it's the best the ListGrid can do when provided these settings.

Hi everyone,

I wanted to confirm that this is fixed for me using 4.1p in both the sample and my application.

Best regards,
Blama

Announcement

ListGrid sends two fetch-requests (no autoFetchData, perhaps requestIndex related?)

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment