Potential discreppancy between ListGrid saveAndHideEditor and shouldCancelEdit

[hin3x]

Hello,

We are having an issue with a grid where the user enters some data in a (new) record and uses escape to go out of edit mode. Parts of the data are discarded, we expect this to happen because of the following:

The 'shouldCancelEdit' function looks at the 'escapeKeyEditAction' setting to decide how pressing escape should be evaluated.
The 'saveAndHideEditor' function however does not look at the 'escapeKeyEditAction' setting when evaluating the escape key press (var cancelling = editCompletionEvent == isc.ListGrid.ESCAPE_KEYPRESS) - this causes the data being discarded regardless of the requested escape action.

We fixed up the code to look at the 'escapeKeyEditAction' setting and once we did the data no longer gets discarded.

Are we overlooking something here or is this a valid hole in the code?

This is on v8.3p_2013-04-08/Pro Deployment 2013-04-08.

thanks

[hin3x]

Hi, did you have time to look at this.

[Isomorphic]

Hi
Sorry for the silence on this. We have indeed looked at it and are working on how best to resolve it. We'll update the thread when we have a solution

Regards
Isomorphic Software

[Isomorphic]

We've made a change to address this, which will be present in the next nightly builds (8.3p and 9.0d branches).

We've added a new ListGrid.escapeKeyEditAction option:
You can now choose "cancel" (the default - dismiss the editor and discard pending edit values), "done" (dismiss the editor, and save edit values if autoSaveEdits is true), or "exit" (dismiss the editor, leaving the edit values intact, without saving).

Regards
Isomorphic Software

[hin3x]

Thanks, that's great news!