Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

  • mathias
    replied
    Ah, gotcha. Thanks for clarifying.

    Leave a comment:


  • Isomorphic
    replied
    So, just to be clear - the FormItem itself (the TextItem or DateItem, or whatever) and its title element are each separately styled, with appropriate classes. formCell is the style applied to the table-cells in the DynamicForm, in which items and their titles are drawn. When titleOrientation is "top", the item and its title are drawn into the same cell. Otherwise, they occupy separate cells.
    Last edited by Isomorphic; 11 Feb 2021, 10:07.

    Leave a comment:


  • mathias
    replied
    Yeah, i might be slow but i find the form fontsizing a bit hard to grapple with, as evidenced by this discussion :) I would have loved (and thought it was) one default value for form cells, and one value for titles (those outside the cells). But i'm no expert and might be missing lots of complexity.

    Leave a comment:


  • Isomorphic
    replied
    $formItem_font relates to formItem-values, where both formCell and formTitle relate to content in the cell outside of the FormItem proper.

    We may consider new variables as we're looking, more generally, at making the _base file tidier and more concise.

    Leave a comment:


  • mathias
    replied
    Also, i checked _base.scss and i found something i think is a bit strange:

    Code:
    /* formCell styles */
    .....
    font: {
            family: $form_title_font;
            size: $form_title_font_size;
        }
    shouldn't this use form_item_font and form_item_font_size rather than title?

    Leave a comment:


  • Isomorphic
    replied
    RTL is right-to-left - see the doc for FormItem.showRTL, and related docs.

    The *Lite classes are for formItems in more modern skins, where we write out lighter-weight HTML structures. .staticTextItemLite was added in error, since StaticTextItems are already light-weight.

    Leave a comment:


  • mathias
    replied
    I can see that the beta build has been updated now, great.

    If i may, can i ask some in things re. the skin file?

    1. what does 'RTL' mean in the context of the formtitles?
    for example
    Code:
    .formCellFocusedOver,
    .formCellFocusedOverRTL,
    Is this part of some documentation somewhere?

    2. What's the thinking with 'statictextitem' vs 'statictextitemlite' that you mention above?
    Last edited by mathias; 11 Feb 2021, 00:17.

    Leave a comment:


  • mathias
    replied
    Yes, i was trying to point out that the 13 beta was still from feb 6.

    Thanks.

    Leave a comment:


  • Isomorphic
    replied
    When you say "the 13 beta", do you mean the latest build from smartclient.com/builds, ie, the one from February 6th? If so, that's why the files are dated February 6th, of course.

    In terms of the skin change, it didn't hit the build-pipeline until the morning of February 6th, so it would have hit public builds on February 7th - however, nightly builds haven't run successfully for the last two days, which we're looking into.

    You'll see the changes in the next build that hits the builds page - either later today or tomorrow.

    Leave a comment:


  • mathias
    replied
    Re #6, That's great! However i just downloaded the 13 beta again. If i unzip it all files are still from February 6, and nothing has changed in the stratus skin. Am i missing something?

    Leave a comment:


  • Isomorphic
    replied
    On post #5 - configuring a skin involves the CSS styles in skin_styles.css, and the JS config in load_skin.js. We don't specify widget/element sizes (width/height) generally, in the CSS. Incidentally, if what you want to do is generally make things bigger, text and controls, you might want to read the docs for Canvas.resizeControls() and resizeFonts(), which scale the skin-level defaults at runtime. You can see them in action by changing "Density" in the online Showcase.

    On #6, you've spotted an issue in the base style - skin_styles.css has both .staticTextItem and .staticTextItem*Lite*- the latter is fully implemented, but the code is using the former which lacks the latest style changes, including *Over styles. We'll fix that today.

    Leave a comment:


  • mathias
    replied
    HI there, i am continuing in this thread since i have another saas question regarding form font size.

    I have managed to change the size using $formItem_font_size. However, i just noticed that when i mouse hover over it, it falls back to, i think, $standard_font_size? Anyway the form_item_font_size is not used.

    The style it is changed to is staticTextItemOver. There is, however, no "formitem_over_font_size" parameter in _base, (but there are other _over ones!) so i'm not sure how to fix this. I had hoped that the form_item_font_size would keep all states of form_items the same size.

    Pointers appreciated.

    Leave a comment:


  • mathias
    replied
    You can see what's been customized by looking at _userStyles. But fair enough, not in the compiled file.

    ok, i'll play around there then :) It would have been great if everything style-related was in the same place, is it not possible to style heights in the skin-config? I can imagine it's harder? I think that it's not super clear to the average skinner (like me!) that form-sizes are set in one place, but not heights.

    Leave a comment:


  • Isomorphic
    replied
    We keep all CSS customizations separate from the underlying base-styles, which makes understanding what's been customized much simpler.

    Heights are in general not set directly in skin-styles - change the FormItem block in load_skin.js
    Last edited by Isomorphic; 5 Feb 2021, 01:54.

    Leave a comment:


  • mathias
    replied
    Hey there, thanks for quick response!

    Comment re. 2: I get it, but to me it's unfortunate that someone looking at the skin will have to search around in different places to get the complete picture for a style. I think that It would have been great if the compilation process put styles with the same name together. Just my 2 cents.

    re 3: Right. If it's not used, couldn't you strip it out in the first place? Would make it cleaner. Again, just my 2 cents :)

    So, i also have a new question from this morning. I'm trying to increase form font sizes, which i have done. Unfortunately, the cell sizes don't increase so that the text gets cropped:

    Click image for larger version

Name:	Screen Shot 2021-02-05 at 10.25.49.png
Views:	49
Size:	2.0 KB
ID:	264562
    I have tried various parameters from _base like standard_line_height and button_line_height, but that didn't change anything.

    I couldn't find anything related to 'heights' in _base or _skinsettings, so i went over to load_skin and tried changing around various heights in section 11 - like height in comboboxitem, spinneritem and selectitem. None of these tests did anything. I had hoped that the cells would just increase to afford the font size :)

    Can you help me increasing these heights?

    Leave a comment:

Working...
X