Date.createLogicalDate: is the year the fullyear or?

[martintaal]

Thanks for the quick change!

[Isomorphic]

It seems correct although we're wondering what behaviors people may have been relying on. We've committed it to mainline (3.x / 8.x) to see if breaks any automated tests.

[martintaal]

Hi,
A small issue I have with a full year value of 0001 (yes we have that...), when getting a date from the server which is 01-01-0001 then the Date.createLogicalDate will create a js date of 01-01-1901, eventhough all 4 digits in the year are specified.

Changing this line in that method:
if (year != null) d.setYear(year);
to:
if (year != null) d.setFullYear(year);
solves it.

Is this a correct change? So a bug, or a feature?

gr. Martin