Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

    #16
    hi Blama,

    We've addressed most of these for tomorrow's builds. Numbers 6 and 9 have not been modified for now.

    For 10, the issue there is that there are lots of records in the test-data for that DS with "units" set to null. We see a blank entry appear at the top of the list, not in the second position, and it works as you expect when you set it (returning records where "units" is unset). Please let us know if you have more to say on this one.


    Comment


      #17
      Hi Isomorphic,

      I can see most of the points are addressed in SNAPSHOT_v13.1d_2024-06-11.
      (6) and (9) are fine for me the way they are as well.

      For the others I found these:
      (3) There is still a search icon and no X to delete the text, but this is fine as well if it is on purpose
      (5) Drag selection still possible, but on the opening caret only, not in the text anymore:
      Click image for larger version

Name:	Drag selection possible-2.PNG
Views:	76
Size:	10.0 KB
ID:	272540

      (10) I just realized you are already using the idea I had here to build the pickList-ResultSet.
      Could you also by default add a sortBy and not just a groupBy to the request?
      Also, it seems this request customizable, as it is already using a specialized operationId and the docs for deriveUniqueValues mention MultiPickerItem.optionFilterContext.

      Apart from a "normal" example using SetFilterItem one using expandedPickListFields would be nice.

      I also noticed you ported back SetFilterItem to 13.0p, which of course is great, but it is not in the docs there. Is this on purpose?

      Best regards
      Blama

      Comment


        #18
        Hi Isomorphic,

        creating this testcase I noticed some more design issues:
        (11) The expand icon is not centered in the darker grey box you see on hover (when canExpand: true)
        (12) The expand icon seems to be selected text on click, being partly black background on click (FF127 and Edge 125)
        (13) The same applies to the filter-funnel in the ListGrid's filterRow

        Best regards
        Blama

        Click image for larger version

Name:	Selected icons.png
Views:	58
Size:	7.1 KB
ID:	272567

        Last edited by Blama; 13 Jun 2024, 02:59.

        Comment


          #19
          Thanks Blama - happily, numbers 11 to 13 are already fixed with the switch to SVG icons in Shiva. Please see tomorrow's builds for those.

          We may also change the search icon to a clear icon, per #3, and will consider your requests in #10, but any changes here won't hit tomorrow's builds.

          We'll be getting around to a sample for these features shortly and we'll look at adding a second one as requested.

          Finally - yes, these features do exist in 13.0 but are undocumented there.

          Comment


            #20
            A quick heads up that the switch to SVG in Shiva didn't happen today - we're going to make the change on the weekend instead to allow a bit of extra time for general testing in the samples.

            Comment


              #21
              Hi Isomorphic,

              happily, numbers 11 to 13 are already fixed with the switch to SVG icons in Shiva. Please see tomorrow's builds for those.
              I can see that using SNAPSHOT_v13.1d_2024-06-18 (11) is fixed. But (12) and (13) are still open.

              Best regards
              Blama

              Comment


                #22
                Hmm - can you clarify what you mean by "The expand icon seems to be selected text on click, being partly black background on click"

                Comment


                  #23
                  Of course:
                  Click image for larger version

Name:	Black Background on Hover.gif
Views:	44
Size:	17.3 KB
ID:	272619

                  Comment


                    #24
                    Thanks - we've seen this in the past, but not presently - we've applied a likely fix and will keep an eye on the next build.

                    Comment


                      #25
                      OK, thanks. I've been always seeing this, in FF and Edge, Win10, FullHD, no zoom.

                      Best regards
                      Blama

                      Comment


                        #26
                        Yes, it was showing the old disk-based png file, which is a black funnel image, when state changed on rollover, due to a mis-mapping - we'll keep an eye on it.

                        Comment


                          #27
                          hi Blama - A quick followup on your numbers 3 and 10.

                          #3 - some uses of this component may not auto-filter, so we're not going to remove the filter icon for now - however, we've added support for setting showFilterIcon: false, via filterEditorProperties in this case, if you don't want to see it - will be in today's builds

                          #10 - if you wanted to apply a sort here yourself, you can do it via item.initialSort, or item.sortField/Direction, or with LG settings via pickListProperties on the item. We wouldn't typically apply a default sort here, as we don't in grids generally - can you clarify why you think it's better in this case?

                          We haven't yet added the new samples, but they'll be on their way soon.
                          Last edited by Isomorphic; 18 Jun 2024, 22:09.

                          Comment


                            #28
                            Hi Isomorphic,

                            re (3): That's great
                            re (10): If you are not using the search, which you won't for let's say less than 25 records, you will be faster finding the wanted entry if the dataset is sorted. The difference to a "normal" ListGrid is that you only have one row of data here and it is obvious which column is the right one to sort. In a ListGrid with multiple columns you can't possibly know that. Of course is is easy enough to do this oneself, but a sensible default always helps.
                            re (12)/(13): Ok, I'll wait for today's build. Also, the filter icon is still png, in case you want to change that.

                            Best regards
                            Blama

                            Comment


                              #29
                              Hi Isomorphic,

                              another question regarding pickListProperties:
                              Is this below really the only way to set the requestProperties? This seems awfully deep nested and is almost impossible to find out. ListGrid has saveRequestProperties, but no "normal" (fetch-)RequestProperties.
                              Code:
                              name: "government",
                                      filterEditorProperties: {
                                          type: "SelectItem",
                                          sortField: "government",
                                          multiple: true,
                                          pickListProperties: {
                                              dataProperties: {
                                                  requestProperties: {
                                                      groupBy: "government"
                                                  }
                                              }
                                          }
                                      },
                              Best regards
                              Blama

                              Comment


                                #30
                                On the default sort, the natural order of the data is often the best sort, so we don't want to override that as a default. But we will make it easy to affect the sort.

                                Comment

                                Working...
                                X