Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

    Bug in ListGrid.getBaseStyle

    Hi,

    Nothing major, but anyway...

    When having records with singleCellValue, style for singleCell is being taken from the first field of the ListGrid, while IMHO it would be better to just go for default cell/tallCell style as usually singleCell records are not related to any particular field.
    In my case I was skinning expansionField and its style got applied to singleCell record.

    Here is a test case checked in current showcase - v13.1p_2025-02-20/AllModules Development Only:

    Code:
    isc.ListGrid.create({
        width:500, height:224,
        canExpandRecords: true,
        expansionMode: "details",
        expansionFieldProperties: {
           baseStyle: "expansionStyle"
        },
        data: [
          { singleCellValue: "this cell gets \"expansionStyle\" style" },
          { aaa: "bbb" },
        ],
        fields:[
            {name:"aaa"}
        ],
    })
    In ListGrid.getBaseStyle there are lines:
    Code:
    var field = this.getField(colNum);
        if (field && field.baseStyle) return field.baseStyle;
    
        if (field && field.type == "summary" && this.recordSummaryBaseStyle)
            return this.recordSummaryBaseStyle;
    
        if (field && field.frozen && !this._suppressedFrozenFields && this.frozenBaseStyle) {
            return this.frozenBaseStyle;
        }
    that could be skipped for record[this.singleCellValueProperty]

    Best regards,
    Janusz
    Last edited by janusz; 20 Feb 2025, 12:40.
Working...
X