Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

    Defect in ISC_Grids requestVisibleRows() function (?)

    Migrating my project to SmartClient_SNAPSHOT_v100d_2014-07-26_LGPL version today, I found that call to
    Code:
    someTree.fetchData()
    throws exeption. Short look points to the source of that in this portion of code in requestVisibleRows() function in ISC_Grids.js
    Code:
    39485    } else {
    39486        // If our data isn't a resultSet, ensure that showAllRows reflects this.showAllRecords
    39487        // This is required for the case where we are databound and grouped so this.data
    39488        // was a resultSet when this method last ran and is now a client-side tree with
    39489        // complete results
    39490        this.body.showAllRows = (this.body.overflow == isc.Canvas.VISIBLE ?
    39491                                     true : this.showAllRecords);
    39492    }
    where <this.body> was null in fact, and <this.body.overflow> lead to exception.
    Change <else> to <else if (this.body != null && !this.body._reused)> repair situation for me.
    So, it looks like null-check of this.body are missed.
    Isn't it?

    (Don't know when this code appear, but in June 05 build at least it was not present, so it's quite new code.)

    #2
    Thanks for pointing this out. This is fixed for tomorrow's builds in all affected branches.

    Comment


      #3
      Hi, I found that in SmartClient_v91p_2014-07-29_Evaluation tooooo... :(
      Code:
      myTreeGrid.fetchData(null, "mycallback()");

      Comment


        #4
        This is already fixed, be sure you've cleared your cache.

        Comment

        Working...
        X