Error Icons are not being displayed in the GRID mode

[Abdulaziz A.]

Hi,

We are facing a weird issue while we are performing SAVE operation in GRID mode (Error icons are not being displayed in the corresponding GRID though the the validation errors are thrown)

Everything is working fine if we are adding a new record in GRID
i.e all error icons are showing up properly if there are any errors

Once we add a record in GRID mode and then try to edit and save the record, the following issues happened

- If any server side validations are failing (i.e validations which trigger with validatorType: 'serverCustom') those errors are not getting displayed in the GRID mode

We are able to see in the console the validation errors that were thrown by 'serverCustom' validations but error icons are not being displayed in the GRID. Also the GRID record is showing old values

Also we are facing this issue only with
SmartClient version : Isomorphic SmartClient/SmartGWT Framework (9.1p_2014-10-26/PowerEdition Deployment 2014-10-26)
It is working fine with previous versions of SmartClient

- If there are any inbuilt validations with validatorType like 'requiredIf' , those errors are properly caught are being displayed in the GRID



PFA 3 files which replicates the issue during update operation of a record in GRID mode

- helloWorld.jsp (contains a list grid with id 'lookupData')
- VCOC_LOOKUP_TABLE_test.ds.xml
(the datasource corresponding to the above grid 'lookupData')
- TestLookupMainValidatorDMI.java
(which validates the field COC_FIELD_DESCRIPTION during update operation and throws an error message if we enter some restricted data)

We are working on the below environment:
SmartClient version : Isomorphic SmartClient/SmartGWT Framework (9.1p_2014-10-26/PowerEdition Deployment 2014-10-26)

Browser: IE9

Please help us solve this issue..


Thanks,

[Isomorphic]

Many obvious things are missing before this would be a usable test case (resource bundles, SQL schema, sample data, several imports in the .jsp, etc).

First, get rid of your server-side call to dsRequest.getOperation(). This is not a documented or supported API.

Second, test with the latest patched build.

Third, if you're still seeing an issue, post your server logs, Developer Console log, and RPC tab response. This is always required.

Please also clarify:

1. in what previous version are you claiming this exact code worked?

2. what do you mean by "the GRID record is showing old values"? If this is a validation error, the display values should not be changing, since the save was rejected. So in what way are the values "old" and/or what were you expecting to change?

Aside from the above, if you choose to try to submit the test case again with more complete information, please remove all the unnecessary code in your helloWorld.jsp, including the many overrides that don't appear to do anything, and make sure you can reproduce the problem without all this application logic (which helps ensure we are actually looking at a framework problem).

[Abdulaziz A.]

Hi,

I will work on making a test case for you but you can still check the behavior that I mentioned without waiting the test case from me and if it is not producible then you should wait for my test case

Thank you

[Isomorphic]

We asked for logs, not a test case. We currently think that proceeding with a test case is a slower, higher effort route to solving the problem.

As far as looking into this without a test case, there are already product samples and automated tests that use DMI validators. They are working fine.

[Abdulaziz A.]

Version: SmartClient_v91p_2014-12-03_PowerEdition
Browser: IE9

Clarifications for the initail reply:
1) Sorry for the mistake I could see this issue in earlier versions as
well
2) "the GRID record is showing old values" - I mean the display values are not changing

Still facing the issue after following the below steps
- I have removed all the unnecessary code (resource bundle, imports in the jsp, overrides) from helloworld.jsp
- Removed dsRequest.getOperation() from the server-side code

Also I am attaching
1) console.log file
2) updated helloworld.jsp
3) updated TestLookupMainValidatorDMI
4) Schema and Sample Data

In RPC tab: No logs were fired

Some small findings from our side:

- grid.endEditing() is not showing error icons during update operation for validations with validatorType: 'serverCustom'

- Error icons are properly displayed if we edit a column(Update) and press Enter, but not if we manually call grid.saveEdits() and grid.endEditing()


Thank you,

[Isomorphic]

Still missing client-side Developer Console logs.

Still need RPC tab requests and responses. These may be missing if you forgot to check "Track RPCs".

Still need clarification on this point:

2) "the GRID record is showing old values" - I mean the display values are not changing

As we stated previously:

If this is a validation error, the display values should not be changing, since the save was rejected. So in what way are the values "old" and/or what were you expecting to change?

We still need this question answered.

[Isomorphic]

Also, as far as the route of continuing to create a test case, we need sample data, not a description of what each column means.

[Abdulaziz A.]

I have sent you the sample data itself.. Not the description of what each column means..

The table just contains 2 columns
COC_FIELD_ID
COC_FIELD_DESCRIPTION

and other thing is just the data present in those columns

[Abdulaziz A.]

Hello

1 - Regarding the below Quote, check the attached images [before edit.jpg, during edit.jpg, after press save.jpg]

the GRID record is showing old values" - I mean the display values are not changing

2 - Regarding the RPC tab, check the attached files [First RPC.txt, Second RPC.txt]


3 - Regarding the Developer Console logs, whenever I click at the tab I get the below exception although I made the RPCManager.enabledBuiltinMethods:* in server.properties

Attempt to execute RPC DMI Builtin 'areServerTimingsTracked' DENIED by server.properties configuration.  To enable this method, add it to the list of methods under RPCManager.enabledBuiltinMethods in server.properties

I want to remind you that if I call grid.saveEdits() alone everything works fine but if I call grid.endEditing() after grid.saveEdits() then I get the issue

[Isomorphic]

The Developer Console logs we're looking for are the ones that appear when you first open the Developer Console (the "Results" tab).

It's critical that you regularly check these logs because they contain warnings that your application is doing something wrong. The QuickStart Guide provides some basic information about how to use this tool.

[Abdulaziz A.]

the Results tab is attached but I am really wondering why you are not able to reproduce the issue that I am facing, Anyhow I am facing production issues due to that issue so please try to fix it as soon as possible


Regards,

[Isomorphic]

Great, glad to finally get this, we'll take a look.

As a reminder, we do not generally try to actually reproduce a problem until we have received the basic information we list in the FAQ. So to speed resolution, make sure you provide all the basic information up front.

Again, just to emphasize, we are not saying we need a standalone test case to begin investigation, but we do need the extremely basic information we list in the FAQ, which takes just seconds to gather.

We've done everything we can to remind you to provide these details - we remind you of the required details in the text you have to delete in order to post, in the FAQ, in the documentation itself, and in your case, personally on the forums a number of times.

We're not sure what else we can do. But again, to speed resolution, please make a real effort to remember to provide the basics.

[Isomorphic]

We've found a real issue here which we're looking at how best to resolve.
However - it seems like there's an easy workaround you could use.
When you save your edits, you're essentially doing this:

lookupData.saveEdits("programmatic", function () { lookupData.endEditing() });

This essentially tells the grid to save the changes and then hide the editor (the endEditing() call).
When autoSaveEdits is true on your grid, endEditing will actually handle both performing the save and hiding the editor, so you don't need the separate saveEdits call.
Simply doing

lookupData.endEditing();

Should save out the edits and hide the editor for you, and should avoid this problem (the error icons should show up).

We're still looking at the underlying problem but it seems like this change should get things working for you. If it does not for some reason, please do let us know

Thanks
Isomorphic Software

[Isomorphic]

To follow up on this.
We've now made a framework change which should fix the underlying problem.
However, it does seem like using "endEditing" rather than a "saveEdits" followed by "endEditing" would just work for you and be slightly simpler.

Regards
Isomorphic Software

[Abdulaziz A.]

the Point that saveEdits does have a callback which is required in my case for some other reason wherein endEditing doesn't have the callback. that's why I can't use the endEditing alone.

As I understood you resolved the issue of saveEdits followed by endEditing . If this is the case then let me know in which version this fix is available