Announcement

**Isomorphic** · 7 Apr 2011, 15:33

Hi Alexey
This does sound like a bug - but we're not seeing it on our end.

The attached code doesn't run as it stands, so we had to flesh it out slightly to make it a running test case (attached below). It seems likely that there's something in the DataSource definition or other code in your version that's responsible. Can you show us your full standalone example, or modify the attached code enough that we can run it and see the problem?

Thanks

Code:

import com.google.gwt.core.client.EntryPoint;
import com.smartgwt.client.data.DataSource;
import com.smartgwt.client.data.DataSourceField;
import com.smartgwt.client.widgets.Canvas;
import com.smartgwt.client.widgets.IButton;
import com.smartgwt.client.widgets.events.ClickEvent;
import com.smartgwt.client.widgets.events.ClickHandler;
import com.smartgwt.client.widgets.form.DynamicForm;
import com.smartgwt.client.widgets.form.SearchForm;
import com.smartgwt.client.widgets.form.fields.FormItem;
import com.smartgwt.client.widgets.form.fields.events.ChangedEvent;
import com.smartgwt.client.widgets.form.fields.events.ChangedHandler;
import com.smartgwt.client.widgets.form.validator.MaskValidator;
import com.smartgwt.client.widgets.layout.VLayout;

public class ValidatorHandler implements EntryPoint {
    private DynamicForm form;

    public Canvas getViewPanel() {      
        form = new DynamicForm();
        
        DataSource testDS = new DataSource();
        DataSourceField cbIdf = new DataSourceField();
        cbIdf.setName("cbId");
        testDS.setFields(cbIdf);
        
        form.setDataSource(testDS);
        
        MaskValidator validator = new MaskValidator();
        validator.setMask("^\\s*(.*?)\\s*$");
        validator.setTransformTo("$1");
        
        FormItem cbId = new FormItem("cbId");
        cbId.addChangedHandler(new ChangedHandler() {
            public void onChanged(ChangedEvent event) {
                System.out.println("cbId - changed handler");
            }
        });
        cbId.setValidators(validator);
        
        form.setFields(cbId);

        VLayout layout = new VLayout();
        layout.addMember(form);
        
        IButton myButton = new IButton("validate");
        myButton.addClickHandler(new ClickHandler() {
            public void onClick(ClickEvent event) {
                form.validate();
            }

        });
        layout.addMember(myButton);
        
        return layout;
    }
    @Override
    public void onModuleLoad() {
        getViewPanel().draw();
        
    }
}

**alexey.wiesner** · 8 Apr 2011, 02:24

Hi Isomorphic,

Thanks for fast reply!
Seems that field type matters (and I have integer type in my DataSource), just try your code with this line:

Code:

        cbIdf.setType(FieldType.INTEGER);

Enter some digits as value into the field and click twice (or more) at 'validate' button. Reproducible in 100% cases in my environment.

Cheers,
Alexey

**Isomorphic** · 8 Apr 2011, 08:18

OK, this usage is now a bit strange because you've got a field being validated as an Integer but then you apply a validator meant for String fields.

What are you trying to achieve here? Your mask validator seems to be designed to trim off leading and trailing whitespace but the built-in Integer validation behavior already handles this - your additional validator is unnecessary.

**alexey.wiesner** · 11 Apr 2011, 01:55

Ok, first thing is: this space trimming validator is intended to be used for each form field which has to be trimmed, independent whether it is string or integer in DataSource. I shouldn't care about this actually.

Second thing is: it looks like that ANY kind of validatior with transforming doesn't work for integer fields, I tested this with following validator:

Code:

        MaskValidator validator = new MaskValidator();
        validator.setMask("^(\\d*?)0*$");
        validator.setTransformTo("$1");

This will trim trailing zeros, maybe nothing from the real life, but just as an example.

Cheers,
Alexey

**Isomorphic** · 11 Apr 2011, 04:43

Ok, we've put in a fix for this - it should hit tomorrow's nightly build

**Isomorphic** · 11 Apr 2011, 09:35

To clarify, the fix we've put in is going to cause your validator to not result in a exception. Your validator still does nothing because the field is declared as an Integer and hence is already parsed as an integer before your validator runs. Likewise your new validator does nothing. No String-based validator really makes sense on an Integer field.

**alexey.wiesner** · 14 Apr 2011, 04:57

Thanks for fixing this! No exception now and the validator works as well.
Can it be that this is fixed only for EE? In PE (2011-04-12) I still face this problem :(

**Isomorphic** · 14 Apr 2011, 08:25

It's not really possible, given how things about built, for this fix to apply to an Evaluate but not Power build. Check the timestamps of the files in your project to see if you are still using older files.

Also, bear in mind, what this is fix does is avoid a crash for some (useless) validators. There would be no behavior change other than avoiding the crash.

**alexey.wiesner** · 31 May 2011, 04:50

sorry for late answer, in PE it works as well, thx!

Cheers,
Alexey

Announcement

Validator + Handler don't work together properly

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment