Tab.setID broken ?

[richardwasim]

2011-07-13 Nightly evaluation (Enterprise) - SmartGWT 2.5
GWT 2.2
Firefox 5.0

If the id string has a space contained within, the setID routine breaks. This wasn't the case on my previous nightly (sometime ago).

The standalone case is below for you review and feedback :

    public void onModuleLoad() {
    	RootPanel.get().add(getCanvas());
    }

    public Canvas getCanvas() {

        VLayout layout = new VLayout();

        layout.setWidth(500);
        layout.setHeight(300);
        
        TabSet tabSet = new TabSet(); 
        
        Tab tab = new Tab("tab name");
        tab.setID("tab name"); //NOTE - No problems once space removed

        
        tabSet.addTab(tab);
        
        tabSet.setWidth100();
        tabSet.setHeight100();
        
        
        layout.addMember(tabSet);

        return layout;
    }

[sjivan]

This check was intentionally added. You probably see an assert failure message indicating that the ID must be a valid identifier (no spaces, must not start with a number etc). You might not have noticed but previously a tab with invalid ID actually fails in IE. So please update your code so that it uses a valid identifier.

Sanjiv

[richardwasim]

Already done. Thanks for the feedback.