Announcement

**Isomorphic** · 16 Aug 2011, 09:04

See DataSource.supportsAdvancedCriteria() - since the DateRangeItem generates AdvancedCriteria, it will not be used if your DataSource is not marked as supporting AdvancedCriteria.

If this doesn't appear to the problem, we'll need to see a minimal test case that we can run.

**lazinskip** · 16 Aug 2011, 14:19

Thanks for reply, to make it clear:
When datasource has setClientOnly(true), in EditorFilter I will get DateRangeItem (my standalone test case project)
What was confusing to me - in smartgwt 2.4 (my whole application was based on it) I has RangeDateItem in FilterEditor. I have whole server logic process it.
Right know I have to call setWillHandleAdvancedCriteria(true) to get DateRangeItem in EditorFilter. Moreover there was change in advancedcriteria structure message in xml. Before was criteria/elem/* for DateRangeItem right know "elem" tag does not exist. So I need to change server side logic.

**Isomorphic** · 16 Aug 2011, 14:24

We switched the default because another, much larger set of people were confused about AdvancedCriteria being automatically submitted by FilterEditors.

We don't know of an encoding change - can you show code where this occurs?

**lazinskip** · 30 Aug 2011, 09:50

Sorry for a delay, unfortunately I don't have example of xml message before change to smartgwt 2.5, all I have is xpath expression to parse fetch request and get search criteria:

Code:

//criteria/fieldName |  //criteria/value | //criteria/elem/fieldName | //criteria/elem/operator | //criteria/elem/value

now xml request look like this:

Code:

<request>
  <data>
    <AwarieDS constructor="AdvancedCriteria">
      <operator>equal</operator>
      <criteria>
        <fieldName>dataOd</fieldName>
        <operator>greaterOrEqual</operator>
        <value>2011-08-29T22:00:00</value>
      </criteria>
      <criteria>
        <fieldName>dataOd</fieldName>
        <operator>lessOrEqual</operator>
        <value>2011-08-30T21:59:59</value>
      </criteria>
      <criteria>
        <fieldName>dataDo</fieldName>
        <operator>greaterOrEqual</operator>
        <value>2011-08-29T22:00:00</value>
      </criteria>
      <criteria>
        <fieldName>dataDo</fieldName>
        <operator>lessOrEqual</operator>
        <value>2011-08-30T21:59:59</value>
      </criteria>
      <criteria>
        <fieldName>userLogin</fieldName>
        <operator>startsWith</operator>
        <value>a</value>
      </criteria>
      <fieldName>userId</fieldName>
      <value>2</value>
    </AwarieDS>
  </data>
  <dataSource>AwarieDS</dataSource>
  <operationType>fetch</operationType>
  <startRow>0</startRow>
  <endRow>30</endRow>
  <textMatchStyle>substring</textMatchStyle>
  <componentId>isc_ListGrid_0</componentId>
  <oldValues />
</request>

for a datasource:

Code:

public class AwarieDS extends RestDataSource {
	private static AwarieDS ds;
	private static Integer userId;
	public static AwarieDS getInstance(Integer a_userId){
		if (ds == null){
			ds = new AwarieDS("AwarieDS");
		}
		userId = a_userId;
		return ds;
	}
	public AwarieDS(String id) {
		setID(id);
		setDataFormat(DSDataFormat.XML);
		setDataProtocol(DSProtocol.POSTXML);
		setDataURL(GWT.getModuleBaseURL() + "Awaria.Service");
		OperationBinding addOB = new OperationBinding();
		addOB.setOperationType(DSOperationType.ADD);
		OperationBinding updateOB = new OperationBinding();
		updateOB.setOperationType(DSOperationType.UPDATE);
		OperationBinding removeOB= new OperationBinding();
		removeOB.setOperationType(DSOperationType.REMOVE);
		OperationBinding fetchOB= new OperationBinding();
		fetchOB.setOperationType(DSOperationType.FETCH);
		setOperationBindings(fetchOB,addOB,removeOB,updateOB);
		setWillHandleAdvancedCriteria(true);
		DataSourceIntegerField dsifIdAwarii= new DataSourceIntegerField("idAwarii");
		dsifIdAwarii.setPrimaryKey(true);
//		dsifIdAwarii.setHidden(true);
		DataSourceIntegerField dsifUserId = new DataSourceIntegerField("userId");
		dsifUserId.setForeignKey("UzytkownikDS.userId");
		dsifUserId.setHidden(true);
		DataSourceTextField dstfUserLogin = new DataSourceTextField("userLogin");
			
		DataSourceIntegerField dsifIdSlow = new DataSourceIntegerField("idSlow");
//		dsifIdSlow.setHidden(true);
		DataSourceTextField dstfNazwaSlow = new DataSourceTextField("nazwaSlow", "Kategoria");
		
		DataSourceIntegerField dsifIdElSl = new DataSourceIntegerField("idElSl");
		dsifIdElSl.setForeignKey("ElementyDS.idElSl");
//		dsifIdElSl.setHidden(true);
		DataSourceTextField dstfNazwaElem = new DataSourceTextField("nazwaElem" ,"Element");
		
		DataSourceDateTimeField dsdtfDataOd = new DataSourceDateTimeField("dataOd");
		DataSourceDateTimeField dsdtfDataDo= new DataSourceDateTimeField("dataDo");
		setFields(dsifIdAwarii, dsifIdSlow, dstfNazwaSlow, dsifIdElSl, dstfNazwaElem,dsifUserId, dstfUserLogin,dsdtfDataOd, dsdtfDataDo);
		
	}

	public AwarieDS(JavaScriptObject jsObj) {
		super(jsObj);
		// TODO Auto-generated constructor stub
	}
	protected Object transformRequest(DSRequest dsRequest){
		
		if (dsRequest.getOperationType() == DSOperationType.FETCH){
			JSOHelper.setAttribute(dsRequest.getData(), "fieldName", "userId");
			JSOHelper.setAttribute(dsRequest.getData(), "operator", "equal");
			JSOHelper.setAttribute(dsRequest.getData(), "value", userId);
			
		}else{
			JSOHelper.setAttribute(dsRequest.getData(), "userId", userId);
		}
		return super.transformRequest(dsRequest);
	}

}

as you can see the xpath expression:

Code:

//criteria/elem/fieldName | //criteria/elem/operator | //criteria/elem/value

is no longer valid because there is no "elem" tag in xml message

**Isomorphic** · 30 Aug 2011, 12:25

Sorry about this surprise change, but we won't be going back to the old format. However, we will (as part of 3.0) clean up the serialization a little and document exactly what to expect.

**lazinskip** · 1 Sep 2011, 11:52

That is ok, new format of xml message is much simpler to parse, but I think have found bug.
When window with grid with DateRangeItem is created and show, advanced criteria passed in xml message during fetching has a "elem" tag:

Code:

<request>
  <data>
    <AwarieDS constructor="AdvancedCriteria">
      <operator>equal</operator>
      <criteria>
        <_constructor>AdvancedCriteria</_constructor>
        <operator>and</operator>
        <criteria>
          <elem>
            <fieldName>dataOd</fieldName>
            <operator>greaterOrEqual</operator>
            <value>2011-08-31T22:00:00</value>
          </elem>
          <elem>
            <fieldName>dataOd</fieldName>
            <operator>lessOrEqual</operator>
            <value>2011-09-01T21:59:59</value>
          </elem>
        </criteria>
      </criteria>
      <criteria>
        <fieldName>userLogin</fieldName>
        <operator>startsWith</operator>
        <value>a</value>
      </criteria>
      <fieldName>userId</fieldName>
      <value>2</value>
    </AwarieDS>
  </data>
  <dataSource>AwarieDS</dataSource>
  <operationType>fetch</operationType>
  <startRow>0</startRow>
  <endRow>30</endRow>
  <textMatchStyle>substring</textMatchStyle>
  <componentId>isc_ListGrid_10</componentId>
  <oldValues />
</request>

but when I search again (clicking "filter" button in editorfilter) xml message has a new format:

Code:

<request>
  <data>
    <AwarieDS constructor="AdvancedCriteria">
      <operator>equal</operator>
      <criteria>
        <fieldName>dataOd</fieldName>
        <operator>greaterOrEqual</operator>
        <value>2011-08-31T22:00:00</value>
      </criteria>
      <criteria>
        <fieldName>dataOd</fieldName>
        <operator>lessOrEqual</operator>
        <value>2011-09-01T21:59:59</value>
      </criteria>
      <criteria>
        <fieldName>userLogin</fieldName>
        <operator>startsWith</operator>
        <value>a</value>
      </criteria>
      <fieldName>userId</fieldName>
      <value>2</value>
    </AwarieDS>
  </data>
  <dataSource>AwarieDS</dataSource>
  <operationType>fetch</operationType>
  <startRow>0</startRow>
  <endRow>30</endRow>
  <textMatchStyle>substring</textMatchStyle>
  <componentId>isc_ListGrid_10</componentId>
  <oldValues />
</request>

as you can see those are the very same criteria but xml message structure is different.
From now on, xml message will be always in new strukture. To get old one I have to close window and open it again (window is destroyed and created again)

**Isomorphic** · 1 Sep 2011, 12:30

Both criteria appear to be invalid ("equal" is not an operatorId that should have sub-criteria). Can you show code that reproduces a change in criteria format, but with valid criteria?

**lazinskip** · 1 Sep 2011, 12:44

Thanks for a quick reply, look at the datasource in my previous posts. There is transformRequest method which adds operator, fieldname and value tags. In every fetch request I need to pass logged user info. By the way my next question would be how to add additional criteria in transformRequest method to achieve message like:

Code:

<criteria>
      <fieldName>userId</fieldName>
      <operator>equal</operator>
      <value>2</value>
</criteria>

(inside criteria tag) - parsing would more simple

**lazinskip** · 1 Sep 2011, 13:12

I have checked xml message structure without transformRequest method. Results remain the same. First fetch old xml structure, every next in new xml structure.

**Isomorphic** · 1 Sep 2011, 14:28

Depending on whether a range has been entered for a date, the FilterEditor of a ListGrid may product simple criteria, AdvancedCriteria consisting of one Criterion, or AdvancedCriteria consisting of a logical operator and multiple sub-Criteria.

This is correct behavior.

The problem is that you are blindly applying 3 attributes to the criteria, without first checking if the inbound criteria is an AdvancedCriteria with a top-level logical operator (which it appears to be in second case). The predictable result is broken criteria.

If you getCriteria() and the result is AdvancedCriteria, you can use helpers such as DataSource.combineCriteria() to add an additional Criterion, then supply the final criteria via dsRequest.setData(finalCriteria.getJSObj()).

**lazinskip** · 1 Sep 2011, 22:21

Depending on whether a range has been entered for a date, the FilterEditor of a ListGrid may product simple criteria, AdvancedCriteria consisting of one Criterion, or AdvancedCriteria consisting of a logical operator and multiple sub-Criteria.

ok, but it doesn't explain why with the same conditions in editorFilter first fetch has different structure than next requests.
for the first request xml message:

Code:

<request>
  <data>
    <AwarieDS constructor="AdvancedCriteria">
      <operator>equal</operator>
      <criteria>
        <_constructor>AdvancedCriteria</_constructor>
        <operator>and</operator>
        <criteria>
          <elem>
            <fieldName>dataOd</fieldName>
            <operator>greaterOrEqual</operator>
            <value>2011-08-31T22:00:00</value>
          </elem>
          <elem>
            <fieldName>dataOd</fieldName>
            <operator>lessOrEqual</operator>
            <value>2011-09-02T21:59:59</value>
          </elem>
        </criteria>
      </criteria>
      <criteria>
        <_constructor>AdvancedCriteria</_constructor>
        <operator>and</operator>
        <criteria>
          <elem>
            <fieldName>dataDo</fieldName>
            <operator>greaterOrEqual</operator>
            <value>2011-08-31T22:00:00</value>
          </elem>
          <elem>
            <fieldName>dataDo</fieldName>
            <operator>lessOrEqual</operator>
            <value>2011-09-02T21:59:59</value>
          </elem>
        </criteria>
      </criteria>
      <criteria>
        <fieldName>userLogin</fieldName>
        <operator>startsWith</operator>
        <value>a</value>
      </criteria>
      <fieldName>userId</fieldName>
      <value>2</value>
    </AwarieDS>
  </data>
  <dataSource>AwarieDS</dataSource>
  <operationType>fetch</operationType>
  <startRow>0</startRow>
  <endRow>30</endRow>
  <textMatchStyle>substring</textMatchStyle>
  <componentId>isc_ListGrid_2</componentId>
  <oldValues />
</request>

every next request (without changing anything in filterEditor) has xml request:

Code:

<request>
  <data>
    <AwarieDS constructor="AdvancedCriteria">
      <operator>equal</operator>
      <criteria>
        <fieldName>dataOd</fieldName>
        <operator>greaterOrEqual</operator>
        <value>2011-08-31T22:00:00</value>
      </criteria>
      <criteria>
        <fieldName>dataOd</fieldName>
        <operator>lessOrEqual</operator>
        <value>2011-09-02T21:59:59</value>
      </criteria>
      <criteria>
        <fieldName>dataDo</fieldName>
        <operator>greaterOrEqual</operator>
        <value>2011-08-31T22:00:00</value>
      </criteria>
      <criteria>
        <fieldName>dataDo</fieldName>
        <operator>lessOrEqual</operator>
        <value>2011-09-02T21:59:59</value>
      </criteria>
      <criteria>
        <fieldName>userLogin</fieldName>
        <operator>startsWith</operator>
        <value>a</value>
      </criteria>
      <fieldName>userId</fieldName>
      <value>2</value>
    </AwarieDS>
  </data>
  <dataSource>AwarieDS</dataSource>
  <operationType>fetch</operationType>
  <startRow>0</startRow>
  <endRow>30</endRow>
  <textMatchStyle>substring</textMatchStyle>
  <componentId>isc_ListGrid_2</componentId>
  <oldValues />
</request>

as I have mentioned removing transformRequest method from my code doesn't change this behaviour

**Isomorphic** · 2 Sep 2011, 09:12

Yes, this is the criteria *after you've applied random properties to it*. Remove your code and you will see that criteria with the same meaning are passed the first and second time.

**lazinskip** · 5 Sep 2011, 09:45

I think we can't understand each other
I have removed code and still first request is different from next requests. To be perfectly sure I have created standalone test case.
My entry point:

Code:

public class SgwtListGridFilterEditor implements EntryPoint {
	private HLayout hlTlo = new HLayout();
		private ListGrid lgDaty = new ListGrid();
			private ListGridField lgfIdDaty = new ListGridField("idDaty");
			private ListGridField lgfDataOd = new ListGridField("dataOd");
			private ListGridField lgfDataDo = new ListGridField("dataDo");

	/**
	 * This is the entry point method.
	 */
	public void onModuleLoad() {
		DateUtil.setShortDatetimeDisplayFormatter(new DateDisplayFormatter() {
			
			@Override
			public String format(Date date) {
				DateTimeFormat dtf = DateTimeFormat.getFormat("yyyy-MM-dd HH:mm:ss");
				
				return dtf.format(date);
			}
		});
		DateUtil.setDateInputFormat("YMD");
		DateUtil.setDateParser(new DateParser() {
			
			@Override
			public Date parse(String dateString) {
				DateTimeFormat dtf = DateTimeFormat.getFormat("yyyy-MM-dd HH:mm:ss");
				Date wynik = dtf.parse(dateString);
				return wynik;
			}
		});
		hlTlo.setSize("100%", "100%");
		hlTlo.setShowEdges(true);
			lgDaty.setDataSource(DatyDS.getInstance());
			lgDaty.setAutoFetchData(false);
			lgDaty.setShowFilterEditor(true);
			lgDaty.setCanMultiSort(false);
			lgDaty.setCanEdit(true);
				lgfIdDaty.setWidth("10%");
				
				lgfDataOd.setWidth("45%");
				lgfDataDo.setWidth("45%");
			lgDaty.setFields(lgfIdDaty, lgfDataOd, lgfDataDo);
		hlTlo.addMember(lgDaty);	
		hlTlo.draw();

	}
}

my datasource

Code:

public class DatyDS extends RestDataSource {
	private static DatyDS datyDs;
	public static DatyDS getInstance(){
		if (datyDs == null){
			datyDs = new DatyDS("datyDS");
		}
		return datyDs;
	}
	public DatyDS(String id) {
		super();
		setID(id);
		setDataFormat(DSDataFormat.XML);
		setDataProtocol(DSProtocol.POSTXML);
		setDataURL("/DatyDs.xml");
		OperationBinding addOB = new OperationBinding();
		addOB.setOperationType(DSOperationType.ADD);
		OperationBinding updateOB = new OperationBinding();
		updateOB.setOperationType(DSOperationType.UPDATE);
		OperationBinding removeOB= new OperationBinding();
		removeOB.setOperationType(DSOperationType.REMOVE);
		OperationBinding fetchOB= new OperationBinding();
		fetchOB.setOperationType(DSOperationType.FETCH);
		setOperationBindings(fetchOB,addOB,removeOB,updateOB);
		setRecordXPath("/Lista/rekord");
		DataSourceIntegerField dsifIdDaty = new DataSourceIntegerField("idDaty", "Nr rekordu");
		dsifIdDaty.setPrimaryKey(true);
		DataSourceDateTimeField dsdtfDataOd = new DataSourceDateTimeField("dataOd");
		DataSourceDateTimeField dsdtfDataDo = new DataSourceDateTimeField("dataDo");
		setFields(dsifIdDaty,dsdtfDataOd, dsdtfDataDo);
		setWillHandleAdvancedCriteria(true);
		
	}
	protected Object transformRequest(DSRequest dsRequest){
	
	if (dsRequest.getOperationType() == DSOperationType.FETCH){
		System.out.println(xmlSerialize(dsRequest.getData()));
	}
	return super.transformRequest(dsRequest);
}

xml file served by web server:

Code:

<?xml version="1.0" encoding="UTF-8"?>
<Lista>
	<rekord>
		<idDaty>1</idDaty>
		<dataOd>2011-08-01 10:24:56</dataOd>
		<dataDo>2011-08-02 11:14:56</dataDo>
	</rekord>
	<rekord>
		<idDaty>2</idDaty>
		<dataOd>2011-08-02 11:34:11</dataOd>
		<dataDo>2011-08-05 14:11:34</dataDo>
	</rekord>
	<rekord>
		<idDaty>3</idDaty>
		<dataOd>2011-08-06 17:56:23</dataOd>
	</rekord>
</Lista>

first request:

Code:

<datyDS constructor="AdvancedCriteria">
    <operator>and</operator>
    <criteria>
    	<_constructor>AdvancedCriteria</_constructor>
    	<operator>and</operator>
    	<criteria>
    		<elem>
    			<fieldName>dataOd</fieldName>
    			<operator>greaterOrEqual</operator>
    			<value>2011-09-03T22:00:00</value>
    		</elem>
    		<elem>
    			<fieldName>dataOd</fieldName>
    			<operator>lessOrEqual</operator>
    			<value>2011-09-05T21:59:59</value>
    		</elem>
    	</criteria>
    </criteria>
    <criteria>
    	<_constructor>AdvancedCriteria</_constructor>
    	<operator>and</operator>
    	<criteria>
    		<elem>
    			<fieldName>dataDo</fieldName>
    			<operator>greaterOrEqual</operator>
    			<value>2011-09-04T22:00:00</value>
    		</elem>
    		<elem>
    			<fieldName>dataDo</fieldName>
    			<operator>lessOrEqual</operator>
    			<value>2011-09-06T21:59:59</value>
    		</elem>
    	</criteria>
    </criteria>
</datyDS>

next request:

Code:

<datyDS constructor="AdvancedCriteria">
    <operator>and</operator>
    <criteria>
    	<fieldName>dataOd</fieldName>
    	<operator>greaterOrEqual</operator>
    	<value>2011-09-03T22:00:00</value>
    </criteria>
    <criteria>
    	<fieldName>dataOd</fieldName>
    	<operator>lessOrEqual</operator>
    	<value>2011-09-05T21:59:59</value>
    </criteria>
    <criteria>
    	<fieldName>dataDo</fieldName>
    	<operator>greaterOrEqual</operator>
    	<value>2011-09-04T22:00:00</value>
    </criteria>
    <criteria>
    	<fieldName>dataDo</fieldName>
    	<operator>lessOrEqual</operator>
    	<value>2011-09-06T21:59:59</value>
    </criteria>
</datyDS>

as you can see there is no any attempts to change criteria passed from framework but still requests differ.
I don't understand why in first request there are "elem tags and in second request structure is simpler.

**Isomorphic** · 5 Sep 2011, 11:54

The two criteria are equivalent, the second is a valid simplification of the structure of the first, not a difference in serialization.

As far as <elem> vs absence of <elem>, as we previously indicated we will be documenting and normalizing the XML serialized structure of AdvancedCriteria - as it stands you can simply ignore the <elem> tags.

Announcement

ListGrid Filter Editor datechooser problem

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment