Issue with SmartGWT 2.5 (latest smartgwt.jar)

[krishnafse2009]

Be sure your post includes:

1. SmartGWT Power 2.5

2. No server side logs

3. No client side logs required.

4. Compilation error after using the smartgwt.jar (for enterprise skin issue).

5. Compilation error pointing to CloseClickHandler() of Window(emailWindow)

emailWindow.addCloseClickHandler(new CloseClickHandler() {
public void onCloseClick(CloseClientEvent event) {
emailWindow.destroy();
}
});

The error : closeclient event cannot be resolved to a type.

Is there any API change in the events related to closing the Windows.

[Isomorphic]

CloseClientEvent was a typo/thinko that was corrected. The correct name is CloseClickEvent.

[krishnafse2009]

We have been using this since 2.x and how come it becomes a typo now. Last time we had another issue with set id api and we have rewrtte/change the existing api's in almost 300+ places. Again now we have to change in 300+ place for the same. you should either deprecate it or give the developing community time to change. Changing the API after so many releases is not the right way of developing the software.

[Isomorphic]

??

There has never been a change to setID() that should have required any code changes.

Fixing this typo is a search and replace that should take about 30 seconds no matter how large the project.

[Isomorphic]

Just to further clarify - this is a name change only, no behavior change.

[krishnafse2009]

it is not about replacing all with new names. We are using this in QA and Production environments. We did not test the 2.5 so that we can move this to production. right now 2.4 is in production. it is easy to say that replace all. Will 2.5 works with out any issue like 2.4. if I replace and if the replaced code goes to production it will be an issue. i cannot chnge the api just like this. you need to understand the reality before suggesting this kind of answers.

[Isomorphic]

The reality is that you can't compile against one version and deploy against another version anyway, GWT's application artifacts are version-specific. We're not adding any extra dependencies.

[krishnafse2009]

I never heard any software that we need to change the code for every version. it is funny to see your reply that i cannot compile one version of smartgwt with another version of smartgwt. so every time you will keep on changing the apis and the developers has to do a replace all. do you think it is the best practice in industry. This is highly dependent and we cannot move to next version untill it is properly tested in a sperate environment. dont be critical to other if they point out the mistake. if it realy a type you should have changed in first version itself and rather than changing it next release. I dont think you aware of depraction process in java or other languages. it is used universally in developing software. i am not pointing your mistake here and i am bring my issue caused by your api changes.

[Isomorphic]

Java deprecation implies you need to change the code at some point. 2.5 was that point. No other versions have ever introduced any need for code changes, and this one is a 30 second name-only change, as already explained.

Once again, this doesn't make testing or deployment more complex. It's a limitation of GWT (not SmartGWT) that you must compile your code against a given version of GWT and deploy the whole thing as a bundle. You cannot take a compiled application and deploy it with a different runtime - recompilation is always required.

[wema]

There are too many files that need to be changed!!!!!
30 second for a file is ok.
But there are too many files that need to be changed!!!
Why you not just add new method and keep old method?

Java deprecation implies you need to change the code at some point. 2.5 was that point. No other versions have ever introduced any need for code changes, and this one is a 30 second name-only change, as already explained.

Once again, this doesn't make testing or deployment more complex. It's a limitation of GWT (not SmartGWT) that you must compile your code against a given version of GWT and deploy the whole thing as a bundle. You cannot take a compiled application and deploy it with a different runtime - recompilation is always required.

[Isomorphic]

What is this post about? Did you mean to post in this thread?

If so, 30 seconds is a generous estimate for the time to search and replace on the whole of your codebase.