Announcement

**Isomorphic** · 15 Mar 2012, 13:08

Switching the FieldPicker to a different type of FormItem with a different data model isn't a use case we had in mind, so the FilterBuilder is being tripped up by the absence of expected APIs.

A better way of doing this, which will also support load on demand for larger trees and is generally a quicker UI for picking an item, is to stick with a SelectItem and create the appearance of a tree with indentation. For example, you can return a third property "treeLevel" and add a CellFormatter via PickListFields that indents the value according to it's treeLevel.

**bbruyn** · 15 Mar 2012, 13:30

Fair enough, but the API doc does say that fieldPickerProperties takes any FormItem. Can you clarify whether or not any other FormItem is supported?

I'm just not sure I'll be able to get away with an indented SelectItem. If I am, can you confirm that I should see my issue #1 behave as expected? i.e., the 2nd SelectItem would take the appearance of the first?

**Isomorphic** · 15 Mar 2012, 13:36

The API lets you use more than one FormItem type (eg ComboBoxItem or SelectItem), it just didn't expect one using a Tree as it's data model.

We'll check on the matchesField case.

**bbruyn** · 19 Mar 2012, 11:25

Originally posted by Isomorphic

We'll check on the matchesField case.

A quick test on my end seems to show that fieldPickerProperties is not respected in the matchesField case. Should it be?

**Isomorphic** · 19 Mar 2012, 12:52

It's a little ambiguous because while it is a field picker, it's also a valueField. Current thinking is that we will apply both sets of customizations to the field, with the fieldPickerProperties winning. Should be roughly late this week.

**bbruyn** · 20 Mar 2012, 08:32

I'm still struggling with this a bit. I thought I might use FilterBuilder.setFieldDataSource to get my tree data in the list. This works, but then it seems that my cellFormatter callback is never fired?

A slight modification to a showcase example:

Code:

	public void onModuleLoad() {

		ListGridRecord testData[] = new ListGridRecord[200];  
		  
        for(int i=0;i<200;i++)  
        {  
            ListGridRecord record = new ListGridRecord();  
            record.setAttribute("name", "field" + i);  
            record.setAttribute("title", "Field " + i);  
            record.setAttribute("type", "text");  
            testData[i] = record;  
        }  
  
        DataSource bigFilterDS = new DataSource();  
        bigFilterDS.setClientOnly(true);  
  
        DataSourceTextField nameField = new DataSourceTextField("name");  
        DataSourceTextField titleField = new DataSourceTextField("title");  
        DataSourceTextField typeField = new DataSourceTextField("type");  
  
        bigFilterDS.setFields(nameField, titleField, typeField);  
        bigFilterDS.setTestData(testData);  
  
        FilterBuilder filterBuilder = new FilterBuilder();  
        filterBuilder.setFieldDataSource(bigFilterDS);  
  
        AdvancedCriteria criteria = new AdvancedCriteria(OperatorId.AND, new AdvancedCriteria[] {  
                new AdvancedCriteria("field2", OperatorId.ISTARTS_WITH, "C"),  
                new AdvancedCriteria(OperatorId.OR, new AdvancedCriteria[] {  
                    new AdvancedCriteria("field73", OperatorId.NOT_EQUAL_FIELD, "field191"),  
                    new AdvancedCriteria("field130", OperatorId.ICONTAINS, "B")  
                })  
        });  
  
        filterBuilder.setCriteria(criteria);  
  
        SelectItem formItemProperties = new SelectItem();  
        formItemProperties.setShowPickerIcon(false);  
        ListGrid pickListProperties = new ListGrid();
		pickListProperties.setCellFormatter(new CellFormatter() {
			public String format(Object value, ListGridRecord record, int rowNum, int colNum) {
				GWT.log(record.getAttribute("name"));
				return value.toString();
			}
		});
		formItemProperties.setPickListProperties(pickListProperties);
		filterBuilder.setFieldPickerProperties(formItemProperties); 
        
		filterBuilder.draw();

		if (!GWT.isScript()) {
			KeyIdentifier debugKey = new KeyIdentifier();
			debugKey.setCtrlKey(true);
			debugKey.setAltKey(true);
			debugKey.setKeyName("D");
			Page.registerKey(debugKey, new KeyCallback() {
				public void execute(String keyName) {
					SC.showConsole();
				}
			});
		}
	}

**Isomorphic** · 20 Mar 2012, 10:17

Set it via setPickListFields() as a field-specific CellFormatter. The problem is that the framework is already supplying a field-specific formatter, so that overrides.

**Isomorphic** · 21 Mar 2012, 15:22

We've now added support for the field picker properties being applied to the "other field" chooser in 3.0p and 3.1d branches.

The request for PickTreeItem support also came up in a separate thread and we made the changes necessary to support this. The formatted SelectItem is probably still actually a cleaner user experience but if you're interested in experimenting with your original approach it should now work for you. One minor tweak - you'll have to explicitly call pt.setValueField("name"); on the field picker

**bbruyn** · 21 Mar 2012, 16:52

That's awesome. Thanks very much for knocking that out.

Wll the pick tree support be present in 3.0p as well? And in either case, could I expect that to work with the 'other field' chooser also?

**bbruyn** · 22 Mar 2012, 07:57

I had a chance to test today's 3.0p build with the formatted SelectItem. The fieldPickerProperties is displayed properly in the 'other field' chooser, but:

1) No fetch is fired when I actually exceute the filter.
2) After initially setting the operator to 'other field', attempts to change the criteria (by changing the 1st operand or the operator) add additional 'other field' choosers to the layout. Screenshot attached.

Code:

08:53:03.600:IFCS9:INFO:layout:isc_PickListMenu_0:adding newMembers: [GridBody ID:isc_PickListMenu_0_body] at position: 0
08:53:03.659:IFCS9:INFO:layout:isc_PickListMenu_0:layoutChildren (reason: initial draw):
layout specified size: 146w x 1h
drawn size: 146w x 98h
available size: 146w x 1h (length)
   [GridBody ID:isc_PickListMenu_0_body]
      98 drawn length (resizeLength: 1) (policyLength: *) (no length specified)
      146 drawn breadth (breadth policy: fill)

08:53:06.290:IFCS6[E]:INFO:layout:isc_FilterBuilder_0_clause:Restacking, reason: memberResized: (150,0): isc_FilterBuilder_0_clause_clause
08:53:06.292:IFCS6[E]:INFO:layout:isc_FilterBuilder_0_clauseStack:Restacking, reason: memberResized: (150,0): isc_FilterBuilder_0_clause
08:53:07.485:IFCS4:INFO:layout:isc_PickListMenu_1:adding newMembers: [GridBody ID:isc_PickListMenu_1_body] at position: 0
08:53:07.585:IFCS4:INFO:layout:isc_PickListMenu_1:layoutChildren (reason: initial draw):
layout specified size: 146w x 1h
drawn size: 178w x 302h
available size: 146w x 1h (length)
   [GridBody ID:isc_PickListMenu_1_body]
      302 drawn length (resizeLength: 1) (policyLength: *) (no length specified)
      146 drawn breadth (breadth policy: fill)

08:53:16.579:IFCS2[E]:INFO:layout:isc_FilterBuilder_0_clause:Restacking, reason: memberResized: (150,0): isc_FilterBuilder_0_clause_clause
08:53:16.581:IFCS2[E]:INFO:layout:isc_FilterBuilder_0_clauseStack:Restacking, reason: memberResized: (150,0): isc_FilterBuilder_0_clause

Could this be my problem, or have I found a bug?

Attached Files

**bbruyn** · 23 Mar 2012, 10:33

Still anxious to hear what you make of this... I don't see how it could be a problem on my end - you should be able to use the code posted previously to reproduce it.

**Isomorphic** · 26 Mar 2012, 10:55

This was on our end.
It turned out to be an issue with the SGWT wrapper code that we had missed. Fixed now. Please try the next nightly build and let us know if you hit anything else that doesn't work as expected here

Regards
Isomorphic Software

**bbruyn** · 27 Mar 2012, 08:00

Getting closer, I think. Tested with the 3/27 3.0p nightly (3.1d is missing).

Now if I select a field, operator, other field and then switch the operator, the 'other field' value remains in the 2nd operand. Screenshot attached.

Attached Files

**Isomorphic** · 28 Mar 2012, 10:07

Looks like this is not related to the field picker customization - this same behavior (retaining the field name when you move from "matches other field" to "contains" for example) exists without the picker customization

However, we agree that it's basically a bug. We'll take care of it
--
Update - this is now addressed - the change will show up in nightlies going forward

Announcement

FilterBuilder FieldPicker using PickTreeItem

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment