Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

    5.1d shows browser scrollbars for TextAreaItem and does not remove them afterwards

    Hi Isomorphic,

    please see this browser scrollbar issue with this BuiltInDS based sampled (SNAPSHOT_v10.1d_2015-10-13/PowerEdition Deployment).

    BuiltInDS.java:
    Code:
    package com.smartgwt.sample.client;
    
    import com.google.gwt.core.client.EntryPoint;
    import com.smartgwt.client.core.KeyIdentifier;
    import com.smartgwt.client.data.DataSource;
    import com.smartgwt.client.data.SortSpecifier;
    import com.smartgwt.client.types.SortDirection;
    import com.smartgwt.client.util.Page;
    import com.smartgwt.client.util.PageKeyHandler;
    import com.smartgwt.client.util.SC;
    import com.smartgwt.client.widgets.IButton;
    import com.smartgwt.client.widgets.Window;
    import com.smartgwt.client.widgets.events.ClickEvent;
    import com.smartgwt.client.widgets.events.ClickHandler;
    import com.smartgwt.client.widgets.grid.ListGrid;
    import com.smartgwt.client.widgets.grid.ListGridField;
    
    public class BuiltInDS implements EntryPoint {
        private IButton recreateBtn;
        private DataSource supplyItemDS = DataSource.get("supplyItem");
    
        public void onModuleLoad() {
            KeyIdentifier debugKey = new KeyIdentifier();
            debugKey.setCtrlKey(true);
            debugKey.setKeyName("D");
    
            Page.registerKey(debugKey, new PageKeyHandler() {
                public void execute(String keyName) {
                    SC.showConsole();
                }
            });
    
            recreateBtn = new IButton("Recreate");
            recreateBtn.addClickHandler(new ClickHandler() {
                @Override
                public void onClick(ClickEvent event) {
                    recreate();
                }
            });
            recreate();
            recreateBtn.draw();
        }
    
        private void recreate() {
            Window w = new Window();
            w.setWidth("95%");
            w.setHeight("95%");
            w.setMembersMargin(0);
            w.setModalMaskOpacity(70);
            w.setTitle("Scrollbar appears for TextAreaItem");
            w.setShowMinimizeButton(false);
            w.setIsModal(true);
            w.setShowModalMask(true);
            w.centerInPage();
    
            final ListGrid lg = new ListGrid(supplyItemDS);
            lg.setCanEdit(true);
            lg.setAutoFetchData(false);
    
            ListGridField itemIdLGF = new ListGridField("itemID");
            ListGridField itemNameLGF = new ListGridField("itemName");
            ListGridField skuLGF = new ListGridField("SKU");
            ListGridField descriptionLGF = new ListGridField("description");
            ListGridField categoryLGF = new ListGridField("category");
            ListGridField unitsLGF = new ListGridField("units");
    
            lg.setFields(itemIdLGF, itemNameLGF, skuLGF, descriptionLGF, categoryLGF, unitsLGF);
    
            lg.setSort(new SortSpecifier[] { new SortSpecifier(itemIdLGF.getName(), SortDirection.ASCENDING),
                    new SortSpecifier(itemNameLGF.getName(), SortDirection.ASCENDING) });
    
            lg.fetchData();
            IButton addNewBtn = new IButton("Add new row");
            addNewBtn.addClickHandler(new ClickHandler() {
                @Override
                public void onClick(ClickEvent event) {
                    lg.startEditingNew();
                }
            });
    
            w.addItem(lg);
            w.addItem(addNewBtn);
            w.show();
        }
    }
    Steps to recreate:
    1. I used maximized-window FF26 in DevMode
    2. Open testcase
    3. Click "Add new row"
    4. Move to the "description"-field
    5. The TextAreaItem box opens and is larger than the remaining space to the window-bottom.
    6. Scrollbars (H and V) appear
    7. Leave the box
    8. Horizontal scrollbar disappears, Vertical Scrollbar stays
    9. Close the window
    10. Vertical Scrollbar stays

    I don't know if the error is in step 6 (not browser scrollbars should be displayed at all) or in step 8 (scrollbar not removed), but this feels like a bug (I did not test with 5.0p).

    Best regards
    Blama
    Attached Files

    #2
    Hello Blama,

    Thanks for bringing this to our attention. We have been able to reproduce the issue, please bare with us while we're working on a solution.

    Thanks,
    Isomorphic Software

    Comment


      #3
      This issue has now been resolved and the fix will be available in the next nightly build.

      Regards,
      Isomorphic Software

      Comment

      Working...
      X