5.1d 5.0p BatchUploader Bug on CSV file with 2 newlines in the end

[Blama]

Hi Isomorphic,

please download the csv file from the BatchUploader sample.
Add another newline in the end to it (making it two empty rows) and upload it. You'll get a server error message and no ListGrid with data.

5.1d Server log:

java.lang.ArrayIndexOutOfBoundsException: -1
    at java.util.ArrayList.elementData(Unknown Source)
    at java.util.ArrayList.get(Unknown Source)
    at com.isomorphic.tools.DataImport.trimTrailingEmptyColumns(DataImport.java:1332)
    at com.isomorphic.tools.DataImport.importToRows(DataImport.java:1057)
    at com.isomorphic.tools.DataImport.importAndValidateDSRows(DataImport.java:370)
    at com.isomorphic.tools.DataImport.importAndValidateDSRows(DataImport.java:311)
    at com.isomorphic.tools.BatchUpload.internalBatchUpload(BatchUpload.java:171)
    at com.isomorphic.tools.BatchUpload.batchUpload(BatchUpload.java:88)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at com.isomorphic.base.Reflection.adaptArgsAndInvoke(Reflection.java:964)
    at com.isomorphic.datasource.DataSourceDMI.execute(DataSourceDMI.java:415)
    at com.isomorphic.datasource.DataSourceDMI.execute(DataSourceDMI.java:64)
    at com.isomorphic.datasource.DSRequest.execute(DSRequest.java:2643)
    at com.isomorphic.servlet.IDACall.handleDSRequest(IDACall.java:221)
    at com.isomorphic.servlet.IDACall.processRPCTransaction(IDACall.java:186)
    at com.isomorphic.servlet.IDACall.processRequest(IDACall.java:151)
    at com.isomorphic.servlet.IDACall._processRequest(IDACall.java:118)
    at com.isomorphic.servlet.IDACall.doPost(IDACall.java:78)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:755)
    at com.isomorphic.servlet.BaseServlet.service(BaseServlet.java:156)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:848)
    at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:686)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1494)
    at com.isomorphic.servlet.CompressionFilter._doFilter(CompressionFilter.java:260)
    at com.isomorphic.servlet.BaseFilter.doFilter(BaseFilter.java:83)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1474)
    at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:499)
    at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
    at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
    at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
    at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)
    at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:428)
    at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
    at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)
    at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
    at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
    at org.eclipse.jetty.server.handler.RequestLogHandler.handle(RequestLogHandler.java:68)
    at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
    at org.eclipse.jetty.server.Server.handle(Server.java:370)
    at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:489)
    at org.eclipse.jetty.server.AbstractHttpConnection.content(AbstractHttpConnection.java:960)
    at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.content(AbstractHttpConnection.java:1021)
    at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:865)
    at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:240)
    at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:82)
    at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:668)
    at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:52)
    at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)
    at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)
    at java.lang.Thread.run(Unknown Source)
=== 2015-10-23 16:19:01,710 [1-37] DEBUG BatchUpload - Rows: null
=== 2015-10-23 16:19:01,710 [1-37] DEBUG BatchUpload - Errors: [
]
=== 2015-10-23 16:19:01,711 [1-37] DEBUG BatchUpload - Errors after conversion: [
    "-1\n\nSee the log for more details about this error."
]
=== 2015-10-23 16:19:01,711 [1-37] INFO  DSResponse - DSResponse: Map with 3 keys
=== 2015-10-23 16:19:01,711 [1-37] DEBUG DSRequest - About to free up resources for request of type update on DataSource batchUpload
=== 2015-10-23 16:19:01,712 [1-37] DEBUG DSRequest - Ignoring freeResources call because this is not a primary request!
=== 2015-10-23 16:19:01,712 [1-37] DEBUG RPCManager - Content type for RPC transaction: text/html; charset=UTF-8
=== 2015-10-23 16:19:01,712 [1-37] DEBUG RPCManager - DMI response, dropExtraFields: false
=== 2015-10-23 16:19:01,714 [1-37] DEBUG DSRequest - Ignoring freeQueueResources call because this is not a primary request!
=== 2015-10-23 16:19:01,714 [1-37] INFO  Compression - /builtinds/sc/IDACall: 762 -> 476 bytes
=== 2015-10-23 16:19:02,524 [1-48] INFO  Download - Returning 304: Not modified on conditional get of: C:\Users\salekt\workspace\lib\smartgwtpower-5.1d\samples\built-in-ds\war\builtinds\sc\skins\Enterprise\images\blank.gif

Tested with the online showcase (5.0p) and 5.1d based BuiltInDS.

Best regards
Blama

[Isomorphic]

This issue has been solved. The fix will be available in builds dated October 27 and later.

Regards
Isomorphic Software

[Blama]

Hi Isomorphic,

this is fixed for me using SNAPSHOT_v10.1d_2015-10-29.

Thank you
Blama