Announcement

Collapse
No announcement yet.
X
Collapse
  • Page of 1
  • Filter
  • Time
Clear All
new posts
Previous template Next
    #1

    Bug: Group and Sort by Date

    Hi,

    I use the latest 6.0p Build from 04.07. Please try my showcase. And try the following workflow:

    1. Click on the date columen of the list grid and open the ListGrid header menu
    2. Click "Group by date" and choose the option "by date"
    3. Click on the column header for sorting by date (try Asc and Desc)
    4. You can see now, that the dates are not in a correct sort order

    ​

    If you sort before you group... everything is working fine... but if group before sorting... the order is wrong.



    Please try the following showcase:

    Code:
    import java.util.Date;
import java.util.LinkedHashMap;

import com.google.gwt.i18n.client.NumberFormat;
import com.google.gwt.user.datepicker.client.CalendarUtil;
import com.smartgwt.client.data.Criteria;
import com.smartgwt.client.data.DataSource;
import com.smartgwt.client.data.Record;
import com.smartgwt.client.data.RecordList;
import com.smartgwt.client.data.events.DataChangedEvent;
import com.smartgwt.client.data.events.DataChangedHandler;
import com.smartgwt.client.data.fields.DataSourceDateField;
import com.smartgwt.client.data.fields.DataSourceFloatField;
import com.smartgwt.client.data.fields.DataSourceSequenceField;
import com.smartgwt.client.data.fields.DataSourceTextField;
import com.smartgwt.client.types.Alignment;
import com.smartgwt.client.types.AutoFitWidthApproach;
import com.smartgwt.client.types.FetchMode;
import com.smartgwt.client.types.GroupStartOpen;
import com.smartgwt.client.types.Overflow;
import com.smartgwt.client.types.RecordDropAppearance;
import com.smartgwt.client.types.SummaryFunctionType;
import com.smartgwt.client.util.SC;
import com.smartgwt.client.widgets.Canvas;
import com.smartgwt.client.widgets.Window;
import com.smartgwt.client.widgets.events.ClickEvent;
import com.smartgwt.client.widgets.events.ClickHandler;
import com.smartgwt.client.widgets.form.DynamicForm;
import com.smartgwt.client.widgets.grid.CellFormatter;
import com.smartgwt.client.widgets.grid.ListGrid;
import com.smartgwt.client.widgets.grid.ListGridField;
import com.smartgwt.client.widgets.grid.ListGridRecord;
import com.smartgwt.client.widgets.layout.VLayout;
import com.smartgwt.client.widgets.toolbar.ToolStrip;
import com.smartgwt.client.widgets.toolbar.ToolStripButton;
import com.smartgwt.client.widgets.viewer.DetailViewer;

public class GTestGrid
{

    private ListGrid listGrid;
    private DynamicForm editorForm;

    public GTestGrid()
    {
        initPopUp();
    }

    private void initPopUp()
    {
        initListGrid();
        initEditorForm();

        VLayout layout = new VLayout();
        layout.setSize( "100%", "100%" );
        layout.setMembers( editorForm, getToolBar(), listGrid );
        layout.setOverflow( Overflow.HIDDEN );

        Window window = new Window();
        window.setOverflow( Overflow.HIDDEN );
        window.setShowShadow( true );
        window.setShadowSoftness( 10 );
        window.setShadowOffset( 5 );
        window.setSize( "100%", "100%" );
        window.setCanDragResize( true );
        window.setShowMaximizeButton( true );
        window.setShowMinimizeButton( true );
        window.setShowCloseButton( false );
        window.setAnimateMinimize( true );
        window.setShowCloseButton( true );
        window.setModalMaskOpacity( 50 );
        window.setIsModal( true );
        window.setShowModalMask( true );
        window.centerInPage();
        window.addItem( layout );

        window.draw();

        listGrid.getResultSet().addDataChangedHandler( new DataChangedHandler()
        {

            @Override
            public void onDataChanged( DataChangedEvent event )
            {
                double totalAmount = 0;

                // Gets all records of the listGrid
                Record[] records = getAssignments();

                for ( int i = 0; i < records.length; i++ )
                {
                    totalAmount = totalAmount + records[i].getAttributeAsDouble( CAssignedPaymentsRec.total_amount );
                }

                SC.say( "Total Amount: " + totalAmount );
            }
        } );
    }

    private void initListGrid()
    {
        final DataSource dataSource = getDataSource();
        listGrid = new ListGrid()
        {
            @Override
            protected Canvas getCellHoverComponent( Record record, Integer rowNum, Integer colNum )
            {
                Criteria criteria = new Criteria();
                criteria.addCriteria( dataSource.getPrimaryKeyFieldName(),
                                      record.getAttribute( dataSource.getPrimaryKeyFieldName() ) );

                DetailViewer viewer = new DetailViewer();
                viewer.setEmptyCellValue( "---" );
                viewer.setDataSource( dataSource );
                viewer.setWrapValues( false );
                viewer.setWrapLabel( false );
                viewer.setShowShadow( true );
                viewer.setShowEmptyField( false );
                viewer.setShowHiddenFields( true );
                viewer.setShowEmptyField( false );
                viewer.setShowDetailFields( true );
                viewer.fetchData( criteria );

                return viewer;
            }
        };

        listGrid.setMargin( 25 );
        listGrid.setDataSource( dataSource );
        listGrid.setAutoFetchData( true );
        listGrid.setShowFilterEditor( true );
        listGrid.setAllowFilterExpressions( true );
        listGrid.setShowRowNumbers( true );
        listGrid.setFastCellUpdates( true );
        listGrid.setEmptyCellValue( "---" );
        listGrid.setAllowFilterExpressions( true );
        listGrid.setDataFetchMode( FetchMode.BASIC );
        listGrid.setWrapHeaderTitles( true );
        listGrid.setCanResizeFields( true );
        listGrid.setCellPadding( 4 );
        listGrid.setFixedRecordHeights( false );
        listGrid.setGroupByMaxRecords( 1000 );
        listGrid.setBodyOverflow( Overflow.AUTO );
        listGrid.setOverflow( Overflow.AUTO );
        listGrid.setLeaveScrollbarGap( false );
        listGrid.setAutoFitWidthApproach( AutoFitWidthApproach.BOTH );
        listGrid.setAutoFitHeaderHeights( true );
        listGrid.setAutoSizeHeaderSpans( true );
        listGrid.setCanAutoFitFields( false );
        listGrid.setRecordDropAppearance( RecordDropAppearance.BOTH );
        listGrid.setCanHover( true );
        listGrid.setShowHover( true );
        listGrid.setShowHoverComponents( true );
        listGrid.setHoverDelay( 100 );

        listGrid.setCanAddFormulaFields( true );
        listGrid.setCanAddSummaryFields( true );

        // Sets Columns
        setColumns( listGrid );

    }

    private void setColumns( ListGrid listGrid )
    {
        ListGridField idField = new ListGridField( "id" );
        idField.setWidth( "10%" );
        idField.setAlign( Alignment.CENTER );
        idField.setShowGroupSummary( false );
        idField.setHidden( true );
        idField.setCanEdit( false );

        ListGridField descriptionField = new ListGridField( "description" );
        descriptionField.setWidth( "60%" );
        descriptionField.setCanEdit( false );

        ListGridField netField = new ListGridField( "netAmount" );
        netField.setSummaryFunction( SummaryFunctionType.SUM );
        netField.setShowGroupSummary( true );
        netField.setShowGridSummary( true );
        netField.setWidth( "10%" );
        netField.setAlign( Alignment.CENTER );
        netField.setCellFormatter( new CellFormatter()
        {
            public String format( Object value, ListGridRecord record, int rowNum, int colNum )
            {
                if ( value == null )
                    return null;
                try
                {
                    NumberFormat fmt = NumberFormat.getFormat( "#,##0.00" );
                    return fmt.format( Double.valueOf( String.valueOf( value ) ) );
                }
                catch ( Exception e )
                {
                    return value.toString();
                }
            }
        } );

        ListGridField taxField = new ListGridField( "taxAmount" );
        taxField.setWidth( "10%" );
        taxField.setSummaryFunction( SummaryFunctionType.SUM );
        taxField.setShowGroupSummary( true );
        taxField.setShowGridSummary( true );
        taxField.setAlign( Alignment.CENTER );
        taxField.setCellFormatter( new CellFormatter()
        {
            public String format( Object value, ListGridRecord record, int rowNum, int colNum )
            {
                if ( value == null )
                    return null;
                try
                {
                    NumberFormat fmt = NumberFormat.getFormat( "#,##0.00" );
                    return fmt.format( Double.valueOf( String.valueOf( value ) ) );
                }
                catch ( Exception e )
                {
                    return value.toString();
                }
            }
        } );

        ListGridField grossField = new ListGridField( "grossAmoumnt" );
        grossField.setSummaryFunction( SummaryFunctionType.SUM );
        grossField.setShowGroupSummary( true );
        grossField.setShowGridSummary( true );
        grossField.setAlign( Alignment.CENTER );
        grossField.setWidth( "10%" );
        grossField.setCellFormatter( new CellFormatter()
        {
            public String format( Object value, ListGridRecord record, int rowNum, int colNum )
            {
                if ( value == null )
                    return null;
                try
                {
                    NumberFormat fmt = NumberFormat.getFormat( "#,##0.00" );
                    return fmt.format( Double.valueOf( String.valueOf( value ) ) );
                }
                catch ( Exception e )
                {
                    return value.toString();
                }
            }
        } );

        ListGridField currencyField = new ListGridField( "currency" );
        currencyField.setAlign( Alignment.CENTER );
        currencyField.setWidth( "8%" );
        currencyField.setCanEdit( false );

        ListGridField dateField = new ListGridField( "date" );
        dateField.setWidth( "15%" );
        dateField.setAlign( Alignment.LEFT );

        listGrid.setFields( idField, descriptionField, netField, taxField, grossField, dateField );

        // Group ListGrid
        listGrid.setGroupByField( "currency" );
        listGrid.setGroupStartOpen( GroupStartOpen.ALL );
        listGrid.setShowGroupSummary( true );
        listGrid.setShowGridSummary( true );
        
        // add Records
        addRecords( 45 );

    }

    private DataSource getDataSource()
    {
        DataSource ds = new DataSource();
        ds.setID( "payments" );
        ds.setClientOnly( true );

        DataSourceSequenceField idField = new DataSourceSequenceField( "id", "ID" );
        idField.setPrimaryKey( true );
        idField.setHidden( true );

        DataSourceTextField descriptionField = new DataSourceTextField( "description", "Description" );
        descriptionField.setRequired( true );
        DataSourceFloatField netField = new DataSourceFloatField( "netAmount", "Net Amount" );
        netField.setRequired( true );
        DataSourceFloatField taxField = new DataSourceFloatField( "taxAmount", "Tax Amount" );
        taxField.setRequired( true );
        DataSourceFloatField grossField = new DataSourceFloatField( "grossAmoumnt", "Gross Amount" );
        grossField.setRequired( true );

        DataSourceTextField currencyField = new DataSourceTextField( "currency", "Currency" );
        currencyField.setValueMap( getCurrencys() );
        currencyField.setRequired( true );

        DataSourceDateField dateField = new DataSourceDateField( "date", "Date" );

        ds.setFields( idField, descriptionField, netField, taxField, grossField, currencyField, dateField );

        return ds;
    }

    private void initEditorForm()
    {
        editorForm = new DynamicForm();
        editorForm.setDataSource( listGrid.getDataSource() );
        editorForm.setAutoFocus( true );
        editorForm.setWidth100();
        editorForm.setMargin( 25 );
        editorForm.setUseAllDataSourceFields( true );

        editorForm.editNewRecord();
    }

    private ToolStrip getToolBar()
    {
        ToolStrip toolbar = new ToolStrip();
        toolbar.setWidth100();

        ToolStripButton buttonAddToGrid = new ToolStripButton( "Add To Grid" );
        buttonAddToGrid.addClickHandler( new ClickHandler()
        {
            public void onClick( ClickEvent event )
            {
                if ( editorForm.validate() == true )
                {
                    editorForm.submit();
                }
            }
        } );

        ToolStripButton buttonNewRecord = new ToolStripButton( "New Record" );
        buttonNewRecord.addClickHandler( new ClickHandler()
        {
            public void onClick( ClickEvent event )
            {
                editorForm.editNewRecord();
            }
        } );

        toolbar.addButton( buttonNewRecord );
        toolbar.addButton( buttonAddToGrid );

        return toolbar;

    }

    public Record[] getAssignments()
    {
        RecordList recordList = null;
        if ( listGrid.isGrouped() )
        {
            recordList = listGrid.getOriginalRecordList();
        }
        else
        {
            recordList = listGrid.getResultSet();
        }

        Record[] result = (Record[]) recordList.toArray();

        return result;
    }

    public LinkedHashMap<String, String> getCurrencys()
    {
        LinkedHashMap<String, String> items = new LinkedHashMap<String, String>();

        items.put( "1", "EUR" );
        items.put( "2", "GBP" );
        items.put( "3", "CHF" );
        items.put( "4", "SEK" );
        items.put( "5", "DKK" );
        items.put( "6", "PLN" );
        items.put( "7", "BGN" );
        items.put( "8", "CZK" );
        items.put( "9", "HUF" );
        items.put( "10", "HRK" );
        items.put( "11", "RUB" );
        items.put( "12", "RON" );

        return items;
    }

    private void addRecords( int counter )
    {
        Date date = getFirstDayOfMonth( new Date() );

        for ( int i = 0; i < counter; i++ )
        {
            ListGridRecord record = new ListGridRecord();
            record.setAttribute( "id", 1 + i );
            record.setAttribute( "description", "Test " + 1 + i );
            record.setAttribute( "netAmount", new Double( 1 + i ) );
            record.setAttribute( "taxAmount", new Double( 0 ) );
            record.setAttribute( "grossAmoumnt", new Double( 1 + i ) );
            record.setAttribute( "currency", "1" );

            CalendarUtil.addDaysToDate( date, 1 );
            record.setAttribute( "date", date );
            
            listGrid.addData( record );
        }
    }

    // ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
    /**
     * Returns the first day of the current month
     */
    // ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
    public static Date getFirstDayOfMonth( Date date )
    {
        CalendarUtil.resetTime( date );
        CalendarUtil.setToFirstDayOfMonth( date );

        return date;
    }

}
    Tags: None
    #2
    You can also try the following process:

    1. Click on the date columen of the list grid and open the ListGrid header menu
    2. Click "Group by date" and choose the option "by date"
    3. Click on the column header for sorting by date (try Asc and Desc)
    5. Ungroup the column
    6. Click on the column header for sorting by date (try Asc and Desc)
    7. You can see now that the column does not sort anymore

    Comment

      #3
      Is your build from July 4 or April 7?

      We aren't seeing your first issue - you can see things working as expected in the online showcase at http://www.smartclient.com/smartgwt/...d_ml_summaries - and that's against the July 5 build.

      However, we *do* see your second issue and it's queued to be fixed - we'll update here whan that happens.

      Comment

        #4
        Thanks for getting back!!! Yeah... you are right... in your showcase I can not reproduce the first issue. But did you tried my showcase code with the build from July 4/5? I guess there's nothing wrong in my code. Right?

        It's a complete example... you only need to add this class to an existing project and call on module load. "GTestGrid tst = new GTestGrid();".

        My build was July 4... I also tried today July 5.

        Comment

          #5
          Okay... I also tried my sourcecode with a build from 30.03.... this is working for me... seems to affect the newer builds.

          Comment

            #6
            Hi,

            can you reproduce this one? As mentioned before the build from 30.03 worked fine... seems to affect newer builds.

            Thanks
            Andy


            Comment

              #7
              Yes, once we comment the use of an enum you didn't provide, we do indeed see the issue you describe with your test-case.

              It's queued to be look at but is behind other issues reported by customers with support contracts. We'll update here when it's been addressed.

              Comment

                #8
                okay thanks for your feedback. I can understand this.

                Comment

                  #9
                  Note that this has now been fixed - you can test the changes in builds dated August 6 and later.

                  Comment

                  Previous template Next
                  Working...
                  X