ListGrid date editor causes format error

[marchew]

Setting custom input format for date editor causes parse error.
Version: 6.0p/LGPL/2016-10-23

  public static final int RECORD_COUNT = 5;
  String customFormat = "yyyy.MM.dd";

  public void onModuleLoad()
  {
    ListGrid grid = new ListGrid();
    grid.setDataSource(new TestDS());
    grid.setAutoFetchData(true);
    grid.setWidth(600);
    grid.setHeight(400);
    grid.setEditByCell(true);

    grid.setCanEdit(true);

    RootPanel.get("listGridContainer").add(grid);
  }

  private class TestDS extends DataSource
  {

    public TestDS()
    {
      setID("localTestDS");

      DataSourceIntegerField dsField1 = new DataSourceIntegerField("F1", "Id");
      dsField1.setPrimaryKey(true);

      DataSourceDateField dsField2 = new DataSourceDateField("F2", "Field 2");
      dsField2.setFormat(customFormat);
      DateItem editorProperties = new DateItem();
      editorProperties.setFormat(customFormat);
      editorProperties.setInputFormat(customFormat);
      dsField2.setEditorProperties(editorProperties);

      setFields(dsField1, dsField2);

      setTestData(getData());
      setClientOnly(true);
    }

    private ListGridRecord[] getData()
    {
      ListGridRecord[] listGridRecords = new ListGridRecord[RECORD_COUNT];
      for (int i = 0; i < RECORD_COUNT; i++)
      {
        listGridRecords[i] = createRecord(i);
      }
      return listGridRecords;
    }

    private ListGridRecord createRecord(int i)
    {
      ListGridRecord listGridRecord = new ListGridRecord();
      listGridRecord.setAttribute("F1", i);
      listGridRecord.setAttribute("F2", new Date());
      return listGridRecord;
    }
  }

[Isomorphic]

See docs for setInputFormat(), you are not passing the expected parameter, which is a 3 character string to specify the order of inputs.

[marchew]

i changed this line to:

 
 editorProperties.setInputFormat("YMD");
 editorProperties.setMaskDateSeparator(".");

still doesn't work :(

[Isomorphic]

If you set the input format to YMD and type in 10/20/2016, then that should be a parse error, you aren't following the format.

[marchew]

It wasn't typed. It was picked from editor's date picker. That's the clue.

[Isomorphic]

We don't see this behavior - your original sample code works for us, once we correct it to call setInputFormat("YMD') on the editorProperties - that call and setFormat(customFormat) are the only required settings - your call to setDateMaskSeparator() is ineffective, since you aren't showing the mask anyway.

Try clearing your caches, etc - if you still see an issue, show us your updated code and describe steps to reproduce, since we aren't reproducing it otherwise.

Note that the typical way to customize date formatting is to do so system-wide, rather than by field, via DateUtil APIs.

[marchew]

I just tried with 6.1-d20161027-SNAPSHOT and it works fine (thanks a lot!) but i was trying to achieve this in production build (6.0-p20161023).
I think it doesn't matter anymore but for the record:

My goal was to operate on one specific column (not system-wide) with date format: "yyyy.MM.dd"

  public static final int RECORD_COUNT = 5;
  String customFormat = "yyyy.MM.dd";

  public void onModuleLoad()
  {
    ListGrid grid = new ListGrid();
    grid.setDataSource(new TestDS());
    grid.setAutoFetchData(true);
    grid.setWidth(200);
    grid.setHeight(200);
    grid.setEditByCell(true);
    grid.setCanEdit(true);

    RootPanel.get("listGridContainer").add(grid);
  }

  private class TestDS extends DataSource
  {

    public TestDS()
    {
      setID("localTestDS");

      DataSourceIntegerField dsField1 = new DataSourceIntegerField("F1", "Id");
      dsField1.setPrimaryKey(true);

      DataSourceDateField dsField2 = new DataSourceDateField("F2", "Field 2");
      dsField2.setFormat(customFormat);
      DateItem editorProperties = new DateItem();
      editorProperties.setFormat(customFormat);
      editorProperties.setInputFormat("YMD");
//      editorProperties.setMaskDateSeparator(".");
      dsField2.setEditorProperties(editorProperties);

      setFields(dsField1, dsField2);

      setTestData(getData());
      setClientOnly(true);
    }

    private ListGridRecord[] getData()
    {
      ListGridRecord[] listGridRecords = new ListGridRecord[RECORD_COUNT];
      for (int i = 0; i < RECORD_COUNT; i++)
      {
        listGridRecords[i] = createRecord(i);
      }
      return listGridRecords;
    }

    private ListGridRecord createRecord(int i)
    {
      ListGridRecord listGridRecord = new ListGridRecord();
      listGridRecord.setAttribute("F1", i);
      listGridRecord.setAttribute("F2", new Date());
      return listGridRecord;
    }
  }

At the beginning ListGrid looks like this:

double click starts editor:

As you can see, format inside editor isn't quite right.
After opening date picker:

I chose 26th...

Validation error occurs :(

[marchew]

So i'm just waiting for production build. Thanks for help!

[Isomorphic]

It's not clear if you're expecting further input from us here, but we're unable to reproduce what you show in your images, or find any other issues in this area.

Just setting your custom format on the DataSourceField enforces it throughout (for display, while editing, and after choosing a date from the picker) - however, edited values in your custom format will fail validation unless you also set inputFormat on the editorProperties.

Please retest with the latest build of your version from smartclient.com/builds.