Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

  • 6.1d ListGrid Wrapped Titles jump on hovering

    Hi Isomorphic,

    please see this sample and change to code to:
    Code:
    isc.ListGrid.create({
        ID: "countryList",
        height:224, width:380, alternateRecordStyles:true,
        autoFitWidthApproach:"both",
        wrapHeaderTitles:true,
        headerHeight:40,
        headerAutoFitEvent:"doubleClick",
        leaveHeaderMenuButtonSpace:true,
        sortField: "countryName",
        data: countryData,
        fields:[
            {name:"countryCode", title:"Flag Thumbnail", cellAlign:"center",
             type:"image", imageURLPrefix:"flags/16/", imageURLSuffix:".png"},
            {name:"countryName", title:"Country of Origin", width:80},
            {name:"capital", title:"Capital"},
            {name:"continent", title:"Continent"}
        ]
    })
    As you can see the column title moves on hovering. Tested online with SNAPSHOT_v11.1d_2017-03-24 and GC57.

    Asides from this I really like the feature. It's going to make my application better to understand.

    Best regards
    Blama

  • #2
    We've made a fix to address this in SGWT 6.1d/SC 11.1d which should be in the current nightly builds.

    Due to the space now permanently occupied by the padding, you will probably want to modify your code to avoid any horizontal or vertical clipping - clipping may vary by browser. Simply bumping the width of "countryName" field to 90 should avoid any clipping. Alternatively, you could keep the width as 80 and replace "headerHeight:40" with "autoFitHeaderHeights:true", which would eliminate the vertical clipping of "Origin" but the end of "Country" may still be clipped.

    Comment


    • #3
      Hi Isomorphic,

      thanks for the change. I don't remember the old way it was before, but in general I think the new behavior looks good. There are some issues still, though. Now testing in the online sample from above with GC59 and SNAPSHOT_v11.1d_2017-06-18.

      1) See the result with autoFitHeaderHeights:true
      Click image for larger version

Name:	height-changes.gif
Views:	1
Size:	205.4 KB
ID:	245163

      2) With the original code from #1 there is a small (minor) position bump in the country-title when "Origin" appears/disappears.
      (Note: Also happens for "Country of oriin", so it is not related to the capital "O" or the lower part of the "g")
      Click image for larger version

Name:	small-position-bump.gif
Views:	1
Size:	130.7 KB
ID:	245164

      The best solution would be to have ellipsis as well in the testcase from #1, as manually tuned field width are not possible with i18n titles.
      Second best solution IMHO is autoFitHeaderHeights:true with the first bug from this post fixed.


      Best regards
      Blama

      Comment


      • #4
        We've committed a fix to address the first issue you mentioned (top animation) in SGWT 6.1/SC 11.1. It will be in the nightly builds dated 2017-06-27 and beyond.

        Comment


        • #5
          Hi Isomorphic,

          I can see that the testcase from #1 is working as expected in 11.1p (now on v11.1p_2017-07-05), thanks a lot.

          Could you note the other things as minor bugs / enhancements?
          • issue 2) from post#3
          • Ellipsis if text is missing with autoFitHeaderHeights:false or at least a hover for those column headers
          Best regards
          Blama

          Comment


          • #6
            We're not sure what you mean with the remaining issues. There is no space for the word "Origin" given the space need for the sort indicator. If you end the resize with "Origin" not shown, the header height adjusts to show it, so nothing is clipped; no need for an ellipsis.

            We don't think it makes sense to show an ellipsis *during the resize* (or a hover either). It is true that with showClippedHeaderTitlesOnHover:true, currently we don't show a hover for vertically clipped headers (when autoFitHeaderHeights is true), so we'll look at enhancing that.

            Comment


            • #7
              Hi Isomorphic,

              perhaps I'm not clear. The issue where the text changes its (vertical) position when you resize the column is still present. See the 2nd video in #3. You can reproduce with the code from #1. But this is very minor.

              Another test case would be the sample's original code with canSort:true, then resizing the column. This time the text is moving down (as compared to the video in #3, where it is moving up):
              Click image for larger version

Name:	small-position-bump-down.gif
Views:	1
Size:	102.1 KB
ID:	245634




              About the ellesis: I'm taking about an ellepsis end of resize, not during resize. With the normal sample code you can create this picture by just making the column smaller:
              Click image for larger version

Name:	no-ellepsis.PNG
Views:	1
Size:	7.6 KB
ID:	245635

              I was suggesting "..." after the word "of". But this is also minor.

              IMHO a hover would be enough in this case (wrapHeaderTitles:true, autoFitHeaderHeights: false). I assume it would be more easy than an ellepsis. But this is minor as well.


              Best regards
              Blama

              Comment


              • #8
                The text moves down in the first instance because the first word is no longer small enough to fit given the space allocated to the sort indicator. If it stayed where it was, a tall last letter (eg "l") would overlap the sort indicator, or at least look uncomfortably close. The space left for the sort indicator is configurable if you are comfortable with this overlap.

                Thanks for clarifying that you are looking for an ellipsis or hover in the case that autoFitHeaderHeights is false - this is the area that we just mentioned we'd be looking at enhancing.

                Comment


                • #9
                  Originally posted by Isomorphic View Post
                  or hover in the case that autoFitHeaderHeights is false - this is the area that we just mentioned we'd be looking at enhancing.
                  Even though autoFitHeaderHeights is explicity set to true I would like the hover, like in this example over Country column title:
                  Click image for larger version

Name:	wrappedTitles.png
Views:	1
Size:	16.8 KB
ID:	245706

                  Thanks,
                  MichalG

                  Comment


                  • #10
                    Hi Isomorphic,

                    using the sample from #1 (now: v11.1p_2017-08-17) with the code from #1, you can see that "Country of origin" always displays a hover, even if wide enough.
                    This is not true for the other columns.

                    Best regards
                    Blama

                    Comment


                    • #11
                      Originally posted by Blama View Post
                      Hi Isomorphic,

                      using the sample from #1 (now: v11.1p_2017-08-17) with the code from #1, you can see that "Country of origin" always displays a hover, even if wide enough.
                      This is not true for the other columns.

                      Best regards
                      Blama
                      What browser?

                      Comment

                      Working...
                      X