Highlight and Edit with Masking

[OPY]

Hi!

Is this a bug with masking? Any fix or workaround?

1. http://www.smartclient.com/smartgwt/.../#form_masking
2. Enter text
3. Highlight some text
4. Press right arrow key to "unhighlight"
5. Enter text (or if press delete key, previously highlighted text will be deleted instead of only the character to the left of the cursor)



No problem if click with mouse.

The issue we face is when date is highlighted, hitting right arrow and then delete key is expected to delete only the last digit, but the whole date entry is deleted instead.

Thank you very much for your help.

[Isomorphic]

Please see the FAQ - you need to always post what product and version you are using, and please do not post issues unless you have tested against the latest patched version (see SmartClient.com/builds).

[Isomorphic]

Actually, we see that you posted a link to a sample running under 6.1 online - we see the issue and we'll take a look.

It's always best, though, to note your product, browser and OS versions at the top whenever you post.

[Isomorphic]

This has been fixed for builds dated July 14 and later.

[OPY]

Tested on Showcase 6.1p Built: 2017-07-20, found some issues with keypress and masking. Mainly relating to "highlighted" (selected) text.

1. Can only "highlight" (select) one character with Shift+Arrow keys.

2. Test on http://www.smartclient.com/smartgwt/...eypress_filter

Highlight CDEF and enter 1, result should be AB1GHIJK


Highlight all and press "Delete", all should be cleared and not just delete J


Highlight CDE and enter X, result should be ABXFGHI


Highlight 12345 and enter 6, result should be 6

Testing on http://www.smartclient.com/smartgwt/.../#form_masking also have similar issues on editing highlighted text, but the result is not consistent and not always repeatable with the same steps.

Thank you very much.

[Isomorphic]

Ah, it looks like we applied the fix of clearing out the dataElement's selection attributes a little too zealously - all of these have been fixed for tomorrow's builds.

[OPY]

Much better now, but in the 2017-07-21 Showcase:

Keypress filter (http://www.smartclient.com/smartgwt/...eypress_filter) "Mapped to uppercase", replacing highlighted characters will delete one more character to the right if enter alpha, but correct if enter numeric.
Example: ABCDEFGHI, highlight DEF and enter X will become ABCXHI instead of ABCXGHI. If enter 2 will be correct, ABC2GHI.

For Masking (http://www.smartclient.com/smartgwt/.../#form_masking) , entering in First name: Longfirstname, then use keyboard to navigate and highlight "first" and type "x" will result in Longxfname instead of Longxname

Thank you very much.

[Isomorphic]

We've made another change that should fix these issues for you, whether using mouse or keyboard, or selecting from left-to-right, or right-to-left.

Please retest with a build dated July 26 or later, and let us know if you still have issues.

[OPY]

Thank you very much for the fix.

Tested on Showcase Built: 2017-07-27, and reported cases tested working as expected.

Found a minor issue with Text Masking example:
http://www.smartclient.com/smartgwt/.../#form_masking
- Enter text in First name (Abcdefghij)
- Highlight some part or all
- Enter a number (2)
- Move cursor somewhere (after "i", no more highlight)
- Press delete key or enter text will also delete previously highlighted text.
Similar result if enter numbers in Phone Number or Date and then highlight and enter alpha then move cursor and delete or enter number.

Thank you very much.

[Isomorphic]

Thanks for the concise test cases - the problem here was that part of the mask array-shifting logic was still running in these cases, despite the pressed characterValue being invalid for the mask.

It's been fixed for builds dated July 29 and later.

[OPY]

Thank you very much for the fix.

Tested on Showcase 6.1p Built: 2017-07-29, and Masking worked as expected.

For Keypress filter (http://www.smartclient.com/smartgwt/...eypress_filter) "Mapped to uppercase", replacing highlighted characters will delete one more character to the right if enter alpha, but correct if enter numeric.
Example: ABCDEFGHI, highlight DEF and enter X will become ABCXHI instead of ABCXGHI. If enter 2 will be correct, ABC2GHI.

[Isomorphic]

This similar bug in the characterCasing subsystem has now been fixed too - you can retest with a build dated July 31.

Note that these were not recent regressions, but fairly long-standing logic bugs - we've fixed them all back to 10.0/5.0 and added some autotests to ensure behaviors don't regress in the future.

[OPY]

Excellent! Tested on Showcase 6.1p Built: 2017-08-01, seems can't find anything to make you all work on this further.

Thank you very much!