Announcement

**Isomorphic** · 7 Nov 2012, 10:48

We are not aware of a bug with time type fields generally failing on a fetch against a sql type dataSource, and the stack trace unfortunately doesn't give us enough to go on. Definitely this should work - you should not need the hacks you describe to get Times working in your app.

It sounds like you're saying that time fields *in general* aren't working for you with your datasource. If so, could you try the following:
- put together a trivally simple .ds.xml file that contains just a time type field (and possibly another field)
- put together an entry point class that simply loads this dataSource and does whatever your app is doing that leads to the problem (E.G. binds a ListGrid to it and issues a fetch request)
- you'll need to build the table and populate with test data of course - probably easiest to write a simple test data file (similar to the ones visible under the "test_data" directory of the built-in-ds sample for example), then call SCEE.openDataSourceConsole() from your application, and use the datasource console tool to create the table and import your test data.

If you still get a failure, show us your test case so we can run it on our end and experiment with your particular database, etc.
If not, see if you can determine what's special about your app that is leading to the problem and get us a test case that demonstrates the problem from that.

Thanks
Isomorphic Software

**amcculley** · 7 Nov 2012, 13:58

Test Case

Here is the standalone test case. All of the "date" and "time" fields are mapped to fields in the Oracle Database who are type "Timestamp". We are not doing any sort of timezone stuff, validation, functions, etc with this table. I've also removed our custom sqldatasource just in case and are using the built-in sqldatasource.

With no data, it loads fine with no errors. I'm able to add the record but on the auto-fetch that occurs, and on every fetch after that, I get the errors that I described in my original post.

ds.xml

Code:

<DataSource 
	tableName="CATEGORYS"
	ID="timeTestCase"
	serverType="sql"
>
	<fields>
		<field primaryKey="true" name="CATEGORY_PK" type="sequence" hidden="true" sequenceName="CATEGORY_SEQ"></field>
		<field name="CATEGORY_NAME" type="text" length="128" required="true" title="Name">
			<validators>
				<validator type="isUnique"></validator>
			</validators>
		</field>
		<field name="START_DATE" type="date" useTextField="true" title="Start Date" required="true"></field>
		<field name="END_DATE" type="date" useTextField="true" title="End Date" required="true"></field>
		<field name="START_TIME" type="time" title="Start Time" required="true"></field>
		<field name="END_TIME" type="time" title="End Time" required="true"></field>
	</fields>	
</DataSource>

EntryPoint

Code:

public void onModuleLoad() {
	VLayout testLayout = new VLayout();
	testLayout.setSize("640", "480");
	
	DataSource ds = DataSource.get("timeTestCase");
	
	ListGrid grid = new ListGrid();
	grid.setSize("100%", "100%");
	grid.setShowFilterEditor(true);
	grid.setDataSource(ds);
	grid.setAutoFetchData(true);
	
	final DynamicForm form = new DynamicForm();
	form.setDataSource(ds);
	
	testLayout.addMember(grid);
	testLayout.addMember(form);
	
	IButton addBtn = new IButton("Add Record");
	addBtn.addClickHandler(new ClickHandler() {
		@Override
		public void onClick(ClickEvent event) {
			form.saveData();
			form.clearValues();
		}		
	});
	testLayout.addMember(addBtn);
	
	testLayout.show();
}

**Isomorphic** · 9 Nov 2012, 09:34

Hi
We don't have anything conclusive yet, but wanted to follow up to let you know we have a developer looking at this.
If there is a problem here it appears to be Oracle specific and may be due to the database column type (TIMESTAMP vs DATE). However we need to do some more investigation before we know what's going on for sure.

We'll follow up when we have more information

Regards
Isomorphic Software

**amcculley** · 9 Nov 2012, 12:33

Fantastic. Thank you.

I think there are a few odd things going on. For instance, if we "Group By" on a column with type 'datetime', all items get put into their own group despite them having the same date and time. My guess is that the "nanoseconds" being cut off are causing SmartGwt to think they are different.

And finally, I was able to fix the exception I listed above with the following code in an extended DataSource:

Code:

public DSResponse executeFetch(DSRequest req) throws Exception {
		DSResponse response = super.executeFetch(req);
		long totalRows = response.getTotalRows();
		
		DataSource ds = response.getDataSource();
		Vector<String> timeFields = new Vector<String>();
		for (Object field : ds.getFields()) {
			DSField dsField = null;
			
			try {
				dsField = (DSField)field;
			} catch (Exception e) {
				continue;
			}
			
			
			if (dsField != null) {
				if (dsField.getType().equals(DsFieldTypeEnum.TIME)) {
					timeFields.add(dsField.getName());
				}
			}
		}
		
		if (response.getStatus() >= DSResponse.STATUS_SUCCESS && totalRows > 0) {
			for (Object obj : response.getRecords()) {
				HashMap record = null;
				
				try {
					record = (HashMap) obj;
				} catch (Exception e) {
					continue;
				}
				
				if (record != null) {
					for (String timeFieldName : timeFields) {
						oracle.sql.TIMESTAMP timeStamp = null;
						
						try {
							timeStamp = (TIMESTAMP) record.get(timeFieldName);
						} catch (Exception e) {
							continue;
						}
						
						if (timeStamp != null) {
							java.sql.Time time = timeStamp.timeValue();
							record.put(timeFieldName, time);
						}
					}
				}
			}
		}
		return response;
	}

However, fixing that error does not fixing the ListGrid being able to sort or groupBy on that column - then a different error gets generated.

**amcculley** · 20 Nov 2012, 17:28

Its been a while - just wanted to see if anything new has come up for this? We have a defect logged internally with some of our clients about this and they'd like a resolution soon.

**Isomorphic** · 21 Nov 2012, 14:41

Sorry - normal service has been affected recently as we were focusing on releasing 3.1. We'll get to this in the next day or two - thanks for your patience.

**Isomorphic** · 22 Nov 2012, 11:12

We corrected a couple of things:

1. there were issues where the underlying Oracle column was TIMESTAMP (our tests used a normal DATE column)

2. there was cases where a form would submit the iContains operator for "time" fields, this has been corrected

We're still looking at possibly providing a different set of grouping modes for "datetime" / "time".

**amcculley** · 26 Nov 2012, 04:59

Sounds great. Is this part of a 3.0 nightly?

**Isomorphic** · 26 Nov 2012, 10:47

Yes, the latest 3.0 nightly has the fix.

**amcculley** · 27 Nov 2012, 11:26

Power 3.0

Update:
I can confirm that adding and editing records with the field type of 'time' now work correctly.

However, in the ListGrid FilterEditor, we are still seeing the issue where every filter we put in gets replaced with a '0:00'. This is still happening in our standalone test case posted earlier.

The "GroupBy" options for Time and Date are really good (although an option to show 1pm instead of 13 for the group title would be nice).

**Isomorphic** · 28 Nov 2012, 15:10

We're not seeing the issue with the Time field in the filter editor being reset to "0:00" when you enter some specific time on our end.

Can you confirm exactly which build you're seeing this with (in fact as a sanity check, it's probably worth picking up the very latest nightly build for your branch and working with that).

If so, can you confirm exact steps for how you're reproducing the problem with the sample from earlier in the thread. We're interested in anything that can help shed light on how to reproduce this and what the culprit could be.
For example - exact steps to reproduce, including what exact string you enter / whether other fields are blank, etc? At what point does the entered value get reset to zero - when you tab out of the field? If you hit enter or click the filter button? Before or after the server responds?
Other than the field resetting does the fetch transaction appear to go through with the correct criteria and what does the returned data look like?

Thanks for your help

Isomorphic Software

**amcculley** · 28 Nov 2012, 15:29

Just leaving the office. I'll check into this tomorrow. Thanks for the update.

**amcculley** · 3 Dec 2012, 12:36

Standalone test case - still seeing the issue.
SmartGwtPower 3.0
latest nightly
Tested on FF 10 ESR and IE8

EntryPoint Code

Code:

	private void doStandaloneTestCase() {
		VLayout layout = new VLayout();
		layout.setSize("100%", "100%");
		
		DataSource ds = DataSource.get("testTime");
		
		final ListGrid grid = new ListGrid();
		grid.setDataSource(ds);
		grid.setAutoFetchData(true);
		grid.setShowFilterEditor(true);
		grid.setFilterOnKeypress(false);
		grid.setAllowFilterExpressions(true);
		
		final DynamicForm form = new DynamicForm();
		form.setDataSource(ds);
		
		IButton clearButton = new IButton("Clear");
		clearButton.addClickHandler(new ClickHandler() {
			
			@Override
			public void onClick(ClickEvent event) {
				form.clearValues();
			}
		});
		
		IButton saveButton = new IButton("Save");
		saveButton.addClickHandler(new ClickHandler() {
			
			@Override
			public void onClick(ClickEvent event) {
				form.saveData(new DSCallback() {

					@Override
					public void execute(DSResponse response, Object rawData, DSRequest request) {
						if (response.getStatus() >= DSResponse.STATUS_SUCCESS) {
							SC.say("Save Successful");
							form.clearValues();
						} else {
							SC.warn("Save Failed");
						}
					}
				});
			}
		});
		
		layout.addMember(grid);
		layout.addMember(form);
		layout.addMember(clearButton);
		layout.addMember(saveButton);
		layout.show();
	}

datasource.xml file

Code:

<DataSource 
	tableName="CATEGORYS"
	ID="testTime"
	serverType="sql"
	title="Time Test Case"
>
	<fields>
		<field primaryKey="true" name="CATEGORY_PK" type="sequence" hidden="true" sequenceName="CATEGORY_SEQ"></field>
		
		<field name="CATEGORY_NAME" type="text" length="128" required="true" title="Record Name">
			<validators>
				<validator type="isUnique"></validator>
			</validators>
		</field>
		
		<field name="START_DATE" type="date" useTextField="true" title="Start Date" required="true"></field>
		<field name="END_DATE" type="date" useTextField="true" title="End Date" required="true"></field>
		
		<field name="START_TIME" type="time" title="Start Time" required="true"></field>
		<field name="END_TIME" type="time" title="End Time" required="true"></field>
	</fields>	
</DataSource>

Behavior:
Entering a filter and going to a new filter cell (either by clicking in it or tabbing) will cause the field to be formatted correctly.
i.e. entering "1pm" and then tabbing to a new field will cause the entry to be rewritten as "13:00".

However, when performing the filtering action (be either hitting 'enter' inside of a filter cell or by clicking on the filter icon), the entry immediately transforms to "0:00" and, of course, the filtered data is incorrect.

Please advise.

**amcculley** · 3 Dec 2012, 12:37

As some additional info - I've tried it with and without the filter editor expression capability enabled and it doesn't make a difference either way.

Announcement

Bug? FieldType.Time causing exceptions and listgrid filter doesn't work

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment