5.1p: RadioGroupItem in SectionStackSection-controls looses it's value after SectionStackSection-title update

Isomorphic replied

30 Oct 2017, 10:59
Your behavior in #4 is because the getter retrieves the property from the SectionStackStack instance, which is a read-only object, but the setter routes to SectionStack.setSectionTitle(), which modifies the SectionHeader.

We may change how the getter on SectionStackSection operates, but for now, if you want to get the current title, you can get the SectionHeader from the SectionStackSection, and then call getTitle() on it. (That will still work going forward, but we may decide to have the getter on SectionStackSection do that so that section's current property is always returned.)

We'll update this thread as new information is available.
Leave a comment:
Blama replied

23 Oct 2017, 23:25
Hi Isomorphic,

thanks for the explanation. In my application, I always have 2 VLayouts (for design reasons) in setItems() and the real content is in the 1st VLayout. Therefore this is still working for me without a warning.
Then the issue from #1 is fixed for me and only the issue from #4 is open.

Best regards
Blama
Leave a comment:
Isomorphic replied

23 Oct 2017, 14:36
Originally posted by Blama View Post

Hi Isomorphic,

using v11.1p_2017-10-20 I get this error for the testcase in FF26 Dev Mode:

Code:

Error :Cannot change the items property for SectionStackSection isc_BuiltInDS_MySectionStackSection_0 now that it's been added to SectionStack isc_SectionStack_0 and its SectionHeader built

The error is for this line:

Code:

private final class AnimalAgeChangedHandler implements ChangedHandler { @Override public void onChanged(ChangedEvent event) { boolean onPicklist = Boolean.valueOf(ageRGI.getValue().toString()); if (animalsLG != null) { [B] sss.setItems();[/B] animalsLG.destroy(); } animalsLG = new AnimalsLG(onPicklist, sss); sss.setItems(animalsLG); sss.setExpanded(true); } }

Best regards
Blama

Yes, this is by design. SectionStackSection.items is an [i] field, meaning it can only be set during initialization, and not afterwards, so your approach is incorrect usage. Instead, you need to recreate the SSS if you need to change items, and use the SectionStack APIs to replace the existing SSS.

This warning, like a few others we issue during SGWT object construction, doesn't abort the control flow, to preserve backcompat - since though not guaranteed or recommended, if it's working in your case we didn't want to break it.
Leave a comment:

Blama replied

23 Oct 2017, 06:41

Hi Isomorphic,

also, please see this code (v10.1p_2017-10-05), which shows an related issue in the same area (SectionStackSection editing in DataArrivedHandler).
The code "parentSectionStackSection.setTitle(parentSectionStackSection.getTitle() + " (" + getResultSet().getLength() + ")");" does show what is meant, but should not work.
getTitle() should return the current title, so that after filtering, the title should be e.g. "Animals (10) (5)", but it is "Animals (5)".
It seems that even though the title is correctly set, the variable holding it not changed.

Code:

package com.smartgwt.sample.client;

import com.google.gwt.core.client.EntryPoint;
import com.smartgwt.client.Version;
import com.smartgwt.client.core.KeyIdentifier;
import com.smartgwt.client.data.DataSource;
import com.smartgwt.client.util.Page;
import com.smartgwt.client.util.PageKeyHandler;
import com.smartgwt.client.util.SC;
import com.smartgwt.client.widgets.IButton;
import com.smartgwt.client.widgets.Window;
import com.smartgwt.client.widgets.events.ClickEvent;
import com.smartgwt.client.widgets.events.ClickHandler;
import com.smartgwt.client.widgets.grid.ListGrid;
import com.smartgwt.client.widgets.grid.ListGridField;
import com.smartgwt.client.widgets.grid.events.DataArrivedEvent;
import com.smartgwt.client.widgets.grid.events.DataArrivedHandler;
import com.smartgwt.client.widgets.layout.SectionStack;
import com.smartgwt.client.widgets.layout.SectionStackSection;
import com.smartgwt.client.widgets.layout.VLayout;

public class BuiltInDS extends VLayout implements EntryPoint {
    private IButton recreateBtn;
    private ListGrid animalsLG;
    private SectionStackSection sss;

    public void onModuleLoad() {
        KeyIdentifier debugKey = new KeyIdentifier();
        debugKey.setCtrlKey(true);
        debugKey.setKeyName("D");

        Page.registerKey(debugKey, new PageKeyHandler() {
            public void execute(String keyName) {
                SC.showConsole();
            }
        });

        setWidth100();
        setHeight100();

        recreateBtn = new IButton("Recreate");
        recreateBtn.addClickHandler(new ClickHandler() {
            @Override
            public void onClick(ClickEvent event) {
                new MyWindow().show();
            }
        });
        addMember(recreateBtn);
        new MyWindow().show();
        draw();
    }

    private class MyWindow extends Window {
        public MyWindow() {
            setWidth("95%");
            setHeight("95%");
            setMembersMargin(0);
            setModalMaskOpacity(70);
            setTitle(" (" + Version.getVersion() + "/" + Version.getSCVersionNumber() + ")");
            setTitle("SectionStackSection.getTitle() does not return current title, but initial one" + getTitle());
            setShowMinimizeButton(false);
            setIsModal(true);
            setShowModalMask(true);
            centerInPage();

            SectionStack ss = new SectionStack();
            sss = new MySectionStackSection();
            sss.setTitle("Animals");
            animalsLG = new AnimalsLG(sss);
            sss.setItems(animalsLG);
            ss.setSections(sss);
            addItem(ss);
        }
    }

    private class AnimalsLG extends ListGrid {
        public AnimalsLG(final SectionStackSection parentSectionStackSection) {
            super(DataSource.get("animals"));
            setWidth(1000);
            setHeight(500);
            setAutoFetchData(false);
            setAutoFitExpandField("commonName");
            ListGridField lifeSpanLGF = new ListGridField("lifeSpan");
            ListGridField commonNameLGF = new ListGridField("commonName");
            ListGridField statusLGF = new MyLGF("status");
            setFields(commonNameLGF, lifeSpanLGF, statusLGF);
            setShowFilterEditor(true);
            setSortField("commonName");

            addDataArrivedHandler(new DataArrivedHandler() {
                @Override
                public void onDataArrived(DataArrivedEvent event) {
                    SC.logInfo("Animals (" + getResultSet().getLength() + ")");
                    parentSectionStackSection.setTitle([B]parentSectionStackSection.getTitle()[/B] + " (" + getResultSet().getLength() + ")");
                }
            });
            fetchData();
        }
    }
}

Best regards
Blama