Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

    6.1p Tahoe: Display Problem with SelectItem and ComboBoxItem when using readOnlyDisplay: "static" and canEdit: false

    Hi Isomorphic,

    please see this modified 6.1p sample (v11.1p_2017-11-21):
    Code:
    isc.DynamicForm.create({
        ID: "form2", readOnlyDisplay: "static", canEdit: false,
        width: 620,
        colWidths: [190, "*"],
        isGroup: true,
        groupTitle: "Select / Combo Controls",
        fields : [
        {
            name: "comboBoxItem", title: "Item Name", editorType: "ComboBoxItem", optionDataSource: "supplyItem", wrapTitle: false,
            displayField:"itemName", valueField:"SKU", hint: "foobar"
        },
        {
            name: "selectItem", title: "Select", editorType: "SelectItem", optionDataSource: "supplyItem", wrapTitle: false,
            displayField:"itemName", valueField:"SKU", hint: "foobar"
        }],
        values: {comboBoxItem: "Spray Adhesive Multipurpose Can No.76 3M", selectItem: "Spray Adhesive Multipurpose Can No.76 3M"}
    });
    On load, the generated html looks like this:
    Click image for larger version

Name:	canEditFalseStaticSelectItem.PNG
Views:	131
Size:	19.9 KB
ID:	250490
    After hovering the code changes to the expected staticTextItem:
    Click image for larger version

Name:	SelectItem Hovering.gif
Views:	84
Size:	28.1 KB
ID:	250491

    This one and the other readOnlyDisplay: "static", canEdit: false issue I reported are not urgent for me now, as the code is not going to production in the next weeks, but it would be great if it got fixed eventually.

    Thank you & Best regards
    Blama

    #2
    Hi Isomorphic,

    could you reproduce this one? This is still happening the same way with v11.1p_2017-12-29.

    Best regards
    Blama

    Comment


      #3
      Apologies fro the delay, this one slipped through the net - we do see this effect, and we'll take a look at addressing it at the top of the new year, along with your other skin-related reports.

      In the meantime, you should be able to fix it by just calling form.setReadOnlyDisplay() or form.setCanEdit() after create time.

      Comment


        #4
        Hi Isomorphic,

        did you have a chance to tackle this one, yet?

        Best regards
        Blama

        Comment


          #5
          Not as yet - we'll bump it up the queue and update here when it's fixed.

          Comment


            #6
            By way of a followup on this one - are you still seeing the misbehavior? We no longer see it in testing your use case.

            Comment


              #7
              Hi Isomorphic,

              yes, it happens with the same code as in #1 in v11.1p_2018-02-07 (Win 10, tested FF26 and Chromium 64.0.3282.140). You need to hover the items.

              Best regards
              Blama

              Comment


                #8
                Are you seeing it outside of the Showcase/in your app? We do see it in the showcase, most likely a side-effect of special logic there to handle cross-sample visibility - but we see no issues in a standalone test.

                Comment


                  #9
                  Hi Isomorphic,

                  yes I saw it outside the showcase in my application in a very rough mobile-prototype (same GWT project, same onModuleLoad(), but for now different codepath than the normal application (I know that you advise else, but for now it seemed to be the simplest that way)).
                  As I was able to reproduce in the showcase I did not think that this information was important.
                  There is also another issue in the prototype, it seems that the date picker for a DateItem is drawing itself a little bit (~2px) too high, so that it introduces "scrolling" (=you can move the content a little bit with the finger).
                  Also after closing the date picker the issue then stays at it is. I think this is because the calendar is only hidden, but not destroyed.

                  Best regards
                  Blama

                  Comment


                    #10
                    Hi Isomorphic,

                    this one is still valid in v11.1p_2018-10-14 / v12.0p_2018-10-16 with the sample from #1.
                    It happens in the showcase and on mobile (iOS / Android).

                    Best regards
                    Blama

                    Comment


                      #11
                      As we mentioned we tried a standalone test and could not reproduce this. Let us know if you can share a standalone test that does reproduce it.

                      Comment


                        #12
                        Hi Isomorphic,

                        I tried the above sample from Blama and can reproduce the case. See this modified BuiltInDS sample:

                        Code:
                        package com.smartgwt.sample.client;
                        
                        import com.google.gwt.core.client.EntryPoint;
                        import com.smartgwt.client.core.KeyIdentifier;
                        import com.smartgwt.client.data.DataSource;
                        import com.smartgwt.client.types.ReadOnlyDisplayAppearance;
                        import com.smartgwt.client.util.Page;
                        import com.smartgwt.client.util.PageKeyHandler;
                        import com.smartgwt.client.util.SC;
                        import com.smartgwt.client.widgets.form.DynamicForm;
                        import com.smartgwt.client.widgets.form.fields.ComboBoxItem;
                        import com.smartgwt.client.widgets.form.fields.SelectItem;
                        import com.smartgwt.client.widgets.layout.VStack;
                        
                        /**
                         * Entry point classes define <code>onModuleLoad()</code>.
                         */
                        public class BuiltInDS implements EntryPoint {
                            private DynamicForm boundForm;
                        
                            /**
                             * This is the entry point method.
                             */
                            public void onModuleLoad() {
                                KeyIdentifier debugKey = new KeyIdentifier();
                                debugKey.setCtrlKey(true);
                                debugKey.setKeyName("D");
                        
                                Page.registerKey(debugKey, new PageKeyHandler() {
                                    public void execute(String keyName) {
                                        SC.showConsole();
                                    }
                                });
                        
                                VStack vStack = new VStack();
                                vStack.setWidth("100%");
                                vStack.setMembersMargin(20);
                        
                                boundForm = new DynamicForm();
                                boundForm.setNumCols(2);
                                boundForm.setAutoFocus(false);
                                boundForm.setIsGroup(true);
                                boundForm.setGroupBorderCSS("1px solid black");
                                boundForm.setReadOnlyDisplay(ReadOnlyDisplayAppearance.STATIC);
                                ComboBoxItem sI = new ComboBoxItem();
                                SelectItem sI1 = new SelectItem();
                                DataSource ds = DataSource.get("supplyItem");
                                sI.setOptionDataSource(ds);
                        
                                sI.setDisplayField("itemName");
                                sI.setValueField("SKU");
                                sI.setHint("foo bar");
                                sI.setTitle("Item Name");
                                sI.setValue("Spray Adhesive Multipurpose Can No.76 3M");
                        
                                boundForm.setCanEdit(false);
                                sI1.setOptionDataSource("supplyItem");
                                sI1.setDisplayField("Select");
                                sI1.setValueField("SKU");
                                sI1.setHint("foo bar");
                                sI1.setValue("Spray Adhesive Multipurpose Can No.76 3M");
                        
                                boundForm.setFields(sI, sI1);
                                vStack.addMember(boundForm);
                                vStack.draw();
                            }
                        
                        }

                        SmartClient Version: v12.0p_2018-10-14/PowerEdition Deployment (built 2018-10-14)

                        It would be nice to have a fix for this soon, because it affects our app, and we want to use it in production the next weeks.
                        Thanks in Advance,

                        Kind Regards

                        Comment


                          #13
                          This one's been fixed for builds dated October 19 and later - the problem was that the textBoxStyle is set to the hint style while the missing-value fetch is happening, and should be reset afterwards - in this case, the fetch returns no record (the values provided aren't SKUs) and the style wasn't being updated in that case.

                          Comment

                          Working...
                          X