Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

  • 6.1p: Regression with SpinnerItem and multiple icons being generated

    Hi Isomorphic,

    please see this testcase (v11.1p_2017-12-16, GC63, FF26) and repeatedly open and close the filterRow via the button. Please note how the design of the salary-Filter SpinnerItem is broken.

    BuiltInDS.java:
    Code:
    package com.smartgwt.sample.client;
    
    import com.google.gwt.core.client.EntryPoint;
    import com.smartgwt.client.Version;
    import com.smartgwt.client.core.KeyIdentifier;
    import com.smartgwt.client.data.AdvancedCriteria;
    import com.smartgwt.client.data.Criterion;
    import com.smartgwt.client.data.DataSource;
    import com.smartgwt.client.data.SortSpecifier;
    import com.smartgwt.client.types.OperatorId;
    import com.smartgwt.client.types.SortDirection;
    import com.smartgwt.client.util.Page;
    import com.smartgwt.client.util.PageKeyHandler;
    import com.smartgwt.client.util.SC;
    import com.smartgwt.client.widgets.IButton;
    import com.smartgwt.client.widgets.Window;
    import com.smartgwt.client.widgets.events.ClickEvent;
    import com.smartgwt.client.widgets.events.ClickHandler;
    import com.smartgwt.client.widgets.form.fields.SpinnerItem;
    import com.smartgwt.client.widgets.grid.ListGrid;
    import com.smartgwt.client.widgets.grid.ListGridField;
    import com.smartgwt.client.widgets.layout.VLayout;
    
    public class BuiltInDS implements EntryPoint {
        private VLayout mainLayout;
        private IButton recreateBtn;
    
        public void onModuleLoad() {
            KeyIdentifier debugKey = new KeyIdentifier();
            debugKey.setCtrlKey(true);
            debugKey.setKeyName("D");
    
            Page.registerKey(debugKey, new PageKeyHandler() {
                public void execute(String keyName) {
                    SC.showConsole();
                }
            });
    
            mainLayout = new VLayout(20);
            mainLayout.setWidth100();
            mainLayout.setHeight100();
    
            recreateBtn = new IButton("Recreate");
            recreateBtn.addClickHandler(new ClickHandler() {
                @Override
                public void onClick(ClickEvent event) {
                    recreate();
                }
            });
            mainLayout.addMember(recreateBtn);
            recreate();
            mainLayout.draw();
        }
    
        private void recreate() {
            Window w = new Window();
            w.setWidth("25%");
            w.setHeight("25%");
            w.setMembersMargin(0);
            w.setModalMaskOpacity(70);
            w.setTitle(" (" + Version.getVersion() + "/" + Version.getSCVersionNumber() + ")");
            w.setTitle("SpinnerItem problems" + w.getTitle());
            w.setShowMinimizeButton(false);
            w.setIsModal(true);
            w.setShowModalMask(true);
            w.centerInPage();
    
            final ListGrid employeesGrid = new ListGrid();
    
            employeesGrid.setHeight100();
            employeesGrid.setAutoFetchData(false);
            employeesGrid.setCanEdit(true);
            employeesGrid.setDataSource(DataSource.get("employees"));
            employeesGrid.setCanGroupBy(false);
            employeesGrid.setShowRecordComponents(false);
            employeesGrid.setShowRecordComponentsByCell(false);
    
            ListGridField employeeId = new ListGridField("EmployeeId");
            employeeId.setCanEdit(false);
    
            ListGridField name = new ListGridField("Name");
            name.setCanEdit(false);
    
            ListGridField gender = new ListGridField("Gender");
    
            ListGridField job = new ListGridField("Job");
    
            ListGridField salary = new ListGridField("Salary");
            salary.setFilterEditorProperties(new SpinnerItem() {
                {
                    setOperator(OperatorId.EQUALS);
                }
            });
    
            employeesGrid.setFields(employeeId, name, gender, job, salary);
            employeesGrid.setSort(new SortSpecifier[] { new SortSpecifier(name.getName(), SortDirection.ASCENDING) });
            employeesGrid.fetchData(new AdvancedCriteria(new Criterion(name.getName(), OperatorId.STARTS_WITH, "A")));
            w.addItem(employeesGrid);
    
            IButton showHideFilterRow = new IButton("Show/Hide filterRow", new ClickHandler() {
                @Override
                public void onClick(ClickEvent event) {
                    employeesGrid.setShowFilterEditor(!employeesGrid.getShowFilterEditor());
                }
            });
            w.addItem(showHideFilterRow);
    
            w.show();
        }
    }
    Video:
    Click image for larger version

Name:	SpinnerItem.gif
Views:	1
Size:	20.4 KB
ID:	250895




    I also get this in the Developer Console log:
    Code:
    [ERROR] [builtinds] - 17:21:25.299:MUP9:WARN:SpinnerItem:isc_SpinnerItem_0[Salary]:This form item has more than one icon with the same specified name:increase. Ignoring this name and using an auto-generated one instead.
    [ERROR] [builtinds] - 17:21:25.300:MUP9:WARN:SpinnerItem:isc_SpinnerItem_0[Salary]:This form item has more than one icon with the same specified name:decrease. Ignoring this name and using an auto-generated one instead.
    [ERROR] [builtinds] - 17:21:27.662:MUP1:WARN:SpinnerItem:isc_SpinnerItem_0[Salary]:This form item has more than one icon with the same specified name:increase. Ignoring this name and using an auto-generated one instead.
    [ERROR] [builtinds] - 17:21:27.663:MUP1:WARN:SpinnerItem:isc_SpinnerItem_0[Salary]:This form item has more than one icon with the same specified name:decrease. Ignoring this name and using an auto-generated one instead.
    [ERROR] [builtinds] - 17:21:27.666:MUP1:WARN:SpinnerItem:isc_SpinnerItem_0[Salary]:This form item has more than one icon with the same specified name:_0. Ignoring this name and using an auto-generated one instead.
    [ERROR] [builtinds] - 17:21:27.668:MUP1:WARN:SpinnerItem:isc_SpinnerItem_0[Salary]:This form item has more than one icon with the same specified name:_1. Ignoring this name and using an auto-generated one instead.
    [ERROR] [builtinds] - 17:21:29.993:MUP3:WARN:SpinnerItem:isc_SpinnerItem_0[Salary]:This form item has more than one icon with the same specified name:increase. Ignoring this name and using an auto-generated one instead.
    [ERROR] [builtinds] - 17:21:29.994:MUP3:WARN:SpinnerItem:isc_SpinnerItem_0[Salary]:This form item has more than one icon with the same specified name:decrease. Ignoring this name and using an auto-generated one instead.
    [ERROR] [builtinds] - 17:21:29.996:MUP3:WARN:SpinnerItem:isc_SpinnerItem_0[Salary]:This form item has more than one icon with the same specified name:_0. Ignoring this name and using an auto-generated one instead.
    [ERROR] [builtinds] - 17:21:29.997:MUP3:WARN:SpinnerItem:isc_SpinnerItem_0[Salary]:This form item has more than one icon with the same specified name:_1. Ignoring this name and using an auto-generated one instead.
    [ERROR] [builtinds] - 17:21:29.999:MUP3:WARN:SpinnerItem:isc_SpinnerItem_0[Salary]:This form item has more than one icon with the same specified name:_2. Ignoring this name and using an auto-generated one instead.
    [ERROR] [builtinds] - 17:21:30.000:MUP3:WARN:SpinnerItem:isc_SpinnerItem_0[Salary]:This form item has more than one icon with the same specified name:_3. Ignoring this name and using an auto-generated one instead.
    Best regards
    Blama

  • #2
    We've made a change to address this issue. Please try the next nightly build, dated December 23.

    Regards
    Isomorphic Software

    Comment


    • #3
      Hi Isomorphic,

      I can see that this one is fixed using v11.1p_2017-12-27 in the sample. I assume that it will also fix it in my application.

      Best regards
      Blama

      Comment

      Working...
      X