Minor NPE when using setUserRoles with null

[Blama]

Hi Isomorphic,

please see this stack trace. I know that my code is in there as well, calling setUserRoles() with null, but perhaps you want to fail here gracefully in RPCManager.setUserRoles() or add a null-check in DataTools.commaSeparatedStringToList().

=== 2018-07-02 17:54:01,891 [ec-1] ERROR LMSRESTHandler - com.lmscompany.lms.server.LMSRESTHandler top-level exception
java.lang.NullPointerException
at java.util.StringTokenizer.<init>(Unknown Source)
at java.util.StringTokenizer.<init>(Unknown Source)
at com.isomorphic.util.DataTools.commaSeparatedStringToList(DataTools.java:4993)
at com.isomorphic.datasource.DSTransaction.setUserRoles(DSTransaction.java:1316)
at com.isomorphic.rpc.RPCManager.setUserRoles(RPCManager.java:2913)
at com.lmscompany.lms.server.LMSRESTHandler.processRestTransaction(LMSRESTHandler.java:49)
at com.isomorphic.servlet.RESTHandler.processRequest(RESTHandler.java:524)
at com.isomorphic.servlet.RESTHandler.doPost(RESTHandler.java:421)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:661)
at com.isomorphic.servlet.BaseServlet.service(BaseServlet.java:176)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:742)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at com.isomorphic.servlet.CompressionFilter._doFilter(CompressionFilter.java:247)
at com.isomorphic.servlet.BaseFilter.doFilter(BaseFilter.java:93)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:624)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)
at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
at java.lang.Thread.run(Unknown Source)

Best regards
Blama

[Isomorphic]

We've made a change to address this issue. Please try the next nightly build, dated July 04.

Regards
Isomorphic Software