Announcement

**Isomorphic** · 29 Dec 2012, 10:07

We can't really see what would cause this except perhaps "&&" in the query string. Can you capture the query string so we can see it?

**bda@celerity.be** · 29 Dec 2012, 12:29

I don't know how to do what you ask, but after some analysis I found that the exception is launched AFTER a ds.performCustomOperation (client side) and BEFORE the corresponding DMI (server side) is executed. The SQL is actually generated in the DMI, so there is no SQL involved yet when the Exception occurs.

Here is the client side code that calls the DMI:

Code:

			DSRequest request = new DSRequest();
			HashMap<String, Object> params = new HashMap<String, Object>();
			params.put("id_person",user==null?null:user.getId());
			params.put("id_operation",MoonMobile.getOperationId(operation));
			params.put("id_object",MoonMobile.getObjectId(object));
			params.put("id_record",id);
			params.put("custom",custom);
			if(operation.equals(OPERATION_LOGIN_FAILURE_USERNAME)||
			   operation.equals(OPERATION_LOGIN_FAILURE_PASSWORD)||
			   operation.equals(OPERATION_LOGIN_SUCCESS)){
				params.put("addClientInfo",MoonMobile.getUIVersion());
			}
			request.setParams(params);

ds.performCustomOperation("log",new Record(),new DSCallback() {
				public void execute(DSResponse response, Object rawData, DSRequest request) {
				}
			},request);

At execution time a params.toString() gives:

Code:

{id_object=null, id_person=3, id_record=null, id_operation=3, addClientInfo=1.3.0, custom=}

The ds

Code:

<DataSource
    ID="mb_logger"
	serverType="sql"
	tableName="ui_logger"
>
    <fields>
    </fields>
   	<operationBindings>
        <binding operationType="custom" operationId="log" serverMethod="log">
            <serverObject lookupStyle="new" className="com.nside.moon.server.dmi.LoggerDMI"/>
        </binding>
    </operationBindings>         
</DataSource>

The DMI (which is not in cause since if I break on the first line of log method, the Exception has already occured):

Code:

package com.nside.moon.server.dmi;

import java.sql.Connection;
import java.sql.Statement;
import java.text.SimpleDateFormat;
import java.util.Date;

import javax.servlet.http.HttpServletRequest;

import com.isomorphic.datasource.DSRequest;
import com.isomorphic.datasource.DSResponse;
import com.mysql.jdbc.jdbc2.optional.MysqlDataSource;
import com.nside.moon.server.listener.MYSQLServletContextListener;


public class LoggerDMI {
	
	private static SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS");
	private static String sqlTemplate = "INSERT INTO log_ui (date,id_person,id_operation,id_object,id_record,custom) VALUES('%s',%s,%s,%s,%s,%s);";
	
    public DSResponse log(DSRequest dsRequest) throws Exception {  
        
		HttpServletRequest r = dsRequest.getHttpServletRequest();
		
		
		String date = dateFormat.format(new Date());
		String id_person = r.getParameter("id_person");
		String id_operation = r.getParameter("id_operation");
		String id_object = r.getParameter("id_object");
		String id_record = r.getParameter("id_record");
		String custom = r.getParameter("custom");
		String clientInfo = r.getParameter("addClientInfo");
		if (clientInfo!=null){
			String ip = r.getRemoteAddr();
			String browser = r.getHeader("User-Agent");
			String uiversion = clientInfo;
			custom += " client info:" + ip + " " + browser + " uiversion=" + uiversion; 
		}
		if (!custom.equals("null")) custom = "'"+custom+"'";
    	
		String sql =String.format(sqlTemplate, date,id_person,id_operation,id_object,id_record,custom);

		Connection con = null;
        try {

        	MysqlDataSource ds = new MysqlDataSource();  
        	ds.setURL(MYSQLServletContextListener.URL);
        	ds.setUser(MYSQLServletContextListener.USER);  
        	ds.setPassword(MYSQLServletContextListener.PASSWORD);

        	con = ds.getConnection();
            Statement stmt = con.createStatement();
            stmt.executeUpdate(sql);
            stmt.close();

        	con.close();

        } catch (Exception e) {
        	throw e;
        }
        
        
        DSResponse resp = new DSResponse();  
        resp.setStatus(DSResponse.STATUS_SUCCESS);  
        return resp;  
    	

    }  
	
}

**bda@celerity.be** · 29 Dec 2012, 12:58

Additional info:

If I comment the line request.setParams(params), the exception is not thrown. This shows that the problem comes from the passing of request params to the DMI.

Looking at the param values, I noticed the zero-length string assigned to "custom" param, which is apparently the cause of the problem. If I pass a null value instead it works. If I pass a non-empty string it works as well.

Conclusion, passing "" (zero-length string) to a string parameter in the request causes the Exception.

I am waiting on you hand and foot ;-).

**Isomorphic** · 29 Dec 2012, 19:31

This if fixed for tomorrow's SGWT (desktop / server) build.

**bda@celerity.be** · 2 Jan 2013, 06:43

Works, thanks!

Announcement

SGWT.mobile - Exception on com.isomorphic.servlet.ServletTools.parseQueryStri ng

Comment

Comment

Comment

Comment

Comment