Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

  • Icon position in 12.1

    Hi Isomorphic,

    using "SNAPSHOT_v12.1d_2018-08-30/PowerEdition Deployment (built 2018-08-30)" position of validator icon and FormItemIcon does not look good.
    Click image for larger version

Name:	icon_and_validator_1.PNG
Views:	1
Size:	2.5 KB
ID:	254786

    Using "v11.1p_2018-08-04/PowerEdition Deployment (built 2018-08-04)" it looks like it should look.
    Click image for larger version

Name:	icon_and_validator_2.PNG
Views:	1
Size:	1.5 KB
ID:	254787


    If you don't succeed reproduce it, I can create a test case.

    Best regards
    Pavo

  • #2
    If you can post the definition of the item in your images, that will be sufficient

    Comment


    • #3
      Oh sorry, it's LinkItem.

      Comment


      • #4
        Hi Isomorphic,

        the same problem using v12.0p_2018-09-12/PowerEdition Deployment (built 2018-09-12) for SelectItem.


        Click image for larger version  Name:	selectItem_2.PNG Views:	1 Size:	582 Bytes ID:	255048

        Click image for larger version  Name:	selectItem_1.PNG Views:	1 Size:	910 Bytes ID:	255047

        Best regards
        Pavo

        Comment


        • #5
          Again, if you can post the definition of the items in your images, that is, the actual settings you're applying, we can take a look.

          Comment


          • #6
            Hi Isomorphic,

            sorry again. I see three problems you can see on gif:
            1) On validator error if using icon, "Field1" becomes wider.
            2) Border on "Field1" missing all the time.
            3) Border on "Field2" missing just on hover.

            Click image for larger version  Name:	selectItem.gif Views:	1 Size:	79.2 KB ID:	255060

            Code:
            package com.smartgwt.sample.client;
            
            import java.util.Date;
            
            import com.google.gwt.core.client.EntryPoint;
            import com.google.gwt.i18n.client.LocaleInfo;
            import com.google.gwt.i18n.shared.DateTimeFormat;
            import com.google.gwt.i18n.shared.DateTimeFormatInfo;
            import com.smartgwt.client.Version;
            import com.smartgwt.client.core.KeyIdentifier;
            import com.smartgwt.client.util.DateDisplayFormatter;
            import com.smartgwt.client.util.DateParser;
            import com.smartgwt.client.util.DateUtil;
            import com.smartgwt.client.util.Page;
            import com.smartgwt.client.util.PageKeyHandler;
            import com.smartgwt.client.util.SC;
            import com.smartgwt.client.widgets.Button;
            import com.smartgwt.client.widgets.IButton;
            import com.smartgwt.client.widgets.Window;
            import com.smartgwt.client.widgets.events.ClickEvent;
            import com.smartgwt.client.widgets.events.ClickHandler;
            import com.smartgwt.client.widgets.form.DynamicForm;
            import com.smartgwt.client.widgets.form.fields.FormItemIcon;
            import com.smartgwt.client.widgets.form.fields.SelectItem;
            import com.smartgwt.client.widgets.layout.VLayout;
            
            public class BuiltInDS extends VLayout implements EntryPoint {
                private IButton recreateBtn;
            
                public void onModuleLoad() {
                    KeyIdentifier debugKey = new KeyIdentifier();
                    debugKey.setCtrlKey(true);
                    debugKey.setKeyName("D");
            
                    Page.registerKey(debugKey, new PageKeyHandler() {
                        public void execute(String keyName) {
                            SC.showConsole();
                        }
                    });
            
                    DateUtil.setShortDatetimeDisplayFormatter(new DateDisplayFormatter() {
                        public String format(Date date) {
                            if (date == null)
                                return null;
                            DateTimeFormatInfo ddtfi = LocaleInfo.getCurrentLocale().getDateTimeFormatInfo();
                            final DateTimeFormat dateFormatter = DateTimeFormat.getFormat(ddtfi.formatYearMonthAbbrevDay());
                            String format = dateFormatter.format(date);
                            return format;
                        }
                    });
            
                    DateUtil.setDateParser(new DateParser() {
                        public Date parse(String dateString) {
                            DateTimeFormatInfo ddtfi = LocaleInfo.getCurrentLocale().getDateTimeFormatInfo();
                            final DateTimeFormat format = DateTimeFormat.getFormat(ddtfi.formatYearMonthAbbrevDay());
                            Date date = format.parse(dateString);
                            return date;
                        }
                    });
            
                    setWidth100();
                    setHeight100();
            
                    recreateBtn = new IButton("Recreate");
                    recreateBtn.addClickHandler(new ClickHandler() {
                        @Override
                        public void onClick(ClickEvent event) {
                            new MyWindow().show();
                        }
                    });
                    addMember(recreateBtn);
                    new MyWindow().show();
                    draw();
                }
            
                private class MyWindow extends Window {
            
                    public MyWindow() {
            
                        setWidth(800);
                        setHeight(600);
                        setMembersMargin(0);
                        setModalMaskOpacity(70);
                        setTitle(" (" + Version.getVersion() + "/" + Version.getSCVersionNumber() + ")");
                        SC.logWarn(" (" + Version.getVersion() + "/" + Version.getSCVersionNumber() + ")");
                        setShowMinimizeButton(false);
                        setIsModal(true);
                        setShowModalMask(true);
                        centerInPage();
            
                        TestHL testHL = new TestHL();
            
                        addItem(testHL);
                    }
            
                    private class TestHL extends VLayout {
                        public TestHL() {
            
                            FormItemIconTest formItemIconTest = new FormItemIconTest();
            
                            SelectItemTest selectItemTest1 = new SelectItemTest("commonName");
                            selectItemTest1.setIcons(formItemIconTest);
            
                            SelectItemTest selectItemTest2 = new SelectItemTest("lifeSpan");
            
                            final DynamicForm df = new DynamicForm();
                            df.setWidth(300);
                            df.setDataSource("animals");
            
                            df.setFields(selectItemTest1, selectItemTest2);
            
                            Button saveButton = new Button("save");
                            saveButton.addClickHandler(new ClickHandler() {
                                @Override
                                public void onClick(ClickEvent event) {
                                    df.saveData();
                                }
                            });
            
                            setMembers(df, saveButton);
                        }
                    }
            
                    private class FormItemIconTest extends FormItemIcon {
                        public FormItemIconTest() {
                            setSrc("http://127.0.0.1:8888/builtinds/tools/images/database_gear.png");
                            setInline(true);
                            setTabIndex(-1);
                        }
                    }
            
                    private class SelectItemTest extends SelectItem {
                        public SelectItemTest(String name) {
                            super(name);
                            setAllowEmptyValue(true);
                            setCanEdit(true);
                            setRequired(true);
                        }
                    }
                }
            }
            Regards, Pavo
            Last edited by pavo123; 14th Sep 2018, 04:33.

            Comment


            • #7
              Problem 1) (On validator error if using icon, "Field1" becomes wider.) is also happening for SpinnerItem and ComboBoxItem with the same applying settings .

              Comment


              • #8
                For TextItem and LinkItem:
                1) forms are moving and becomes zoomed
                2) forms changing height and width

                Click image for larger version  Name:	forms.gif Views:	1 Size:	94.2 KB ID:	255063

                Code:
                package com.smartgwt.sample.client;
                
                import java.util.Date;
                
                import com.google.gwt.core.client.EntryPoint;
                import com.google.gwt.i18n.client.LocaleInfo;
                import com.google.gwt.i18n.shared.DateTimeFormat;
                import com.google.gwt.i18n.shared.DateTimeFormatInfo;
                import com.smartgwt.client.Version;
                import com.smartgwt.client.core.KeyIdentifier;
                import com.smartgwt.client.util.DateDisplayFormatter;
                import com.smartgwt.client.util.DateParser;
                import com.smartgwt.client.util.DateUtil;
                import com.smartgwt.client.util.Page;
                import com.smartgwt.client.util.PageKeyHandler;
                import com.smartgwt.client.util.SC;
                import com.smartgwt.client.widgets.Button;
                import com.smartgwt.client.widgets.IButton;
                import com.smartgwt.client.widgets.Window;
                import com.smartgwt.client.widgets.events.ClickEvent;
                import com.smartgwt.client.widgets.events.ClickHandler;
                import com.smartgwt.client.widgets.form.DynamicForm;
                import com.smartgwt.client.widgets.form.fields.FormItemIcon;
                import com.smartgwt.client.widgets.form.fields.TextItem;
                import com.smartgwt.client.widgets.layout.VLayout;
                
                public class BuiltInDS extends VLayout implements EntryPoint {
                    private IButton recreateBtn;
                
                    public void onModuleLoad() {
                        KeyIdentifier debugKey = new KeyIdentifier();
                        debugKey.setCtrlKey(true);
                        debugKey.setKeyName("D");
                
                        Page.registerKey(debugKey, new PageKeyHandler() {
                            public void execute(String keyName) {
                                SC.showConsole();
                            }
                        });
                
                        DateUtil.setShortDatetimeDisplayFormatter(new DateDisplayFormatter() {
                            public String format(Date date) {
                                if (date == null)
                                    return null;
                                DateTimeFormatInfo ddtfi = LocaleInfo.getCurrentLocale().getDateTimeFormatInfo();
                                final DateTimeFormat dateFormatter = DateTimeFormat.getFormat(ddtfi.formatYearMonthAbbrevDay());
                                String format = dateFormatter.format(date);
                                return format;
                            }
                        });
                
                        DateUtil.setDateParser(new DateParser() {
                            public Date parse(String dateString) {
                                DateTimeFormatInfo ddtfi = LocaleInfo.getCurrentLocale().getDateTimeFormatInfo();
                                final DateTimeFormat format = DateTimeFormat.getFormat(ddtfi.formatYearMonthAbbrevDay());
                                Date date = format.parse(dateString);
                                return date;
                            }
                        });
                
                        setWidth100();
                        setHeight100();
                
                        recreateBtn = new IButton("Recreate");
                        recreateBtn.addClickHandler(new ClickHandler() {
                            @Override
                            public void onClick(ClickEvent event) {
                                new MyWindow().show();
                            }
                        });
                        addMember(recreateBtn);
                        new MyWindow().show();
                        draw();
                    }
                
                    private class MyWindow extends Window {
                
                        public MyWindow() {
                
                            setWidth(800);
                            setHeight(600);
                            setMembersMargin(0);
                            setModalMaskOpacity(70);
                            setTitle(" (" + Version.getVersion() + "/" + Version.getSCVersionNumber() + ")");
                            SC.logWarn(" (" + Version.getVersion() + "/" + Version.getSCVersionNumber() + ")");
                            setShowMinimizeButton(false);
                            setIsModal(true);
                            setShowModalMask(true);
                            centerInPage();
                
                            TestHL testHL = new TestHL();
                
                            addItem(testHL);
                        }
                
                        private class TestHL extends VLayout {
                            public TestHL() {
                
                                FormItemIconTest formItemIconTest = new FormItemIconTest();
                
                                SelectItemTest selectItemTest1 = new SelectItemTest("commonName");
                                selectItemTest1.setIcons(formItemIconTest);
                
                                SelectItemTest selectItemTest2 = new SelectItemTest("lifeSpan");
                
                                final DynamicForm df = new DynamicForm();
                                df.setWidth(300);
                                df.setDataSource("animals");
                
                                df.setFields(selectItemTest1, selectItemTest2);
                
                                Button saveButton = new Button("save");
                                saveButton.addClickHandler(new ClickHandler() {
                                    @Override
                                    public void onClick(ClickEvent event) {
                                        df.saveData();
                                    }
                                });
                
                                setMembers(df, saveButton);
                            }
                        }
                
                        private class FormItemIconTest extends FormItemIcon {
                            public FormItemIconTest() {
                                setSrc("http://127.0.0.1:8888/builtinds/tools/images/database_gear.png");
                            }
                        }
                
                        private class SelectItemTest extends TextItem {
                            // private class SelectItemTest extends LinkItem {
                            public SelectItemTest(String name) {
                                super(name);
                                setCanEdit(true);
                                setRequired(true);
                            }
                        }
                    }
                }

                Comment


                • #9
                  One more problem for LinkItem:
                  1) the right icon moves to the right

                  Click image for larger version

Name:	linkItem.gif
Views:	1
Size:	28.2 KB
ID:	255066

                  Code:
                  package com.smartgwt.sample.client;
                  
                  import java.util.Date;
                  
                  import com.google.gwt.core.client.EntryPoint;
                  import com.google.gwt.i18n.client.LocaleInfo;
                  import com.google.gwt.i18n.shared.DateTimeFormat;
                  import com.google.gwt.i18n.shared.DateTimeFormatInfo;
                  import com.smartgwt.client.Version;
                  import com.smartgwt.client.core.KeyIdentifier;
                  import com.smartgwt.client.util.DateDisplayFormatter;
                  import com.smartgwt.client.util.DateParser;
                  import com.smartgwt.client.util.DateUtil;
                  import com.smartgwt.client.util.Page;
                  import com.smartgwt.client.util.PageKeyHandler;
                  import com.smartgwt.client.util.SC;
                  import com.smartgwt.client.widgets.Button;
                  import com.smartgwt.client.widgets.IButton;
                  import com.smartgwt.client.widgets.Window;
                  import com.smartgwt.client.widgets.events.ClickEvent;
                  import com.smartgwt.client.widgets.events.ClickHandler;
                  import com.smartgwt.client.widgets.form.DynamicForm;
                  import com.smartgwt.client.widgets.form.fields.FormItemIcon;
                  import com.smartgwt.client.widgets.form.fields.LinkItem;
                  import com.smartgwt.client.widgets.layout.VLayout;
                  
                  public class BuiltInDS extends VLayout implements EntryPoint {
                      private IButton recreateBtn;
                  
                      public void onModuleLoad() {
                          KeyIdentifier debugKey = new KeyIdentifier();
                          debugKey.setCtrlKey(true);
                          debugKey.setKeyName("D");
                  
                          Page.registerKey(debugKey, new PageKeyHandler() {
                              public void execute(String keyName) {
                                  SC.showConsole();
                              }
                          });
                  
                          DateUtil.setShortDatetimeDisplayFormatter(new DateDisplayFormatter() {
                              public String format(Date date) {
                                  if (date == null)
                                      return null;
                                  DateTimeFormatInfo ddtfi = LocaleInfo.getCurrentLocale().getDateTimeFormatInfo();
                                  final DateTimeFormat dateFormatter = DateTimeFormat.getFormat(ddtfi.formatYearMonthAbbrevDay());
                                  String format = dateFormatter.format(date);
                                  return format;
                              }
                          });
                  
                          DateUtil.setDateParser(new DateParser() {
                              public Date parse(String dateString) {
                                  DateTimeFormatInfo ddtfi = LocaleInfo.getCurrentLocale().getDateTimeFormatInfo();
                                  final DateTimeFormat format = DateTimeFormat.getFormat(ddtfi.formatYearMonthAbbrevDay());
                                  Date date = format.parse(dateString);
                                  return date;
                              }
                          });
                  
                          setWidth100();
                          setHeight100();
                  
                          recreateBtn = new IButton("Recreate");
                          recreateBtn.addClickHandler(new ClickHandler() {
                              @Override
                              public void onClick(ClickEvent event) {
                                  new MyWindow().show();
                              }
                          });
                          addMember(recreateBtn);
                          new MyWindow().show();
                          draw();
                      }
                  
                      private class MyWindow extends Window {
                  
                          public MyWindow() {
                  
                              setWidth(800);
                              setHeight(600);
                              setMembersMargin(0);
                              setModalMaskOpacity(70);
                              setTitle(" (" + Version.getVersion() + "/" + Version.getSCVersionNumber() + ")");
                              SC.logWarn(" (" + Version.getVersion() + "/" + Version.getSCVersionNumber() + ")");
                              setShowMinimizeButton(false);
                              setIsModal(true);
                              setShowModalMask(true);
                              centerInPage();
                  
                              TestHL testHL = new TestHL();
                  
                              addItem(testHL);
                          }
                  
                          private class TestHL extends VLayout {
                              public TestHL() {
                  
                                  FormItemIconTest formItemIconTest1 = new FormItemIconTest(true);
                                  FormItemIconTest checkIcon = new FormItemIconTest(false);
                  
                                  LinkItemTest selectItemTest1 = new LinkItemTest("commonName");
                                  selectItemTest1.setIcons(formItemIconTest1, checkIcon);
                  
                                  final DynamicForm df = new DynamicForm();
                                  df.setWidth(300);
                                  df.setDataSource("animals");
                  
                                  df.setFields(selectItemTest1);
                  
                                  Button saveButton = new Button("save");
                                  saveButton.addClickHandler(new ClickHandler() {
                                      @Override
                                      public void onClick(ClickEvent event) {
                                          df.saveData();
                                      }
                                  });
                  
                                  setMembers(df, saveButton);
                              }
                          }
                  
                          private class FormItemIconTest extends FormItemIcon {
                              public FormItemIconTest(Boolean positionLeft) {
                                  setSrc("http://127.0.0.1:8888/builtinds/tools/images/database_gear.png");
                                  if (positionLeft) {
                                      setInline(true);
                                      setTabIndex(-1);
                                  }
                              }
                          }
                  
                          private class LinkItemTest extends LinkItem {
                              public LinkItemTest(String name) {
                                  super(name);
                                  setCanEdit(true);
                                  setRequired(true);
                              }
                          }
                      }
                  }

                  Comment


                  • #10
                    Hi Isomorphic,

                    have you been able to reproduce these 4 bugs?

                    Best regards
                    Pavo

                    Comment

                    Working...
                    X