Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

    Close tab icon in vertical tabset seems wrongly positioned

    As shown in the attached image, the default close tab icon seems incorrectly placed.

    Click image for larger version

Name:	tabset.png
Views:	85
Size:	4.3 KB
ID:	255256

    The code is lifted off the showcase:

    Code:
            final TabSet leftTabSet = new TabSet();  
            leftTabSet.setTabBarPosition(Side.LEFT);  
            leftTabSet.setWidth(400);  
            leftTabSet.setHeight(400);
            leftTabSet.setTabBarThickness(200);
            leftTabSet.setCanCloseTabs(true);
    
            Tab lTab1 = new Tab("My tab 1");  
            lTab1.setPane(new HLayout());  
    
            Tab lTab2 = new Tab("My tab 2");  
            lTab2.setPane(new HLayout());  
    
            leftTabSet.addTab(lTab1);  
            leftTabSet.addTab(lTab2);
    
            VStack vStack = new VStack(10);  
            vStack.addMember(leftTabSet);
            vStack.draw();
    This is tested on Firefox 62.0.2 (64-bit) on MacOSX and SmartGWT v12.0p_2018-09-26 using the Stratus theme.

    On a related note is there a way to control the height of the individual tabs? Thanks.

    #2
    Hello, any updates on this? I have been trying to fix it with CSS but not having much luck, it looks like the close button is placed inside its own <td> with the class tabButtonLeftSelected (like the tabs) making it hard to isolate in CSS.

    Any tips much appreciated.

    Comment


      #3
      It's queued to be looked at - if you need faster response times, consider purchasing support.

      Initial tests show that the closeIcon is indeed rendered in it's own <td> and is wrapping to the next line - we'll let you know when we've looked into it and have more information.

      As for tab-heights, you can set height directly on your tabs, but you would also need to set overflow: "hidden" on them to prevent auto-sizing - after that, you might also want to look into tabBarThickness to ensure tab-content is visible.

      Comment


        #4
        We've made some changes here - you should find the closeIcon behaving as you expect in builds dated October 5 and later.

        You should also find that just setting an arbitrary height on a tab will now work as you expect in "left" and "right" tabOrientations, without specifying overflow.

        Comment


          #5
          Perfect it is fixed - thanks :)

          Comment

          Working...
          X