Announcement

**Isomorphic** · 6 Feb 2019, 21:57

We're not reproducing this - does your code install a custom canEditCriterion() into field.filterEditorProperties?

If you can show the config for the grid in question, or at least the field properties for the failing field, and perhaps describe which steps reproduce the issue, we'll take another look.

**Blama** · 7 Feb 2019, 09:50

Hi Isomorphic,

there definitely is something wrong. I do have a similar error (Maximum call stack size exceeded) in the same version and same complied code in a grouped ListGrid with recordComponents (mentioning it, as it perhaps this will already ring some bell), when I show and hide and show again the filterRow. 1st time showing, everything is good, 2nd time showing, it displays broken below of the ListGrid (see video).
I do get this error in the client console:

Code:

18:42:38.358:MUP3:WARN:Log:com.google.gwt.core.client.JavaScriptException: (RangeError) : Maximum call stack size exceeded
    at t0(lms-0.js)
    at Jd(lms-0.js)
    at Cd(lms-0.js)
    at Z2(lms-0.js)
    at d3(lms-0.js)
    at eval(lms-0.js)
    at lc(lms-0.js)
    at oc(lms-0.js)
    at eval(lms-0.js)
    at C6.d.click(lms-0.js)
    at isc_StatefulCanvas_handleActivate(https://test.leadtributor.com/test/lms/sc/modules/ISC_Foundation.js?isc_version=12.0p_2019-01-23.js)
    at isc_StatefulCanvas_handleClick(https://test.leadtributor.com/test/lms/sc/modules/ISC_Foundation.js?isc_version=12.0p_2019-01-23.js)
    at isc_c_EventHandler_bubbleEvent(https://test.leadtributor.com/test/lms/sc/modules/ISC_Core.js?isc_version=12.0p_2019-01-23.js)
    at isc_c_EventHandler_handleClick(https://test.leadtributor.com/test/lms/sc/modules/ISC_Core.js?isc_version=12.0p_2019-01-23.js)
    at isc_c_EventHandler__handleMouseUp(https://test.leadtributor.com/test/lms/sc/modules/ISC_Core.js?isc_version=12.0p_2019-01-23.js)
    at isc_c_EventHandler_handleMouseUp(https://test.leadtributor.com/test/lms/sc/modules/ISC_Core.js?isc_version=12.0p_2019-01-23.js)
    at isc_c_EventHandler_dispatch(https://test.leadtributor.com/test/lms/sc/modules/ISC_Core.js?isc_version=12.0p_2019-01-23.js)
    at eval(eval at isc__makeFunction (https://test.leadtributor.com/test/lms/sc/modules/ISC_Core.js?isc_version=12.0p_2019-01-23.js)

On my way to a testcase (not showing the issue, yet), I have this:

Code:

isc.VStack.create({
    membersMargin: 30,
    width: "100%",
    height: "100%",
    members: [
        isc.IButton.create({
            title: "Filter",
            click: function() {
                dsListGrid.setShowFilterEditor(!dsListGrid.showFilterEditor);
            }
        }),
        isc.ListGrid.create({
            ID: "dsListGrid",
            width: "100%",
            height: "70%",
            autoFetchData: true,
            autoDraw: true,
            dataSource: "supplyItem",
            canResizeFields: true,
            virtualScrolling: false,
            showRecordComponents: true,
            showRecordComponentsByCell: true,
            canRemoveRecords: true,
            recordComponentPoolingMode: "recycle",
            groupByField: "category",
            initialCriteria: {
                _constructor: "AdvancedCriteria",
                operator: "and",
                criteria: [{
                    fieldName: "SKU",
                    operator: "startsWith",
                    value: "1"
                }]
            },
            fields: [{
                    name: "itemID"
                },
                {
                    name: "itemName"
                },
                {
                    name: "SKU"
                },
                {
                    name: "description"
                },
                {
                    name: "category"
                },
                {
                    name: "units"
                },
                {
                    name: "unitCost"
                },
                {
                    name: "inStock"
                },
                {
                    name: "nextShipment"
                },
                {
                    name: "buttonField",
                    title: "Info",
                    align: "center"
                },
                {
                    name: "iconField",
                    title: "Comments/Stats",
                    width: 110
                }
            ]
        })
    ],
    createRecordComponent: function(record, colNum) {
        var fieldName = this.getFieldName(colNum);

        if (fieldName == "iconField") {
            var recordCanvas = isc.HLayout.create({
                height: 22,
                width: "100%",
                align: "center"
            });

            var editImg = isc.ImgButton.create({
                showDown: false,
                showRollOver: false,
                layoutAlign: "center",
                src: "icons/16/comment_edit.png",
                prompt: "Edit Comments",
                height: 16,
                width: 16,
                grid: this,
                click: function() {
                    isc.say("Edit Comment Icon Clicked for country : " + record["countryName"]);
                }
            });

            var chartImg = isc.ImgButton.create({
                showDown: false,
                showRollOver: false,
                layoutAlign: "center",
                src: "icons/16/chart_bar.png",
                prompt: "View Chart",
                height: 16,
                width: 16,
                grid: this,
                click: function() {
                    isc.say("Chart Icon Clicked for country : " + record["countryName"]);
                }
            });

            recordCanvas.addMember(editImg);
            recordCanvas.addMember(chartImg);
            return recordCanvas;
        } else if (fieldName == "buttonField") {
            var button = isc.IButton.create({
                height: 26,
                width: 65,
                layoutAlign: "center",
                icon: "flags/16/" + record["countryCode"] + ".png",
                title: "Info",
                click: function() {
                    isc.say(record["countryName"] + " info button clicked.");
                }
            });
            return button;
        } else {
            return null;
        }
    },

    updateRecordComponent: function(record, colNum, component, recordChanged) {
        var fieldName = this.getFieldName(colNum);
        if (fieldName == "iconField") {
            var membersArray = component.getMembers();
            for (i = 0; i < membersArray.size; i++) {
                if (i == 0) {
                    membersArray[i].addProperties({
                        click: function() {
                            isc.say("Edit Comment Icon Clicked for country : " + record["countryName"]);
                        }
                    });
                } else {
                    membersArray[i].addProperties({
                        click: function() {
                            isc.say("Chart Icon Clicked for country : " + record["countryName"]);
                        }
                    });
                }
            }
        } else if (fieldName == "buttonField") {
            component.addProperties({
                icon: "flags/16/" + record["countryCode"] + ".png",
                click: function() {
                    isc.say(record["countryName"] + " info button clicked.");
                }
            });
        } else {
            return null;
        }
        return component;
    }

});

Best regards
Blama

**pavo123** · 8 Feb 2019, 02:17

Hi Isomorphic,

please take a look at this case.
After I open the filter and close it, then try to open it again, an error appears.

Code:

package com.smartgwt.sample.client;

import com.google.gwt.core.client.EntryPoint;
import com.google.gwt.core.client.GWT;
import com.smartgwt.client.Version;
import com.smartgwt.client.bean.BeanFactory;
import com.smartgwt.client.core.KeyIdentifier;
import com.smartgwt.client.data.AdvancedCriteria;
import com.smartgwt.client.data.Criterion;
import com.smartgwt.client.types.OperatorId;
import com.smartgwt.client.util.Page;
import com.smartgwt.client.util.PageKeyHandler;
import com.smartgwt.client.util.SC;
import com.smartgwt.client.widgets.Button;
import com.smartgwt.client.widgets.IButton;
import com.smartgwt.client.widgets.Window;
import com.smartgwt.client.widgets.events.ClickEvent;
import com.smartgwt.client.widgets.events.ClickHandler;
import com.smartgwt.client.widgets.form.fields.TextItem;
import com.smartgwt.client.widgets.grid.ListGrid;
import com.smartgwt.client.widgets.grid.ListGridField;
import com.smartgwt.client.widgets.layout.VLayout;

public class BuiltInDS extends VLayout implements EntryPoint {
    private IButton recreateBtn;

    public void onModuleLoad() {
        GWT.create(BeanFactory.FormItemMetaFactory.class);

        KeyIdentifier debugKey = new KeyIdentifier();
        debugKey.setCtrlKey(true);
        debugKey.setKeyName("D");

        Page.registerKey(debugKey, new PageKeyHandler() {
            public void execute(String keyName) {
                SC.showConsole();
            }
        });

        setWidth100();
        setHeight100();

        recreateBtn = new IButton("Recreate");
        recreateBtn.addClickHandler(new ClickHandler() {
            @Override
            public void onClick(ClickEvent event) {
                new MyWindow().show();
            }
        });
        addMember(recreateBtn);
        new MyWindow().show();
        draw();
    }

    private class MyWindow extends Window {
        public MyWindow() {
            setWidth(600);
            setHeight(300);
            setMembersMargin(0);
            setModalMaskOpacity(70);
            setTitle(" (" + Version.getVersion() + "/" + Version.getSCVersionNumber() + ")");
            setShowMinimizeButton(false);
            setIsModal(true);
            setShowModalMask(true);
            centerInPage();

            ListGridField commonNameLGF = new ListGridField("commonName");
            commonNameLGF.setFilterEditorProperties(new TextItem() {
                {
                    setBrowserSpellCheck(false);
                }
            });

            final ListGrid lg = new ListGrid();
            lg.setDataSource("animals");

            lg.setFields(commonNameLGF);
            AdvancedCriteria tmp = new AdvancedCriteria(new Criterion("commonName", OperatorId.STARTS_WITH, "A"));
            AdvancedCriteria managementClientAdvancedCriteria = new AdvancedCriteria(new Criterion("commonName", OperatorId.STARTS_WITH, "A"));
            tmp.addCriteria(managementClientAdvancedCriteria);
            lg.fetchData(tmp);

            Button openFilterButton = new Button("Open Filter");
            openFilterButton.addClickHandler(new ClickHandler() {
                @Override
                public void onClick(ClickEvent event) {
                    if (lg.getShowFilterEditor())
                        lg.setShowFilterEditor(false);
                    else
                        lg.setShowFilterEditor(true);
                }
            });

            addItem(openFilterButton);
            addItem(lg);
        }
    }
}

Best regards
Pavo

**Isomorphic** · 8 Feb 2019, 03:10

Thanks for the report - this has been fixed for builds dated February 9 and later.

**Blama** · 8 Feb 2019, 03:11

Hi Isomorphic,

here is a SmartClient sample based testcase (v12.0p_2019-02-07).
As written in #1 I do think the issue was introduced in beginning/mid of January.
Both AdvancedCriteria and browserSpellCheck: false seem to be necessary to trigger the issue.

Code:

isc.VStack.create({
    membersMargin: 30,
    width: "100%",
    height: "100%",
    members: [
        isc.IButton.create({
            title: "Filter",
            click: function() {
                dsListGrid.setShowFilterEditor(!dsListGrid.showFilterEditor);
            }
        }),
        isc.ListGrid.create({
            ID: "dsListGrid",
            width: "100%",
            height: "70%",
            autoFetchData: true,
            autoDraw: true,
            dataSource: "supplyItem",
            groupByField: "category",
            // Necessary            
            initialCriteria: {
                _constructor: "AdvancedCriteria",
                operator: "and",
                criteria: [{
                    fieldName: "SKU",
                    operator: "startsWith",
                    value: "1"
                }]
            },
            fields: [{
                    name: "itemID"
                },
                {
                    name: "itemName",
                    // Necessary            
                    filterEditorProperties: {
                        browserSpellCheck: false
                    }
                },
                {
                    name: "SKU"
                },
                {
                    name: "description"
                },
                {
                    name: "category"
                },
                {
                    name: "units"
                },
                {
                    name: "unitCost"
                },
                {
                    name: "inStock"
                },
                {
                    name: "nextShipment"
                },
                {
                    name: "buttonField",
                    title: "Info",
                    align: "center"
                },
                {
                    name: "iconField",
                    title: "Comments/Stats",
                    width: 110
                }
            ]
        })
    ]
});

Best regards
Blama

**Isomorphic** · 8 Feb 2019, 03:31

Thanks - this is addressed by the same change, which has been made today and will appear in builds dated February 9 and later (apologies, we accidentally referenced January 9 in our previous reply).

**Blama** · 11 Feb 2019, 00:11

Hi Isomorphic,

this is solved in the showcase for me using v12.0p_2019-02-09. I'll retest my application as well.

Best regards
Blama

Announcement

canEditCriterion infinite loop error in 12.0p_2019-01-23

Comment

Comment

Comment

Comment

Comment

Comment

Comment