Announcement

**kiipper** · 20 Mar 2019, 06:54

Hi guys,
it's been a while and I'm still have the same problem.
Do you have any feedback about this issue?
Do you need more information?

**Isomorphic** · 25 Mar 2019, 12:33

We are working on this and will update this thread when we have news. Thank you for your patience.

**Isomorphic** · 8 Apr 2019, 03:33

Apologies for the late response.

There's no need to subclass DataSource here and you are executing same request twice which is not recommended. Please consider using approach showed below.

There's operationBinding bound to serverObject with custom logic for "add" operation with operationId="customAdd". You may use operationAdd setting to customize operation that will be called for upload.
CustomDS is standalone class with customAdd microservice-like method. For every uploaded file it creates separate "add" request with no specific operationId, so it falls back to standard SQLDataSource behavior. Note how all responses are added as relatedUpdates to the main DSResponse, this will update caches for all data bound components on the client.
There''s also an optional transaction, so that if some of requests fail, all changes would be rolled back. Remove that if you don't need this behavior.

Code:

<DataSource 
   ID="images"
   tableName="images"
   serverType="sql">
   <fields>
      <field name="id" type="sequence" primaryKey="true"/>
      <field name="title" type="text"/>
      <field name="image" type="imageFile"/>
      <field name="image_thumbnail" type="imageFile"/>
   </fields>
   <operationBindings>
      <operationBinding operationType="add" operationId="customAdd">
         <serverObject className="com.isomorphic.test.CustomDS" lookupStyle="new" methodName="customAdd"/>
      </operationBinding>
   </operationBindings>
</DataSource>

Code:

public class CustomDS {

    private static final float THUMBNAIL_SIZE = 200f;

    public DSResponse customAdd(DSRequest dsRequest) throws Exception {
        // start transaction
        DSTransaction tran = new DSTransaction();
        dsRequest.setDsTransaction(tran);

        DSResponse resp = new DSResponse();
        byte[] imageData;
        String filename;
        if (dsRequest.getUploadedFiles() != null) {
            ArrayList<ISCFileItem> fileList = new ArrayList(dsRequest.getUploadedFiles());
            for (int f = 0; f < fileList.size(); f++) {
                ISCFileItem fileItem = fileList.get(f);
                //final ISCFileItem fileItem = dsRequest.getUploadedFile("image");
                imageData = fileItem.get();
                filename = fileItem.getFileName(); //All file names come here in the same string. (ex. "filename1.png, filename2.png, filename3.png")

                final Map<String, Object> imageValues = dsRequest.getValues();
                int i = -1;
                i = Math.max(i, filename.lastIndexOf('\\'));
                i = Math.max(i, filename.lastIndexOf('/'));
                filename = filename.substring(i + 1);
                filename = filename.replaceAll("[^\\x00-\\x7F]", "");
                filename = filename.split(",")[f].trim();
                imageValues.put("image_filename", filename);
                imageValues.put("image", new ByteArrayInputStream(imageData));
                imageValues.put("image_date_created", new Date());
                imageValues.put("image_filesize", imageData.length);

                DSResponse relatedResponse = null;
                try {
                    BufferedImage bImage = ImageIO.read(new ByteArrayInputStream(imageData));
                    if (bImage != null) {
                        int w = bImage.getWidth();
                        int h = bImage.getHeight();
                        float ratio = (float) THUMBNAIL_SIZE / (float) Math.max(w, h);
                        w = (int) (w * ratio);
                        h = (int) (h * ratio);

                        // Create a buffered image with transparency
                        Image img = bImage.getScaledInstance(w, h, Image.SCALE_SMOOTH);
                        BufferedImage image_thumbnail = new BufferedImage(img.getWidth(null), img.getHeight(null), BufferedImage.TYPE_INT_ARGB);
                        // Draw the image on to the buffered image
                        Graphics2D bGr = image_thumbnail.createGraphics();
                        bGr.drawImage(img, 0, 0, null);
                        bGr.dispose();

                        ByteArrayOutputStream baos = new ByteArrayOutputStream();
                        ImageIO.write(image_thumbnail.getSubimage(0, 0, w, h), "png", baos);
                        byte thumbData[];
                        thumbData = baos.toByteArray();
                        //thumbData = org.apache.commons.codec.binary.Base64.encodeBase64(baos.toByteArray());

                        imageValues.put("image_thumbnail", new ByteArrayInputStream(thumbData)); //You could use anything to test here, the problem persists (ex. new ByteArrayInputStream("some data".getBytes())
                        imageValues.put("image_thumbnail_filename", "tb_" + filename);
                        imageValues.put("image_thumbnail_date_created", new Date());
                        imageValues.put("image_thumbnail_filesize", thumbData.length);
                    }

                    // create and execute related request in the same transaction
                    DSRequest relatedRequest = new DSRequest(dsRequest.getDataSource(), "add");
                    relatedRequest.setDsTransaction(tran);
                    relatedRequest.setValues(imageValues);
                    relatedResponse = relatedRequest.execute();

                } catch (NullPointerException | IOException ex) {
                    Logger.getLogger(this.getClass()).log(Level.ERROR, ex);
                    // create failed related response
                    relatedResponse = new DSResponse();
                    ErrorReport er = new ErrorReport();
                    er.addError("image", ex.getMessage());
                    relatedResponse.setErrorReport(er);
                } finally {
                    // add related response to main response
                    resp.addRelatedUpdate(relatedResponse);
                }
            }
        }

        // commit or rollback transaction
        tran.complete();

        return resp;
    }

}

**kiipper** · 10 Apr 2019, 12:57

Thank you, Isomorphic.
It took some time... but it worked like a charm! :D

The approach to call the method under the operationBinding is way better than extends SQLDataSource.
We did not realized that it was calling twice.
This could be a nice example (and best practice) to be included in future EE showcase.

Announcement

Multiple File Upload Bug

Comment

Comment

Comment

Comment