12.1p: Form item tabbing broken with synthetic focus events

[markok]

Hi,

We have a strange form tabbing problem when we layout our DynamicForms in Window body. We tracked the problem down to the fact that when a click mask is showing (Window triggers this), form item focus is handled via synthetic events which seem to handle !canEdit items a bit badly.

v12.1p_2021-08-19/LGPL Development Only (built 2021-08-19)

Reproduce with the following snippet:

        viewport = new VLayout();
        viewport.setWidth100();
        viewport.setHeight100();

        FormItem fi = new FormItem();
        fi.setReadOnlyDisplay(ReadOnlyDisplayAppearance.DISABLED);
        FormItem.setDefaultProperties(fi);

        DynamicForm f = new DynamicForm();

        TextItem i1 = new TextItem();
        TextItem i2 = new TextItem();
        SelectItem i3 = new SelectItem();
        DateTimeItem i4 = new DateTimeItem();
        i4.setUseTextField(true);
        i4.setCanEdit(false);
        SelectItem i5 = new SelectItem();
        i5.setCanEdit(false);
        SelectItem i6 = new SelectItem();
        SelectItem i7 = new SelectItem();
        SelectItem i8 = new SelectItem();
        i8.setCanEdit(false);
        TextItem i9 = new TextItem();
        TextItem i10 = new TextItem();

        f.setItems(i1, i2, i3, i4, i5, i6, i7, i8, i9, i10);

        viewport.addMember(f);
        viewport.draw();

        // simulate window open et al, showing a clickmask makes the use of syntheticShiftFocus and breaks down tabbing for
        // !canEdit items
        viewport.showClickMask(null, ClickMaskMode.HARD, new Canvas[] { f });

Focus an item, use tab & shift-tab to change item focus. Note that for !canEdit fields are not skipped and focus gets stuck.

[Isomorphic]

Thanks for the notification and clear test case

We've made a change to address this issue. Please try the next nightly build, dated September 15 or above