Announcement

**tholmes66** · 11 Nov 2013, 12:54

RestDataSource transformResponse is broken

Well ... I doubt Isomophic will admit it, but it seems that the transformResponse of a RestDataSource is broken.

Here is a simple test app:

Code:

public class TestApp implements EntryPoint
{
    private DataSourceIntegerField userIdField;

    public void onModuleLoad()
    {
    RestDataSource dataSource = new RestDataSource();
    dataSource.setDataFormat(DSDataFormat.JSON);
    dataSource.setDataURL("data/single_user.json");

    // set the values for the datasource
    userIdField = new DataSourceIntegerField("userId", "User Id");
    userIdField.setPrimaryKey(true);
    userIdField.setCanEdit(false);

    dataSource.setFields(userIdField);

    ListGrid grid = new ListGrid();
    grid.setDataSource(dataSource);
    grid.setWidth100();
    grid.setHeight(150);
    grid.setAutoFetchData(true);
    grid.draw();
    }
}

The single_user.json looks like:
{"userId":1} or {"userId":"1"}
This is as simple as it gets, and this is corect JSON.

The error message that I reported comes up again:

Code:

15:35:40.181 [ERROR] [SoccerAdmin]
15:35:40.179:XRP7:WARN:RestDataSource:restUserDS:RestDataSource
transformResponse(): JSON response text is incorrectly formatted as an Array rather than a simple response object.

com.smartgwt.client.core.JsObject$SGWT_WARN: 
15:35:40.179:XRP7:WARN:RestDataSource:restUserDS:RestDataSource
transformResponse(): JSON response text is incorrectly formatted as an Array rather than a simple response object.
     at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
Method)
     at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
     at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
     at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
     at
com.google.gwt.dev.shell.MethodAdaptor.invoke(MethodAdaptor.java:105)
     at
com.google.gwt.dev.shell.MethodDispatch.invoke(MethodDispatch.java:71)
     at
com.google.gwt.dev.shell.OophmSessionHandler.invoke(OophmSessionHandler.java:172)
     at
com.google.gwt.dev.shell.BrowserChannelServer.reactToMessagesWhileWaitingForReturn(BrowserChannelServer.java:338)
     at
com.google.gwt.dev.shell.BrowserChannelServer.invokeJavascript(BrowserChannelServer.java:219)
     at
com.google.gwt.dev.shell.ModuleSpaceOOPHM.doInvoke(ModuleSpaceOOPHM.java:136)
     at
com.google.gwt.dev.shell.ModuleSpace.invokeNative(ModuleSpace.java:571)
     at
com.google.gwt.dev.shell.ModuleSpace.invokeNativeVoid(ModuleSpace.java:299)
     at
com.google.gwt.dev.shell.JavaScriptHost.invokeNativeVoid(JavaScriptHost.java:107)
     at
com.smartgwt.client.data.DataSource.transformResponse(DataSource.java)
     at
com.medenasoft.products.soccer.admin.client.datasource.UserDataSource.transformResponse(UserDataSource.java:211)
     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
     at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
     at java.lang.reflect.Method.invoke(Method.java:597)
     at
com.google.gwt.dev.shell.MethodAdaptor.invoke(MethodAdaptor.java:103)
     at
com.google.gwt.dev.shell.MethodDispatch.invoke(MethodDispatch.java:71)
     at
com.google.gwt.dev.shell.OophmSessionHandler.invoke(OophmSessionHandler.java:172)
     at
com.google.gwt.dev.shell.BrowserChannelServer.reactToMessagesWhileWaitingForReturn(BrowserChannelServer.java:338)
     at
com.google.gwt.dev.shell.BrowserChannelServer.invokeJavascript(BrowserChannelServer.java:219)
     at
com.google.gwt.dev.shell.ModuleSpaceOOPHM.doInvoke(ModuleSpaceOOPHM.java:136)
     at
com.google.gwt.dev.shell.ModuleSpace.invokeNative(ModuleSpace.java:571)
     at
com.google.gwt.dev.shell.ModuleSpace.invokeNativeObject(ModuleSpace.java:279)
     at
com.google.gwt.dev.shell.JavaScriptHost.invokeNativeObject(JavaScriptHost.java:91)
     at com.google.gwt.core.client.impl.Impl.apply(Impl.java)
     at com.google.gwt.core.client.impl.Impl.entry0(Impl.java:242)
     at sun.reflect.GeneratedMethodAccessor55.invoke(Unknown Source)
     at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
     at java.lang.reflect.Method.invoke(Method.java:597)
     at
com.google.gwt.dev.shell.MethodAdaptor.invoke(MethodAdaptor.java:103)
     at
com.google.gwt.dev.shell.MethodDispatch.invoke(MethodDispatch.java:71)
     at
com.google.gwt.dev.shell.OophmSessionHandler.invoke(OophmSessionHandler.java:172)
     at
com.google.gwt.dev.shell.BrowserChannelServer.reactToMessages(BrowserChannelServer.java:293)
     at
com.google.gwt.dev.shell.BrowserChannelServer.processConnection(BrowserChannelServer.java:547)
     at
com.google.gwt.dev.shell.BrowserChannelServer.run(BrowserChannelServer.java:364)
     at java.lang.Thread.run(Thread.java:662)

The break is always in the super.transformResponse line. The fix was to change this to a regular "DataSource" and that fixed my issue.

I am using Spring MVC 3.2, and I know my controllers are well tested and always return JSON. My springmvc-servlet.xml uses the com.fasterxml.jackson.core 2.2.3 to automatically transform anything coming from my controller to JSON. I know this is valid JSON and I have several use cass where this JSON is converted back into an Object on the SmartGWT client-side.

Just an FYI, I had a previous basic application which worked great with super.transformResponse in a RestDataSource. I copied this configuration over to a new app, and presumed it would work the same, but it didn't. Then I went back to the original app, re-compiled and re-ran, and realized I was getting the same error.

I hope this helps someone else fix this issue.

Announcement

Bas TransformResponse and correct JSON being reported as bad

Comment