Bugs in Calendar-Widget of SmartGWT 5.0 (build 03.04.2014)

[peterpan12344]

Dear Isomorphic,

There seam to be a couple of bugs in the Calendar-Widget of SmartGWT 5.0 (build 03.04.2014). Taking the ShowCase that ships with it 'Workday Calendar' in Week-View:

1. Creating a new Event by clicking on lets say 10:00am will create an event for 11:00am (1 hour offset)
2. When setting setScrollToWorkday(true) the marked Workday shows also the 1 hour offset.

Is that intended?

[Isomorphic]

No - we'll take a look

[Isomorphic]

The week you viewed happened to include the crossover to Daylight Saving Time, and we had a bug in the way we were pre-calculating cell-dates in that case.

We've reworked the code in this area to deal with DST better - now, all the cell dates are correct, and you can no longer create an event in the time that is lost due to DST because the cells are disabled.

Please retest with a build dated April 10 or later - and be sure to navigate to the week showing your DST date for a proper test.

[Isomorphic]

Actually, when we said "you can no longer create an event in the time that is lost due to DST because the cells are disabled", this is not actually true in 9.1.

For 9.1, the issue of cell-dates being wrong in this case is fixed, but the DST crossover hour is not disabled. If you click in those cells, we'll do what other popular software like Google Calendar does - a new event will be created at one of the surrounding times, depending on where you click.

In 10.0 and later, DST crossover cells are disabled as we said - but 9.1 uses a different mechanism and the change is too big to port to a live branch.

Incidentally, calendars and timelines have undergone some deep reworking in 10.0, with many new features added - so you might want to take a look if you need a richer feature set

[Isomorphic]

Another update - in fact, we found a less intrusive way to support disabling the DST crossover time in 9.1. So that will be available in the builds we mentioned earlier.

[peterpan12344]

Some more minor changes needed ;-)

Dear Isomorphic,

Thank you for the update. I have discovered 2 other minor bugs in the latest build:

1. when the Calendar-Widget is setup with setEventDragGap(0), moving/reposition an event will cause the End-Date to always convert to 23h59

2. When setting the Workday via setWorkdayStart and setWorkdayEnd, the shown workday is missing some (1?) hour(s).

final Calendar calendar = new Calendar();

calendar.setTimeFormatter(TimeDisplayFormat.TOSHORT24HOURTIME);
calendar.setDateFormatter(DateDisplayFormat.TOEUROPEANSHORTDATE);

calendar.setShowWorkday(true);
calendar.setShowWeekends(false);
calendar.setWorkdayStart("7:00");
calendar.setWorkdayEnd("19:00");
calendar.setScrollToWorkday(true);

calendar.setEventOverlap(false);
calendar.setEventOverlapIdenticalStartTimes(true);
calendar.setEventDragGap(0);

[Isomorphic]

Have you updated to the very latest build from smartclient.com/builds? If not, please do so before testing any further. If so, please show the version string for your build.

[peterpan12344]

Yes, I took the latest build:
http://www.smartclient.com/builds/SmartGWT/5.0d/LGPL/2014-04-12

[Isomorphic]

1) is fixed - 2) is in the queue to be looked at, no ETA as yet.

For 1), please retest with a build dated April 17 or later.

[larcman]

Hi Isomorphic,

Could I see which files changed with this fix? So I can take only these ones?
I'm struggling a lot trying to update all the build version. So, what if I just take the fixed files?

Any help will be appreciated.
Thanks

[larcman]

Any update on this request Isomorphic?
Do you think it is possible to get only this fix?

Thanks