Problem after file uploads - endless loop issue

[mark1]

Problem after file uploads - endless loop issue

v10.0p_2014-11-08/Pro Deployment (built 2014-11-08)



This appears to have started in the release from '2014-11-01' with changes to 'ISC_DataBinding.js'.

The section that keeps calling itself is below:

         // If a form contains a FileItem, the request submitted to the server originates from
         // an inner form that wraps the native "upload" component in order to prevent redraws
         // from clearing the upload value.  For this reason, the callback to sync the server's
         // response data will be invoked on this inner form, which is meaningless.  Therefore,
-        // intercept this case and hand the callback to the parent form.
-        if (isc.isA.DynamicForm(this.fileItemFormParentForm)) {
-            this.fileItemFormParentForm._saveDataReply(request, response, data);
+        // intercept this case and hand the callback to the parent form (or valuesManager).
+        var clientContext = request.clientContext;
+        if (clientContext && clientContext.saveDataTarget != null) {
+            clientContext.saveDataTarget._saveDataReply(request, response, data);
         }

Google Chrome - OS X - Version 38.0.2125.111 = Uncaught RangeError: Maximum call stack size exceeded

Firefox - OS X - v 32.0.3 - logs = too much recursion



Please let me know if a test case would help, but I am pretty sure the showcase will one day present the same problem in the link below: (when the SmartGWT version has been updated past [2014-11-01].

http://www.smartclient.com/smartgwtee/showcase/#upload_sql



Stack trace:

isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2269

...... goes on forever.

[edulid]

Where do you see these logs? In the developer console? Just to know if your issue was affecting my appication, I tested the file upload in my application, and the file upload is not working! But I don't see any logs in the developer console.

"It is not working" means that the upload never finishes. The application shows my "file uploading, please wait..." window for ever ....

So this seems to be affecting the 4.1p branch too.

Using smartGWT 4.1p Version: v9.1p_2014-11-06/PowerEdition Deployment (built 2014-11-06)

[mark1]

It could possibly be related ... I first noticed the issue because the datasource callback is never fired - maybe your application relies on the callback to know when the upload is complete ?

The best way to tell for sure would be to download the v4.1 release for the date - 2014-10-29 .. and see if it fixes things ... it does for me.

Yes, in my system the messages are being logged in the developer console - In chrome the 'Console Tab' under 'Developer Tools'.

[edulid]

With "developer console" I meant the smartGwt developer console. But you are right, the chrome console shows this error for me too.

Isomorphic ? Please correct this bug.

Uncaught RangeError: Maximum call stack size exceeded ISC_DataBinding.js:2238isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2238isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2238isc.EditorActionMethods.addInterfaceMethods.$49z ISC_DataBinding.js:2238isc.EditorActionMethods.addInterfaceMethods.$49z

[Isomorphic]

This is currently under investigation as a high priority issue. We should have an update soon.

Regards
Isomorphic Software

[Isomorphic]

We've made a change to address this issue and removed all packages from our site which contain this regression.
A new build will be available, in a few hours (dated either Nov 8 or Nov 9)

Regards
Isomorphic Software

[mark1]

That has fixed things for me.

Thanks for getting it sorted so quickly. :)