skin change not working?

[itb]

Hi,

we recently replaced the smartGWT library we were using to 5.0p (nightly build). We noticed that our application, which uses the EnterpriseBlue skin, is now rendering in the default Enterprise skin. I also noticed that the skin picker in the showcase (http://www.smartclient.com/smartgwt/showcase) no longer seems to change the skin. Is this a bug, is there something changed in the way to pick a skin, or are there plans to discontinue the EnterpriseBlue skin?

thanks,
ITB

[Isomorphic]

No, EnterpriseBlue is not being phased out, and from a brief test the skin switcher in the Showcase works fine.

Most likely you did not change your skin correctly, or changed .gwt.xml but neglected to run a GWT compile after the change. The instructions for changing skin correctly are in the QuickStart Guide.

[itb]

Hi Isomorphic,

we tried on several machines and browsers, the skinpickers in the smartclient showcases do work, but the one on the smartGWT showcase doesn't. It does reload the page, but serves the Enterprise skin no matter which value we pick. Same goes for our application, we have been using EnterpriseBlue for years now and have not changed any code with regard to loading the skin. We just upgraded the smartGWT and smartGWT skins jar and it now serves the default Enterprise skin instead of the Enterprise Blue. FYI we do not change skin, just staticly load the EnterpriseBlue skin.

Just to verify - did you test the picker on the smartGWT showcase at the URL I mentioned in my previous post( http://www.smartclient.com/smartgwt/showcase )?

thanks,
ITB

[Blama]

Hello,

I'm seeing the same behaviour itb is seeing using Win7 IE11 and FF33.1.1.

One GET (200) goes to

http://www.smartclient.com/smartgwt/showcase/isc_ts-2014-11-25/showcase/sc/skins/EnterpriseBlue/load_skin.js?isc_version=10.0.js

and the second GET (304) goes to
http://www.smartclient.com/smartgwt/showcase/showcase/sc/skins/Enterprise/load_skin.js

Best regards,
Blama

[Isomorphic]

Hello,

I'm seeing the same behaviour itb is seeing using Win7 IE11 and FF33.1.1.

One GET (200) goes to

http://www.smartclient.com/smartgwt/...ersion=10.0.js

and the second GET (304) goes to
http://www.smartclient.com/smartgwt/...e/load_skin.js

Best regards,
Blama

The isc_ts-2014-11-25 in the path is something unique for the www-deployed showcases on our website. That won't ever (or shouldn't ever) be present in anything you can download.

[Blama]

Hi Isomorphic,

please not that one path includes EnterpriseBlue while the other includes Enterprise.

Best regards,
Blama

[itb]

Hi Isomorphic, Blama,

Thanks Blama for looking into this. Checked some more and this seems to be the problem on our application as well. With the previous version of smartGWT.jar (4.1) it loads only 1 load_skin.js file, sc/skins/EntepriseBlue/load_skin.js. With the new version of smartGWT.jar, it also loads this file, but shortly after it loads the default skin (sc/skins/Enterprise/load_skin.js), probably overwriting all css just loaded by Enterprise Blue with the default version. As I said, we only load the Enterprise Blue load_skin.js explicitly in our HTML file, there is no mention of the Enterprise version in our code. It seems to be added by some code in the new smartGWT jar?

thanks,
ITB

[Isomorphic]

Hi Isomorphic,

please not that one path includes EnterpriseBlue while the other includes Enterprise.

Best regards,
Blama

Thanks, we've updated the response - however the dated path is still specific to the website.

We're investigating the issue and will update this thread.

[Isomorphic]

We believe we've found the issue and it will be fixed in the next nightlies (only SGWT 5.1d and 5.0p affected). A workaround may be to inherit SmartGwtNoScriptNoTheme rather than SmartGwtNoScript, and should work if your project is already pulling in the skin files through another module dependency (e.g. SmartGwtTools).

[itb]

Hi Isomorphic,

I downloaded the nightly (2014-11-27) and redeployed. With the

<inherits name="com.smartgwt.SmartGwtNoScript" />

it still downloads a second load_skin.js from the Enterprise skin. When changing to

<inherits name="com.smartgwt.SmartGwtNoScriptNoTheme" />

The second call is gone and the skin renders correctly.

[Isomorphic]

It appears the changes weren't picked up for yesterday's build, but they should be in today's. They have been deployed, as you can see:

http://www.smartclient.com/smartgwt/showcase/#main

[Isomorphic]

The 2014-11-28 SC 10.0p/SGWT 5.0p builds should be available now.