Announcement

**SCAI_Andre** · 11 Jan 2015, 03:50

gwt.xml

Let me add the gwt.xml, too. The forum only allows 5 attachments per post.

There are a few legacy comments there since it is copied from another project, but it makes the test case complete.

Attached Files

smartgwtBugReport.gwt.xml (1.4 KB, 124 views)

**SCAI_Andre** · 12 Jan 2015, 01:45

Forgot: The problem occurs in the LGPL version

**Isomorphic** · 12 Jan 2015, 05:32

Your use of a GwtRpcDataSource as well as leaving in place a bunch of unrelated code makes this a pointlessly overcomplicated test case and introduces the possibility that the flaw is actually somewhere in your DataSource implementation or other extra code.

If you hope to see this report looked at quickly, follow the rules and make your test minimal: use an actual clientOnly DataSource and delete the extra code. The whole thing should fit neatly into one .java file and not require any setup beyond dropping it into one of the sample projects - that's what's meant by a test case.

**SCAI_Andre** · 12 Jan 2015, 06:25

Code:

wrong code removed

**SCAI_Andre** · 12 Jan 2015, 09:09

Damn, just noticed I f**d up the copy & paste so plz ignore the code above

Bad day

**SCAI_Andre** · 12 Jan 2015, 09:24

In the previous post I still extended the wrong datasource, even though that only needed to be changed to DataSource.

Anyway, here is the simplified, one class, hopefully now unpointless test case.

The gwt.xml now refers to a different EntryPoint, but I guess that is not a problem, since that file wasn't necessary anyway, as I learnt now.

Code:

package de.scai.client.ticket1445.defect;

import com.google.gwt.core.client.EntryPoint;
import com.google.gwt.core.client.GWT;
import com.google.gwt.user.client.ui.RootPanel;
import com.smartgwt.client.data.DSCallback;
import com.smartgwt.client.data.DSRequest;
import com.smartgwt.client.data.DSResponse;
import com.smartgwt.client.data.DataSource;
import com.smartgwt.client.data.fields.DataSourceIntegerField;
import com.smartgwt.client.data.fields.DataSourceTextField;
import com.smartgwt.client.util.SC;
import com.smartgwt.client.widgets.Button;
import com.smartgwt.client.widgets.events.ClickEvent;
import com.smartgwt.client.widgets.events.ClickHandler;
import com.smartgwt.client.widgets.form.DynamicForm;
import com.smartgwt.client.widgets.form.ValuesManager;
import com.smartgwt.client.widgets.form.fields.ComboBoxItem;
import com.smartgwt.client.widgets.form.fields.IntegerItem;
import com.smartgwt.client.widgets.grid.ListGridRecord;
import com.smartgwt.client.widgets.layout.Layout;
import com.smartgwt.client.widgets.layout.VLayout;

public class DemoTicket1445 implements EntryPoint {

    private Layout layoutRoot;
    /**
     * This is the entry point method.
     */
    public void onModuleLoad() {
        layoutRoot = new VLayout();

        RootPanel.get("gwtContainer").add(layoutRoot);

        run();
    }

    private class UserDataSource extends DataSource {
        public static final String FIELDNAME_ID = "FIELD_id";
        public static final String FIELDNAME_GROUPID = "FIELD_groupId";
        public static final String FIELDNAME_WAGE = "FIELD_wage";

        protected DataSourceIntegerField id = new DataSourceIntegerField(FIELDNAME_ID, "Id");
        protected DataSourceIntegerField groupId = new DataSourceIntegerField(FIELDNAME_GROUPID, "Group");
        protected DataSourceIntegerField wage = new DataSourceIntegerField(FIELDNAME_WAGE, "Wage");

        private UserDataSource() {
            super();
            id.setPrimaryKey(true);
            addField(id);
            addField(groupId);
            addField(wage);
            setClientOnly(true);
            setCacheAllData(true);
        }

    }

    private class GroupDataSource extends DataSource {
        public static final String FIELDNAME_ID = "FIELD_id";
        public static final String FIELDNAME_GROUPNAME = "FIELD_groupName";

        protected DataSourceIntegerField id = new DataSourceIntegerField(FIELDNAME_ID, "Id");
        protected DataSourceTextField groupName = new DataSourceTextField(FIELDNAME_GROUPNAME, "Groupname");

        private GroupDataSource() {
            super();
            setFields(id, groupName);

            setClientOnly(true);
            setCacheAllData(true);
            initData();
        }

        public void initData() {
            final int recordCount = 5;
            final ListGridRecord[] data = new ListGridRecord[recordCount];
            for (int i = 0; i <= recordCount; i++) {
                ListGridRecord listGridRecord = new ListGridRecord();
                listGridRecord.setAttribute(FIELDNAME_ID, i);
                listGridRecord.setAttribute(FIELDNAME_GROUPNAME, "dummyGroup"+ Integer.toString(i));
                data[i] = listGridRecord;
            }
            setCacheData(data);
        }
    }

    private class UserDynamicForm extends DynamicForm {
        protected ComboBoxItem groupName = new ComboBoxItem(UserDataSource.FIELDNAME_GROUPID, "Groupname");
        protected IntegerItem wage = new IntegerItem(UserDataSource.FIELDNAME_WAGE, "Wage");

        protected void setComboBox(ComboBoxItem comboBoxItem, DataSource dataSource, String valueField, String displayField) {
            dataSource.setShowPrompt(false);
            comboBoxItem.setOptionDataSource(dataSource);

            comboBoxItem.setValueField(valueField);
            comboBoxItem.setDisplayField(displayField);
        }

        public void initForm(GroupDataSource groupDataSource) {
            setComboBox(groupName, groupDataSource, GroupDataSource.FIELDNAME_ID, GroupDataSource.FIELDNAME_GROUPNAME);

            this.setFields(
                    groupName
                    , wage
            );
        }
    }

    private GroupDataSource groupDataSource;
    private UserDataSource userDataSource;
    private ValuesManager valuesManager;
    private UserDynamicForm userDynamicForm;

    public void run() {

        userDataSource = new UserDataSource();
        groupDataSource = new GroupDataSource();

        valuesManager = new ValuesManager();
        valuesManager.setDataSource(userDataSource);

        initForm();

        Layout layout = new VLayout();
        layout.addMember(userDynamicForm);
        layoutRoot.addMember(layout);

        Button save = new Button("Save");
        save.addClickHandler(new ClickHandler() {
            @Override
            public void onClick(ClickEvent clickEvent) {
                if (valuesManager.validate()) {
                    GWT.log(valuesManager.getChangedValues().toString());
                    if (valuesManager.getChangedValues().size() == 0) {
                        SC.warn("No changed values");
                    }
                    valuesManager.saveData(new DSCallback() {
                        @Override
                        public void execute(DSResponse dsResponse, Object o, DSRequest dsRequest) {
                            GWT.log("dsResponse.result is: " + Integer.toString(dsResponse.getStatus()));
                        }
                    });
                }
            }
        });
        layout.addMember(save);

        valuesManager.addMember(userDynamicForm);
        valuesManager.editNewRecord();
    }

    private void initForm() {
        userDynamicForm = new UserDynamicForm();
        userDynamicForm.initForm(groupDataSource);
        userDynamicForm.setDataSource(userDataSource);
    }

}

**Isomorphic** · 13 Jan 2015, 14:47

Thanks for the simplified test case, that helps a lot in terms of pinning down the bug.

This is fixed for affected builds - grab the next nightly for the fix.

**SCAI_Andre** · 14 Jan 2015, 04:24

tested nightly 5.0p/LGPL/2015-01-14:
can confirm it is fixed

Thank you!

Announcement

Scary bug (test case included): ComboBoxItem silently discarding values in > 5.0p

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment