Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

    #46
    Originally posted by Isomorphic View Post
    We've made a couple of minor framework changes:
    - we are now re-using IDs for automatically created components. In other words once an automatically generated Tab with ID "isc_Tab_5" (for example) is destroyed, the ID will be re-used and applied to a new tab. This will prevent us from creating thousands of null slots in the case where you saw this.
    - we also are deleting the variable names from destroyed widgets rather than simply setting them to null, where this is possible (this is not supported in all browsers - for example Internet Explorer 8 throws an error if you attempt this).

    In our testing this gets rid of the problem you're describing in the Add / Remove tabs sample. We are no longer seeing a small slow memory leak in this sample.
    You can pick up the next nightly build to test this (dated Feb 14 or above).

    This may resolve the issues you're seeing in your application as well, but if, in a real world usage, you're seeing significant memory leakage, it still seems quite likely that some more significant objects are being retained in memory than just the ID strings.
    We'd recommend you re test with the new SmartClient / SmartGWT libraries tomorrow regardless. If the problem persists, this may still be an application level issue (not allowing some local references to created objects to go out of scope), or possibly a framework issue, but to comment further we'll need more information.

    One aside - if you haven't already, we'd recommend you do perform a real-world test with firebug not running to see if the memory is growing incrementally without ever being reclaimed in a "real world setup".
    To exit firebug, you need to close firebug, then close, then reopen firefox -- firebug is not fully closed unless you restart the browser)

    Regards
    Isomorphic Software
    Hello Isomorphic, based on the fixed for about, I have download the SmartGWT Power Edition BUILD 2015-02-21 (latest version) and apply onto my existing application which is well tested and work normally under SmartClient Version: v9.1p_2014-03-04/PowerEdition Deployment (built 2014-03-04) (exception have memory leakage issue).

    However I find the exception as attached image. I want to ask


    1. can you provide a version of fixing on object leakage based on SmartGWT Power Edition BUILD 2014-03-04?
    2. please advice any code change required if we upgrade the SmartGWT framework for same version 4.1p Power Edition but only from 2014-03-04 to 2015-02-21 (which is the latest and including the fix).
    Attached Files

    Comment


      #47
      1. No. As previously discussed, this is not possible and would also be useless even if it were possible.

      2. This stack trace appears to show your own code crashing, specifically, code in a fetchData() callback method. It looks like you may have been assuming that a call to getAttributeAsBoolean() would always return non-null.

      It's not clear whether there is actually a difference in framework behavior, or whether you inadvertently changed something else in your environment while updating SmartGWT, or whether you have a longstanding usage error. You should troubleshoot the issue, and let us know if you isolate something that appears to be a framework issue. If you do follow up with us, remember to post all required diagnostics.

      Comment


        #48
        Originally posted by Isomorphic View Post
        2. This stack trace appears to show your own code crashing, specifically, code in a fetchData() callback method. It looks like you may have been assuming that a call to getAttributeAsBoolean() would always return non-null.

        It's not clear whether there is actually a difference in framework behavior, or whether you inadvertently changed something else in your environment while updating SmartGWT, or whether you have a longstanding usage error. You should troubleshoot the issue, and let us know if you isolate something that appears to be a framework issue. If you do follow up with us, remember to post all required diagnostics.
        Everything is same except the jar library that is bundled in SmartGWT zip from smartclient.com, so it should be caused by the new code between BUILD 2014-03-04 and 2015-02-21.
        We don't expect to have change on existing application code that is worked on BUILD 2014-03-04 but not work after upgraded to BUILD 2015-02-21.
        Otherwise, please advice what's the code change required if for this upgrade.



        So what is code change in this two builds? Also what's the recommended code impact analysis for smartgwt application?
        Last edited by wing.t.lee; 25 Feb 2015, 19:57.

        Comment


          #49
          Assuming all of your code represents valid usage (a big assumption), you should not need to change any framework code when you upgrade. There were no intentional changes to the library which would have required changes to your code.

          Now please re-read our previous statement:

          It's not clear whether there is actually a difference in framework behavior, or whether you inadvertently changed something else in your environment while updating SmartGWT, or whether you have a longstanding usage error. You should troubleshoot the issue, and let us know if you isolate something that appears to be a framework issue. If you do follow up with us, remember to post all required diagnostics.

          Comment

          Working...
          X