Small BuiltInDS sample change (sql.useAnsiJoins: true)

[Blama]

Hi Isomorphic,

could you add the following line to BuiltInDS's server.properties (v10.0p_2015-05-19):

sql.useAnsiJoins: true

Because without, for HSQLDB there are no outer joins generated in e.g. this case

animals.ds.xml change/addition:

		<field name="lifeSpan" title="Life Span" type="integer" foreignKey="employees.EmployeeId" joinType="outer" />
		<field name="EmployeeName" includeFrom="employees.Name" />

This would make creating testcases involving joins way more easy.

Best regards
Blama

[Isomorphic]

Sorry, no. The first purpose of the samples is educational, we will not be adding anything along these lines.

[Blama]

Hi Isomorphic,

sorry, I wasn't clear. I meant just the one line in server.properties.

Without it, a user that wanted to extend the sample on its own, would not be able to generate outer joins.

The .ds.xml-changes I gave were to show you the kind of wrong behaviour I meant. Change these lines, do not set useAnsiJoins and you'll see in the generated SQL that there is no JOIN (and also no =(+) (the old Oracle outer join syntax) or the like).

Best regards
Blama

[Isomorphic]

DataSourceField.joinType is already documented as only working with some combinations of database types and settings for sql.useAnsiJoins.

We have no plans to change the default setting for sql.useAnsiJoins for the framework as a whole, and it definitely wouldn't make sense to modify this setting for a sample that doesn't demonstrate anything that requires ANSI joins.

[Blama]

Hi Isomorphic,

you are right, DataSourceField.joinType does cover this.

I'll just have to set that setting then when generating a testcase depending on outer join. Until today I did not realize that I have to set it, because in my project I did quite a time ago and forgot about it.

Best regards
Blama