TextItem.setSelectOnClick(Boolean selectOnClick) is not working on SmartGWT 5

[ionut.ursuleanu]

Hi,

The following code worked on SmartGWT 4 (build 2013-07-07 LGPL), but on SmartGWT 5 (build 2015-08-13) setSelectOnClick doesn't seem to have any effect on text items.

package com.smartgwt.sample.showcase.client.forms;

import com.smartgwt.client.util.SC;
import com.smartgwt.client.widgets.Canvas;
import com.smartgwt.client.widgets.form.DynamicForm;
import com.smartgwt.client.widgets.form.fields.ButtonItem;
import com.smartgwt.client.widgets.form.fields.TextItem;
import com.smartgwt.client.widgets.form.fields.events.ClickEvent;
import com.smartgwt.client.widgets.form.fields.events.ClickHandler;
import com.smartgwt.sample.showcase.client.PanelFactory;
import com.smartgwt.sample.showcase.client.ShowcasePanel;

public class FormFocusFirstSample extends ShowcasePanel {
    private static final String DESCRIPTION = "<p>Setting the focus / cursor on the first field of a form is common requirement. Doing this in Smart GWT is as simple as setting <code>form.setAutoFocus(true)</code>.</p>" +
            "<p>This sample also has <code>setSelectOnFocus(true)</code> on the first field.</p>";

    public static class Factory implements PanelFactory {
        private String id;

        public ShowcasePanel create() {
            FormFocusFirstSample panel = new FormFocusFirstSample();
            id = panel.getID();
            return panel;
        }

        public String getID() {
            return id;
        }

        public String getDescription() {
            return DESCRIPTION;
        }
    }

    public Canvas getViewPanel() {

        final DynamicForm form = new DynamicForm();
        form.setAutoFocus(true);
        form.setNumCols(3);
        form.setWidth(300);

        TextItem firstName = new TextItem("fName");
        firstName.setTitle("First Name");
        firstName.setSelectOnFocus(true);
        firstName.setSelectOnClick(true); //Doesn't work anymore on SmartGWT 5
        firstName.setWrapTitle(false);
        firstName.setDefaultValue("[First Name]");

        TextItem lastName = new TextItem("lName");
        lastName.setTitle("Last Name");
        lastName.setDefaultValue("[Last Name]");
        lastName.setWrapTitle(false);

        ButtonItem button = new ButtonItem("hello", "Hello");
        button.setStartRow(false);
        button.setWidth(80);
        button.setIcon("icons/16/message.png");
        button.addClickHandler(new ClickHandler() {
            public void onClick(ClickEvent event) {
                SC.say("Hello " + form.getValueAsString("fName") + " " + form.getValueAsString("lName"));
            }
        });

        form.setFields(firstName, lastName, button);

        return form;
    }

    public String getIntro() {
        return DESCRIPTION;
    }
}

[ionut.ursuleanu]

Just checked the 2014-09-14 build (of SmartGWT 5) and it works, so something has changed in the meantime.

[ionut.ursuleanu]

With v10.0p_2015-10-13/LGPL the issue persists for combobox items. The text is selected only if I click on the text, not if I click on the right icon of the field (wich opens the field options)

[ionut.ursuleanu]

Any progress on this one? SmartGWT 5.1 has the same behavior for comboboxes: text autoselection doesn't work if the right icon is clicked.