Wrong first week number in timeline

[SimonF]

Hi there,

I'm using the Timeline and I(and indeed our customers at first) noticed that its week numbers are not calculated with respect to the selected localization.
As stated in https://en.wikipedia.org/wiki/Week#Week_numbering, the first calendar week in europe is the one that includes the 4th of january.

When usin the frameworkMessages_de.properties locale, the first calendar week 2016 ends at january 3rd. This can be seen when executing the appended example code.


This happens with the latest nightly build SmartClient_v100p_2015-11-16_Pro and all browsers.

Here is the Code for reproduction

isc.Timeline.create({
    "ID" : "timeline_1",
    "startDate" : new Date(2016, 0, 1),
    "endDate" : new Date(2016, 0, 31),
    "headerLevels" :
    [{
            "unit" : "week"
        }, {
            "unit" : "day"
        }
    ],
    "firstDayOfWeek" : 1,
    "weekPrefix" : "Calendar Week ",
    "dayPrefix" : "Day "
})

Best Regards

[Isomorphic]

This was just a logic bug in the generation of the title strings, specifcally for "week" spans that are not the innermost field-headers - so, if you change your sample to use headerLevels "month" and "week", rather than "week" and "day", you would see the correct week numbers.

It's been fixed for builds dated November 19 and later.

[SimonF]

HI there,
I've tested this with the latest nightly (SmartClient_v100p_2015-11-19_Pro) and the second week begins on 4th January. In europe the first week of the year begins at the week where the 4th january is.

So not fixed by now, sorry

Best Regards

[Isomorphic]

Yes, sorry - the fix is checked in, but it missed the build run last night, so you won't see it until tomorrow's build.

[SimonF]

I'm not sure, if you have tested the example by yourself.
The index of the week including the 4th january is now indeed the first calendar week. But now the first week is listed twice.

So the issue is fixed and opened another issue.
The first week should only be mentioned once.

Best Regards

[SimonF]

Hi there,
is ther any update to this? The closer we are getting to the turn of the year, the more important is this fix. In some days every our customers will see this bug, by now "only" the customers saw this who, scrolled two months to the future.

Best Regards

[Isomorphic]

Yes, we see the issue and it's being looked into - we'll update here when it's fixed.

[SimonF]

Any update?
January is coming nearer and we will be getting more and more feedback from our customers if this is not fixed till the end of december.

[Isomorphic]

A fix is in testing - it will be live within a day or two - we'll update here when it hits nightlies.

[Isomorphic]

This fix is finally in place - you should see this working as you expect in builds dated December 8 and later.

[Nico.G]

Hi there,
Can we expect the same fix in Smartgwt 4.x fork ?
thanks