updating the ListGrid.implicitCriteria doesn't work with fetchData/refreshData

[claudiobosticco]

SmartClient Version: v11.0p_2016-05-27/EVAL Development Only (expires 2016.07.26_09.52.03) Licensed to: Isomorphic Software (#ISC_EVAL_NIGHTLY)

Chrome on OSX

Please remove the autoFetchData:true setting from the #adaptiveFilterFS sample.

Then execute:

supplyList.setProperty('implicitCriteria', {_constructor:'AdvancedCriteria', operator:'and',criteria:[{fieldName:'itemName', operator:'iStartsWith', value:'add'}]})
supplyList.fetchData()

The data is fetched accordingly to the implicitCriteria.

Then change the criteria:

supplyList.setProperty('implicitCriteria', {_constructor:'AdvancedCriteria', operator:'and',criteria:[{fieldName:'itemName', operator:'iContains', value:'add'}]})

Now, supplyList.willFetchData() will return false, and refreshData will fetch all data.

Only a call to invalidateCache will fetch the correct data (but not if called after refreshData)

[Isomorphic]

A patch to fix this problem has been committed. You'll find this problem solved in the next nightly build (June 4)

[claudiobosticco]

SmartClient Version: v11.0p_2016-06-05/EVAL Development Only (expires 2016.08.04_06.29.49) Licensed to: Isomorphic Software (#ISC_EVAL_NIGHTLY)

Hello, I can confirm that refreshData is working, thank you very much.

willFetchData still returns false, but I suspect this is by design, could you please confirm that?

[Isomorphic]

There should actually be a fetch in this case since switching the operator to iContains makes it less restrictive (that is, the new results are not guaranteed to be a subset of the existing results). We're still working on this aspect of the problem and will let you know when we've solved it.

[claudiobosticco]

Hello, any news about this issue?

[claudiobosticco]

Hello, any news about this issue? It's still present, tested in build:
SmartClient Version: v11.0p_2016-07-13/Enterprise Development Only (built 2016-07-13)
and also:
SmartClient Version: SNAPSHOT_v11.1d_2016-07-13/Enterprise Development Only (built 2016-07-13)

[Isomorphic]

A patch have been applied, so supplyList.willFetchData() will work properly and will return true in the given example (where only the implicit criteria is changed to a more restrictive criteria).
You can test it since the next nightly build of July, 14th

[claudiobosticco]

SmartClient Version: v11.0p_2016-07-14/Enterprise Development Only (built 2016-07-14)

Chrome on OSX

Hello, sorry but the problem is still there for me.

Also I noticed that there's a problem with willFetchData which doesn't involve implicitCriteria.

Using the #adaptiveFilterFS sample please run in the console:

supplyList.fetchData({_constructor:'AdvancedCriteria', operator:'and',criteria:[{fieldName:'itemName', operator:'iContains', value:'add'}]})

the grid will fetch 46 records.
then if you run

supplyList.willFetchData({_constructor:'AdvancedCriteria', operator:'and',criteria:[{fieldName:'itemName', operator:'iStartsWith', value:'add'}]})

it will return true, which to me seems incorrect, because the criteria is more restrictive.
Please let me know if you prefer a new thread for this issue.

[Isomorphic]

Could you please check if the problem with willFetchData() has been fixed in the latest nightly build of 16 July?

Regarding the new problem that you reported, we don't currently do cross-operator restrictiveness checks like this for AdvancedCriteria, since it would be a rare edge case for this to come up in the UI (the end user would have to be using allowFilterOperators mode and change operator then re-use the same filter string).

[claudiobosticco]

SmartClient Version: v11.0p_2016-07-16/EVAL Development Only (expires 2016.09.14_07.58.46) Licensed to: Isomorphic Software (#ISC_EVAL_NIGHTLY)

Chrome/OSX
Hello, I've just tested two different scenarios (you may see the Chrome console in the attachments), and yes, willFetchData returns correctly true, BUT fetchData doesn't trigger a fetch.

[claudiobosticco]

Regarding the new problem that you reported, we don't currently do cross-operator restrictiveness checks like this for AdvancedCriteria, since it would be a rare edge case for this to come up in the UI (the end user would have to be using allowFilterOperators mode and change operator then re-use the same filter string).

sounds fair, thanks for the clarification.

[Isomorphic]

The new problem that you have found has been fixed, the fix is available in the current nightly build

[claudiobosticco]

The new problem that you have found has been fixed, the fix is available in the current nightly build

are you referring to the problem of the post #8, or to the post #10 ?

[Isomorphic]

I meant the latest fix is for the problem in the post #10 "...willFetchData returns correctly true, BUT fetchData doesn't trigger a fetch."
The answer to the problem on post #8 was "...we don't currently do cross-operator restrictiveness..."

[claudiobosticco]

I meant the latest fix is for the problem in the post #10 "...willFetchData returns correctly true, BUT fetchData doesn't trigger a fetch."

ok, and I can confirm it's fixed in build
SmartClient Version: v11.0p_2016-07-18/Enterprise Development Only (built 2016-07-18)
thank you very much