Announcement

**Isomorphic** · 19 Aug 2016, 08:28

This form creates a new record, and orderItem is the PK field. It is expected to be null since the record does not exist yet.

Further, if the record did exist, you should not expect unchanged fields to be present in the "values" of a validation request. You would need to access such fields via "oldValues", however, keep in mind the caveat noted in the docs that the "oldValues" come from the client, so can't be trusted in a secure application (or may be out of date) - the secure way to get current values for an existing record would be to use the PK to fetch it.

**claudiobosticco** · 20 Aug 2016, 05:53

Originally posted by Isomorphic View Post

This form creates a new record, and orderItem is the PK field. It is expected to be null since the record does not exist yet.

Of course you're right, actually I've simplified too much the test case, I'll repost it below.

Originally posted by Isomorphic View Post

Further, if the record did exist, you should not expect unchanged fields to be present in the "values" of a validation request. You would need to access such fields via "oldValues", however, keep in mind the caveat noted in the docs that the "oldValues" come from the client, so can't be trusted in a secure application (or may be out of date) - the secure way to get current values for an existing record would be to use the PK to fetch it.

But actually the missing value it's the PK of the record, which I want to use to fetch the actual record from database.
Also note that I'm using dependentFields="orderItem": isn't it the right approach to have it in the "values"?

This is the right test case:
please remove the custom validator on the quantity field, so that you may add a record to the inlineScript_orderForm dataSource, such as:
inlineScript_orderForm.addData({itemId:1, orderItem:1, quantity:1, instructions:"foo"})

then put the validator back in place:

Code:

        <field name="quantity" type="integer">
            <validators>
                <validator type="serverCustom" dependentFields="orderItem">
                    <serverCondition language="groovy"><![CDATA[
                        value < dataSource.fetchById(record.orderItem).quantity
                    ]]></serverCondition>
                    <errorMessage>Not enough in stock</errorMessage>
                </validator>
            </validators>
        </field>

and run this js code

Code:

isc.ValuesManager.create({
    ID: "myVM",
    dataSource: "inlineScript_orderForm"
});

isc.SectionStack.create({
    ID: "sectionStack",
    visibilityMode: "multiple",
    width: "100%", height: "100%",
    border: "1px solid blue",
    sections: [
        {
            title: "List Grid", canCollapse: false, expanded: true,
            items: [
                isc.ListGrid.create({
                    dataSource: "inlineScript_orderForm",
                    autoFetchData: true,
                    recordClick: function (viewer, record, recordNum, field, fieldNum, value, rawValue) {
                        myVM.editRecord(record);
                    }
                })
            ]
        },
        {
            title: "Form", expanded: true, canCollapse: false,
            items: [
                isc.DynamicForm.create({
                    validateOnChange: true,
                    valuesManager: "myVM",
                    fields: [
                        {type: "header", defaultValue: "Add an item to your Order"},
                        {
                            name: "itemId", title: "Item", editorType: "ComboBoxItem", optionDataSource: "StockItem",
                            valueField: "id", displayField: "description"
                        },
                        {name: "quantity", validateOnExit: true},
                        {name: "instructions", editorType: "TextAreaItem"},
                        {type: "submit", title: "Submit Order"}
                    ]
                })
            ]
        }
    ]
});

Select the grid's record, and type in the quantity field of the form.
Tomcat log:

Code:

=== 2016-08-20 13:27:21,642 [83-5] DEBUG RPCManager - Processing 1 requests.
=== 2016-08-20 13:27:21,642 [83-5] DEBUG RPCManager - Request #1 (DSRequest) payload: {
    values:{
        itemId:"1",
        quantity:19,
        instructions:"foo"
    },
    operationConfig:{
        dataSource:"inlineScript_orderForm",
        repo:null,
        operationType:"validate",
        textMatchStyle:"exact"
    },
    validationMode:"partial",
    appID:"builtinApplication",
    operation:"inlineScript_orderForm_validate",
    oldValues:{
        itemId:"1",
        quantity:19,
        instructions:"foo"
    },
    criteria:{
    }
}

as you may see, orderItem isn't present in "values"

**claudiobosticco** · 20 Aug 2016, 06:00

I've just realized that the form hasn't got orderItem as an item, if I add it, then everything works.
I got confused because everything worked if editing in the grid, but when editing with the form, the PK is used for updating even if not present as an item, but isn't considered by the validate with dependentFields.

So I think that this is by design, right?

**Isomorphic** · 22 Aug 2016, 11:06

We've made a change to SC 11.0p and newer branches to ensure that all of the ValuesManager values are present. It's in the nightly builds dated 2016-08-22 and beyond.

**claudiobosticco** · 24 Aug 2016, 08:46

SmartClient Version: v11.0p_2016-08-24/Enterprise Development Only (built 2016-08-24)

I can confirm it's fixed, thank you very much

Announcement

serverCustom validator: dependentField not passed to server

Comment

Comment

Comment

Comment

Comment