Incorrect styling in Chrome 56

[martintaal]

Hello,

we have found an issue using Chrome 56 (in beta phase when reporting this topic) with the styles used by the pop-ups of our application.

Here[1] you have an example that shows a pop-up and a portlet. Also you can find the CSS definition for the example here[2]. We have tested it on the Smartclient showcase, and we can see some differences when using Chrome 56 and the rest of the browsers:

1- The pop-up header is shown differently.
2- The gradient in the header of the portlet and also the edges look different.

We experienced a similar problem in the past, but using the MS Edge browser instead, that Isomorphic already fixed. See here[3].

Indeed, if we put this (trick) line before our code, the visualization is correct in Chrome 56:

isc.Browser.isEdge = true; isc.Browser.isChrome = false;

Regards.

[1] https://gist.github.com/caristu/7728...134a1b24bb4549
[2] https://gist.github.com/caristu/9013...a6c4798974d70a
[3] http://forums.smartclient.com/showthread.php?p=133520

[Isomorphic]

Please let us know if this persists in the final build of Chrome 56, and we'll look at it right away.

We do not look into bugs in beta browsers.

[martintaal]

Hi,

We have reported this problem as a Chrome issue [1].

Their decision is the new behavior is the correct one, so they will keep it.

Note that chrome 56 release date is already very near (Jan 31st, 2017) [2].

Regards.

[1] https://bugs.chromium.org/p/chromium...tail?id=682166
[2] https://www.chromium.org/developers/calendar

[Isomorphic]

Thanks for the follow up.
We've made a change in the framework to address this issue. Please try the next nightly build, dated Jan 21 or above in the 11.1d, 11.0p or 10.1p branches

Regards
Isomorphic Software

[martintaal]

Thanks, it works fine for us.

[markok]

Please, could this fix be ported to the 5.0p (10.0) branch? As Chrome 56 is now released I noticed our application which still is in 5.0p branch renders incorrectly. We tried with 5.0p-lgpl-2017-02-01 build and it seems this branch is not fixed (as you indicate above).

We are in the process of upgrading our smartgwt version but we are still stuck with 5.0p for a while.

[ueng]

Thanks for the follow up.
We've made a change in the framework to address this issue. Please try the next nightly build, dated Jan 21 or above in the 11.1d, 11.0p or 10.1p branches

Regards
Isomorphic Software

It's possible to create a patch of this fix to the v9.1p_2016-01-21?
We have this version running on production and this issue is impacting a lot of customers.

[shresthg_des]

Could you please patch SmartClient version 9.1 with the fix? The issue is occurring on a lot of the components.

[Raindy]

Please, could this fix be ported to the 5.0p (10.0) branch? As Chrome 56 is now released I noticed our application which still is in 5.0p branch renders incorrectly. We tried with 5.0p-lgpl-2017-02-01 build and it seems this branch is not fixed (as you indicate above).

We are in the process of upgrading our smartgwt version but we are still stuck with 5.0p for a while.

Have you got the patch for version 5.0p?

[Isomorphic]

By mistake we only applied the fix to 6.0. 5.1, 4.1 and 4.0, but not to 5.0. We have now applied the patch to 5.0p.
Sorry for any inconvenience.

Kind regards,
Isomorphic.