11.1 - Icon in selectItem not aligned

[SimonF]

Hi there,
Using icons in a SelectItem does show the icons in the selectbox, but the icons seem to be not properly aligned with the text.
The Flag icon should have the same space from bottom and the top. By now it looks like glued to the bottom of the box.

Version: SmartClient_v111p_2017-07-23_Pro
Browser: All Browsers
Skin: Tahoe, Enterprise
Density: Medium, Dense

Tahoe on Medium:

Tahoe on Dense:

(I know this will be a won't fix with Dense with skin Tahoe, but posting for comparison)
Enterprise on Medium

Enterprise on Dense:


Code for reproduction

isc.DynamicForm.create({
    "ID": "theForm",
    "fields":
    [{
            "ID": "stateSelectItem",
            "name": "stateSelectItem",
            "title": "State",
            "type": "text",
            "editorType": "comboBox",
            "width": "*",
            "iconWidth": 16,
            "iconHeight": 16,
            "imageURLPrefix": "https://cdn3.iconfinder.com/data/icons/142-mini-country-flags-16x16px/16/",
            "imageURLSuffix": ".png",
            "valueIconSize": 16,
            "valueIcons": {
                1: "flag-belgium",
                2: "flag-south-korea",
                3: "flag-germany"
            },
            "textMatchStyle": "substring",
            "allowEmptyValue": true,
            "valueMap": {
                1: "Belgium",
                2: "SouthKorea",
                3: "Germany"
            }
        }
    ],
    "values": {
        "stateSelectItem": 3
    }
})

Best regards

[Isomorphic]

Hi Simon,
The media in this test is being loaded from an external URL - for example here: https://cdn3.iconfinder.com/data/ico...ag-belgium.png
If you view the file at that location, it has native width of 16px and native height of 12px - (despite the '16x16' string in the URL name).
If you modify the valueIcon sizing properties to match this (set valueIconWidth to 16 and valueIconHeight to 12, and get rid of 'valueIconSize'), the vertical misalignment goes away in our testing.

If you think there's more to do here, please let us know

Thanks
Isomorphic Software
---
Edit: A quick note to also add: There is some confusion about the "Dense" setting for Tahoe.
We don't consider visual bugs in Tahoe at the "dense" setting as generally "wontfix". The skin was designed with the more spacious densities in mind, and that is the intended / expected optimal setting -- but this doesn't mean we aren't interested in fixing issues that do occur when rendering in the "dense" mode.