12.0p canEdit:false DynamicForm with readOnlyDisplayAppearance:"static" and print preview

[Blama]

Hi Isomorphic,

please see this modified testcase (v12.0p_2019-08-01). As you can see, the print preview has some design flaws, which make the printout look bad.

canEdit:false and readOnlyDisplayAppearance:"static":

• Box for "Units" SelectItem displayed
• Font color of "Units" SelectItem (black instead of gray)
• Width of "Units" SelectItem (bit too narrow)
• Width of "Description" TextAreaItem (
• Width of "Next Shipment" DateItem
• Text-align of "Next Shipment" DateItem (might be on purpose)

canEdit:true:

• Width of "Description" TextAreaItem
• 2nd line of "Description" TextAreaItem in some strange position
• Width of "Next Shipment" DateItem
• Width of "Units" SelectItem (bit too narrow)
• Text-align of "Next Shipment" DateItem (might be on purpose)
• pickerIcon of "Units" SelectItem missing
• Font color of "Units" SelectItem (black instead of gray)
• Font size of "Units" SelectItem (too small)

In general, the width should be always the same for all FormItems in canEdit:true/false-modes in normal mode and print preview.

The first block with the canEdit:false and readOnlyDisplayAppearance:"static" issues is more important to me.

Best regards
Blama

isc.DynamicForm.create({ 
    ID: "dynamicForm",
    canEdit: false, readOnlyDisplay:"static",
    dataSource: "supplyItem",
    width: 800,
    // pre-fill some values
    values: {
        unitCost: -1.234,
        SKU: "my SKU",
        units: "Ream",
        description:"lore ipsum lore ipsum lore ipsum lore ipsum lore ipsum lore ipsum lore ipsum lore ipsum lore ipsum lore ipsum lore ipsum lore ipsum lore ipsum lore ipsum lore ipsum lore ipsum lore ipsum lore ipsum lore ipsum lore ipsum lore ipsum lore ipsum lore ipsum"
    }
});

isc.IButton.create({
    ID: "toggleEditButton",
    title: "Toggle canEdit",
    click: "dynamicForm.setCanEdit(!dynamicForm.canEdit)"
});

isc.IButton.create({
ID:"printBtn",
            autoDraw: false,
            title: "Print Preview",
            click: "isc.Canvas.showPrintPreview(dynamicForm)"
        });

isc.HStack.create({
    ID: "buttons",
    height: 24,
    membersMargin: 10,
    members: [toggleEditButton, printBtn]
});


isc.VLayout.create({
    width: 800,
    membersMargin: 10,
    members: [dynamicForm, buttons]
});

[Isomorphic]

Hi Blama
Thanks for the test case here and the series of issue reports.
This is just a quick follow up to let you know we are working on these. We'll follow up once we have some resolutions in place

Regards
Isomorphic Software

[Blama]

Hi Isomorphic,

running the testcase from #1 in v12.0p_2019-08-29 it seems that you fixed some of the issues. Is this correct?

Best regards
Blama

[Isomorphic]

Yes - we have indeed improved the behavior here.
There is still some internal discussion among our design team as to whether there are further changes to make in this area but to address the issues you raise:

Static view:
- Box for "Units" SelectItem displayed
- Font color of "Units" SelectItem (black instead of gray)
- Width of "Units" SelectItem (bit too narrow)
These issues are Fixed

- Width of "Description" TextAreaItem
- Width of "Next Shipment" DateItem
- Text-align of "Next Shipment" DateItem (might be on purpose)
These are behaving as designed, but our design team are considering whether we should make changes here

Non static view:
- 2nd line of "Description" TextAreaItem in some strange position
- Width of "Units" SelectItem (bit too narrow)
- Font color of "Units" SelectItem (black instead of gray)
- Font size of "Units" SelectItem (too small)
Fixed (some fixes require new nightly build dated Aug 31 or above)

- pickerIcon of "Units" SelectItem missing
- Width of "Description" TextAreaItem
- Width of "Next Shipment" DateItem
- Text-align of "Next Shipment" DateItem (might be on purpose)
Again, these are behaving as designed, but our design team are considering whether we should make changes here

Regards

[Blama]

Hi Isomorphic,

using v12.0p_2019-09-08 I can see the changes you mention. All remaining points are very minor to me.

Another also very minor thing I noticed: In canEdit:true mode, Units and In Stock can take focus and get a blue focus border in Chrome, while you can't click/activate the other fields.

Best regards
Blama