12.0p BatchUploader and bug with canRemoveRecords: true

[Blama]

Hi Isomorphic,

we have a problem with BatchUploader. We used Hilite + ValidationContext.setResultingValue() to create "warnings" via Hilite for possible duplicates.
The user can then decide not to import the leads via canRemoveRecords: true.

Here are two problems, one with canRemoveRecords (this thread), one with the default-enabled deferRemoval.

Please see here (v12.0p_2019-12-14) in mode "Retain" that the wrong records are displayed after "Commit" (none are expected):

isc.BatchUploader.create({
    ID:"uploader",
    height: 700,
    width: "100%",
    uploadDataSource: supplyItemCustom,
    uploadFormProperties: {
        titleWidth: 110
    },
    gridProperties: {
        height: 400,
        deferRemoval: false,
        canRemoveRecords: true
    }
});

isc.DynamicForm.create({
    ID: "partialCommitsForm",
    items: [
        {
            name:"partialCommits", 
            wrapTitle: false,
            title:"Partial Commit Mode", 
            type:"select", 
            defaultValue: "prompt",
            valueMap:{
                allow: "Allow", 
                prevent: "Prevent", 
                prompt: "Prompt",
                retain: "Retain"
            },
            changed : function(form, item, value) {
                uploader.partialCommit = value;
            }
        }
    ]
});

isc.VStack.create({
    width:"100%",
    layoutMargin:10,
    membersMargin: 10,
    members:[
        partialCommitsForm,
        uploader
    ]
});

Steps:

• Run sample
• Upload demo file
• Remove 3 entries with validation error
• Commit 4 entries without validation error
• Expected: No records left
• Result: Random records (with and without validation error) left

After upload and remove:


After commit:



Best regards
Blama

[Blama]

This is the related thread.

[Isomorphic]

This is fixed and available for download in nightly builds since Jan 16.

[Blama]

Hi Isomorphic,

this is behaving exactly as before for the steps in #1 using v12.0p_2020-01-17.

Best regards
Blama

[Isomorphic]

Apologies for the incomplete fix, please try Jan 18 build and let us know how it worked for you.

[Blama]

Hi Isomorphic,

to me it looks like it is working as expected in the online showcase using v12.0p_2020-01-18.

Thank you & Best regards
Blama