Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

    ListGrid editorProperties ( addUnknownValues, allowEmptyValue ) ERROR

    Hello Isomorphic!

    I tried the occurring error with the smartclient showcase
    with the link https://www.smartclient.com/smartcli...?id=editByCell
    I modified the editCells.js to following code
    I added following to the continent field
    *****
    editorType: "comboBox",
    editorProperties : {
    addUnknownValues: false,
    allowEmptyValue: false,

    }
    *****

    full code ->

    isc.ListGrid.create({
    ID: "countryList",
    width:550, height:224, alternateRecordStyles:true,
    // use server-side dataSource so edits are retained across page transitions
    dataSource: countryDS,
    // display a subset of fields from the datasource
    fields:[
    {name:"countryCode", title:"Flag", width:40, type:"image", imageURLPrefix:"flags/16/", imageURLSuffix:".png", canEdit:false},
    {name:"countryName"},
    {
    name:"continent",
    editorType: "comboBox",
    editorProperties : {
    addUnknownValues: false,
    allowEmptyValue: false,

    }
    },
    {name:"member_g8"},
    {name:"population"},
    {name:"independence"}
    ],
    autoFetchData: true,
    canEdit: true,
    editEvent: "click",
    editByCell: true
    })


    after changing it to this code and running it i can't edit the combobox anymore and get following error


    ISC_Core.js?isc_version=v12.0p_2020-01-27.js:1261 *10:05:46.971:TMR0:WARN:Log:TypeError: Cannot read property 'setVisibility' of undefined
    Stack from error.stack:
    ComboBoxItem.setAddUnknownValues(<no args: exited>) on [ComboBoxItem ID:isc_ComboBoxItem_0 name:continent] @ ISC_Forms.js:2653:74
    Class.setProperties(<no args: exited>) on [ComboBoxItem ID:isc_ComboBoxItem_0 name:continent] @ ISC_Core.js:375:109
    ListGrid.makeEditForm(<no args: exited>) on[ListGrid ID:countryList] @ ISC_Grids.js:2026:278
    ListGrid.showInlineEditor(<no args: exited>) on[ListGrid ID:countryList] @ ISC_Grids.js:1979:22
    ListGrid._startEditing(<no args: exited>) on[ListGrid ID:countryList] @ ISC_Grids.js:1966:6
    [c]Class.fireCallback(_1=>Obj, _2=>null, _3=>null, _4=>null, _5=>true) on [Class Timer] @ ISC_Core.js:326:104
    Timer._fireTimeout(_1=>"$ir5039", _2=>5502, _3=>undef) on [Class Timer] @ ISC_Core.js:1831:166
    <anonymous>() @ ISC_Core.js:1828:40

    isc.B.push.isc.A.addToMasterLog @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:1261
    isc_c_Log_addLogMessage @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:1259
    isc_c_Log_log @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:1252
    logMessage @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:1241
    logWarn @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:1241
    isc__debug__reportJSErrorStack @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:1214
    isc__debug__reportJSError @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:1214
    isc_c_Class_fireCallback @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:326
    isc_c_Timer__fireTimeout @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:1831
    (anonymous) @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:1828
    setTimeout (async)
    isc_c_Timer_setTimeout @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:1828
    isc_c_Class_delayCall @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:327
    isc_Class_delayCall @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:399
    isc_ListGrid__startEditing @ ISC_Grids.js?isc_version=v12.0p_2020-01-27.js:1957
    isc_ListGrid__saveAndStartEditing @ ISC_Grids.js?isc_version=v12.0p_2020-01-27.js:2295
    isc_ListGrid__changeEditCell @ ISC_Grids.js?isc_version=v12.0p_2020-01-27.js:1952
    isc_ListGrid_startEditing @ ISC_Grids.js?isc_version=v12.0p_2020-01-27.js:1943
    isc_ListGrid_handleEditCellEvent @ ISC_Grids.js?isc_version=v12.0p_2020-01-27.js:1936
    isc_ListGrid_rowClick @ ISC_Grids.js?isc_version=v12.0p_2020-01-27.js:1693
    eval @ VM501:4
    isc_GridRenderer__rowClick @ ISC_Grids.js?isc_version=v12.0p_2020-01-27.js:588
    isc_c_Class_invokeSuper @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:317
    isc_c_Class_Super @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:309
    isc_GridBody__rowClick @ ISC_Grids.js?isc_version=v12.0p_2020-01-27.js:657
    isc_GridRenderer_click @ ISC_Grids.js?isc_version=v12.0p_2020-01-27.js:586
    isc_Canvas_handleClick @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:3541
    isc_c_EventHandler_bubbleEvent @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:2158
    isc_c_EventHandler_handleClick @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:1993
    isc_c_EventHandler__handleMouseUp @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:1977
    isc_c_EventHandler_handleMouseUp @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:1968
    isc_c_EventHandler_dispatch @ ISC_Core.js?isc_version=v12.0p_2020-01-27.js:2245
    eval @ VM454:3
    ISC_Core.js?isc_version=v12.0p_2020-01-27.js:326 Uncaught TypeError: Cannot read property 'setVisibility' of undefined
    at _3.isc_ComboBoxItem_setAddUnknownValues [as setAddUnknownValues] (ISC_Forms.js?isc_version=v12.0p_2020-01-27.js:2653)
    at _3.isc_Class_setProperties [as setProperties] (ISC_Core.js?isc_version=v12.0p_2020-01-27.js:375)
    at _3.isc_ListGrid_makeEditForm [as makeEditForm] (ISC_Grids.js?isc_version=v12.0p_2020-01-27.js:2026)
    at _3.isc_ListGrid_showInlineEditor [as showInlineEditor] (ISC_Grids.js?isc_version=v12.0p_2020-01-27.js:1979)
    at _3.isc_ListGrid__startEditing [as $31u] (ISC_Grids.js?isc_version=v12.0p_2020-01-27.js:1966)
    at _3.isc_c_Class_fireCallback [as fireCallback] (ISC_Core.js?isc_version=v12.0p_2020-01-27.js:326)
    at _3.isc_c_Timer__fireTimeout [as $in] (ISC_Core.js?isc_version=v12.0p_2020-01-27.js:1831)
    at ISC_Core.js?isc_version=v12.0p_2020-01-27.js:1828


    the same example was working with ( SmartClient Version: v12.0p_2018-08-02/Pro Deployment (built 2018-08-02) )

    i attached a .gif with the problem

    I hope you can help me somehow!
    Thank you!
    Attached Files

    #2
    There is no editorType "comboBox" - you need "ComboBoxItem" - see the FormItem docs

    Comment


      #3
      Ok,.. nevertheless it doesn't work with ComboBoxItem either,..

      running this code also doesn't change the behaviour


      isc.ListGrid.create({
      ID: "countryList",
      width:550, height:224, alternateRecordStyles:true,
      // use server-side dataSource so edits are retained across page transitions
      dataSource: countryDS,
      // display a subset of fields from the datasource
      fields:[
      {name:"countryCode", title:"Flag", width:40, type:"image", imageURLPrefix:"flags/16/", imageURLSuffix:".png", canEdit:false},
      {name:"countryName"},
      {
      name:"continent",
      editorType: "ComboBoxItem",
      editorProperties : {
      addUnknownValues: false,
      allowEmptyValue: false,

      }
      },
      {name:"member_g8"},
      {name:"population"},
      {name:"independence"}
      ],
      autoFetchData: true,
      canEdit: true,
      editEvent: "click",
      editByCell: true
      })


      Thank you!

      Comment


        #4
        We just dropped your exact code into the sample at the link you posted and ran it, and it worked fine - editing works, changing works and saving works.

        In fact, if we drop your first sample into the link you provided, that also works as expected.

        You might want to clear your browser caches or try a different browser.

        Comment


          #5
          Ok, that's weird,.. i tried another browser and cleared all cache,..
          still same behaviour,.. it works for editing the first row but if you change immediately to the next continent row - field,. then you'll get the error

          maybe you could try it like it's shown in the gif?

          thank you very much!
          Attached Files

          Comment


            #6
            Hi all,

            I do get the same error as the OP when using code from #3 in the sample from #1 (v12.0p_2020-01-27, current Chromium 79).
            Steps:
            • Edit any row
            • Leave row either with Enter or Escape or click outside when the Continent ComboBoxItem has the focus
            • Try to edit any row
            • JS Exception
            It only happens for me if the field has the focus when exiting.

            Best regards
            Blama

            Comment


              #7
              Ok, we'll take a look and update here when we have more information.

              Comment


                #8
                Hi Isomorphic,

                this is still happening in v12.0p_2020-02-13.

                Best regards
                Blama

                Comment


                  #9
                  Apologies, this one slipped through the net - it's been fixed for tomorrow's builds.

                  Comment

                  Working...
                  X