Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

    12.0p flickering because of reflow after sliderValueText resizes DynamicForm

    Hi Isomorphic,

    I browsed the showcase. In this sample (v12.0p_2020-03-28, Chromium 80 / Win 10) the content flickers if you move the "Rotation" knob towards the right border.
    This does not happen with editorProperties: { vertical: true }, so I'm pretty sure this is related to suddenly extended DynamicForm width because of sliderValueText.

    Click image for larger version  Name:	DynamicForm resize.gif Views:	0 Size:	50.8 KB ID:	261639

    Best regards
    Blama

    #2
    This has been fixed for builds dated April 4 and later.

    Comment


      #3
      Hi Isomorphic,

      this is still happening using v12.0p_2020-04-05, but perhaps a bit less. Tested with Chromium 80 on Win10, FullHD, maximized Chromium window.

      Best regards
      Blama

      Comment


        #4
        The initial fix was for the valueLabel overflowing the Slider - this latter problem was the thumb itself overflowing the Slider, hence only happening in the final one or two positions. It's been fixed for builds dated April 6 and later.
        Last edited by Isomorphic; 5th Apr 2020, 11:25.

        Comment


          #5
          Hi Isomorphic,

          this is still happening for me in the sample using v12.0p_2020-04-06.

          Best regards
          Blama

          Comment


            #6
            Hm - yes, we see it too, but only in the SGWT showcase - the (SmartClient) framework sample is working as expected.

            We'll investigate.

            Comment


              #7
              It's also happening in SmartClient for me, but only if you move one to the max - so not visible on start of the testcase when you just also move the lower knob to 360.

              Click image for larger version

Name:	Flickering.gif
Views:	30
Size:	79.9 KB
ID:	261781

              Best regards
              Blama

              Comment


                #8
                Apologies, we accidentally tested against 13.0, where it works as expected - perhaps we missed porting something back - we'll fix 12.x for tomorrow's builds.

                Comment


                  #9
                  Regarding SmartGWT:
                  • Happening here using v12.1p_2020-04-05
                  • In these two the "360" looks cut off using v12.1p_2020-04-05. This might be related.
                  Best regards
                  Blama

                  Comment


                    #10
                    The first one works as expected in SC 12.1, so is SGWT-related, and the second are both the result of the samples setting "width" rather than "length" (you can test that in the SC versions).

                    We'll update here when we've fixed things.

                    Comment


                      #11
                      We've made a further tweak which means Sliders in all samples should now render without overflow or clipping, whether the samples set width or length, and whether or not they show a title.

                      You can try out the fix in today's public builds of 12.x.

                      Comment


                        #12
                        Hi Isomorphic,

                        using v12.0p_2020-04-10 and v12.1p_2020-04-10 all flickering in all samples linked (SC and SGWT) is gone, thank you.

                        Very very minor thing left: Here (v12.0p_2020-04-10) the top Zoom-level sliderValueText is cut off on the left when moved to the left end ("10) (Chromium 80, Win10, Tahoe spacious).

                        This is even more visible if you have bigger number at the left end, e.g.:
                        Code:
                                minValue: 1000,
                                maxValue: 10000,
                                numValues: 10,
                                defaultValue: 3000,
                        So the optimization of moving the text in when it's too long, that you do on the right end, might also be useful on the left end.

                        For some other reason this does not happen in 12.1, where the sliderValueText seems to have another z-index I assume, because it's visible with even bigger numbers:

                        Click image for larger version

Name:	SliderText.png
Views:	26
Size:	15.2 KB
ID:	261858

                        Best regards
                        Blama

                        Comment


                          #13
                          We've fixed the left-clipping by also clamping the value layout at that end of the slider - this change is in 12.0 only, for builds dated April 11 and later.

                          Comment


                            #14
                            Hi Isomorphic,

                            this is looking great in v12.0p_2020-04-15.

                            But now the sliders in these two samples are completely broken designwise:
                            Click image for larger version

Name:	SliderItem.png
Views:	12
Size:	73.7 KB
ID:	261950

                            Best regards
                            Blama

                            Comment


                              #15
                              Ok, we've audited the showcase and removed tiny fixed heights from Slider widgets in these two samples and a couple of others - they were causing clipping. Hopefully that will be everything fixed. :)

                              Please retest with a build dated April 16 or later.

                              Comment

                              Working...
                              X