Announcement

**Isomorphic** · 10 Apr 2020, 10:08

Presumably you think this is related to the rowNum field because, if you don't use that feature, the problem goes away in your app?

If so, you could create a field that behaves similarly to the rowNum field, perhaps by copying its default properties (listed in ListGrid.js, look for listGrid.rowNumberField, or you could dynamically inspect to find them) until you get the same problem.

**Blama** · 10 Apr 2020, 11:52

Hi Isomorphic,

thanks. I tried now coming from my application, finally getting me to a testcase.
Removing the showRowNumbers-field removes the problem. I then tried what else is needed for the problem to occur and started with removing my whole ListGrid.setDefaultProperties(), which includes a setMinFieldWidth(50). This alone fixes it as well.
Then things got strange to that I needed to create a BuiltInDS-based Java testcase and can't use the online testcase.

It seems that this only happens if setMinFieldWidth(50) is set in ListGrid.setDefaultProperties() and not if it is set in the ListGrid instance itself. How is such a thing possible?

Code:

package com.smartgwt.sample.client;

import com.google.gwt.core.client.EntryPoint;
import com.smartgwt.client.Version;
import com.smartgwt.client.core.KeyIdentifier;
import com.smartgwt.client.data.DataSource;
import com.smartgwt.client.util.Page;
import com.smartgwt.client.util.PageKeyHandler;
import com.smartgwt.client.util.SC;
import com.smartgwt.client.widgets.IButton;
import com.smartgwt.client.widgets.Window;
import com.smartgwt.client.widgets.events.ClickEvent;
import com.smartgwt.client.widgets.events.ClickHandler;
import com.smartgwt.client.widgets.grid.ListGrid;
import com.smartgwt.client.widgets.layout.VLayout;

public class BuiltInDS implements EntryPoint {
    private VLayout mainLayout;
    private IButton recreateBtn;

    public void onModuleLoad() {
        ListGrid lg = new ListGrid() {
            {
                setMinFieldWidth(50);
            }
        };
        ListGrid.setDefaultProperties(lg);

        KeyIdentifier debugKey = new KeyIdentifier();
        debugKey.setCtrlKey(true);
        debugKey.setKeyName("D");

        Page.registerKey(debugKey, new PageKeyHandler() {
            public void execute(String keyName) {
                SC.showConsole();
            }
        });

        mainLayout = new VLayout(20);
        mainLayout.setWidth100();
        mainLayout.setHeight100();

        recreateBtn = new IButton("Recreate");
        recreateBtn.addClickHandler(new ClickHandler() {
            @Override
            public void onClick(ClickEvent event) {
                recreate();
            }
        });
        mainLayout.addMember(recreateBtn);
        recreate();
        mainLayout.draw();
    }

    private void recreate() {
        Window w = new Window();
        w.setWidth("95%");
        w.setHeight("95%");
        w.setMembersMargin(0);
        w.setModalMaskOpacity(70);
        w.setTitle(" (" + Version.getVersion() + "/" + Version.getSCVersionNumber() + ")");
        w.setTitle("setMinFieldWidth(50) problem with ListGrid.setDefaultProperties(lg)" + w.getTitle());
        w.setShowMinimizeButton(false);
        w.setIsModal(true);
        w.setShowModalMask(true);
        w.centerInPage();

        final ListGrid employeesGrid = new ListGrid();
        employeesGrid.setDataSource(DataSource.get("employees"));
        // employeesGrid.setMinFieldWidth(50);
        employeesGrid.setAutoFetchData(true);
        employeesGrid.setHeight100();
        employeesGrid.setCanEdit(true);
        employeesGrid.setShowFilterEditor(true);
        employeesGrid.setShowRowNumbers(true);
        w.addItem(employeesGrid);
        w.show();
    }
}

Best regards
Blama

**Isomorphic** · 10 Apr 2020, 12:11

Setting minFieldWidth via defaultProperties is not really valid since framework features that use ListGrids may rely on the default. For this kind of setting, if you want to use a non-default setting pervasively, create a subclass of ListGrid and use it everywhere.

Since the FilterEditor is itself just another ListGrid, probably your setting of minFieldWidth interferes with the sizing algorithms there.

**Blama** · 10 Apr 2020, 12:40

Hi Isomorphic,

thanks, I did not expect this - good to know.
I slowly have the feeling that in the end everything is a ListGrid :)

Any other setter here I should not use in setDefaultProperties():

Code:

        ListGrid lg = new ListGrid() {
            {
                if (Browser.getIsTablet()) {
                    setSelectionType(SelectionStyle.SINGLE);
                }

                setAutoFitFieldsFillViewport(true);
                setShowClippedValuesOnHover(true);
                setAutoFitWidthApproach(AutoFitWidthApproach.BOTH);
                // Not I18nEdited, as this would require loading SettingsCache and this is not possible before ServletLogin has returned data
                setWarnOnRemovalMessage(i18n.removeRecordQuestion());
                // Wastes a bit of space, but will get rid of all zoom related ListGrid flickering. If the vertical scrollbar is always shown, showing a
                // horizontal one can not trigger it, possibly ending in a resize/reflow/redraw loop.
                setLeaveScrollbarGap(true);

                setCanMultiGroup(false);
                setCanEdit(false);
                setShowFilterEditor(false);
                setCanFreezeFields(false);
                setCanReorderFields(false);
                setCellHeight(30);
                setHeaderHeight(37);
                setWrapHeaderTitles(true);
                setFixedRecordHeights(true);
                setHoverDelay(defaultHoverDelay);
                setHoverWidth(defaultHoverWidth);
                setRemoveIcon(Lms.imagePath + "/fontAwesome/solid/minus-circle_Red.png");
                setSelectHeaderOnSort(false);
                setMinFieldWidth(50);
                setRemoveFieldProperties(new ListGridField() {
                    {
                        setWidth(24);
                    }
                });
                // See https://forums.smartclient.com/forum/technical-q-a/260630-12-0p-exportclientdata-column-width-problems-with-xlsx-export
                setExportFieldWidths(true);
                setExportWidthScale(0.25);
            }
        };
        ListGrid.setDefaultProperties(lg);

Thank you & Best regards
Blama

**Isomorphic** · 10 Apr 2020, 12:56

Many of those would be invalid.

You can see us re-using ListGrids as parts of other components (eg the PickList) but also in many built-in dialogs (hilite editor, advanced field picker, etc). When you turn off features like field reordering, or frozen fields, you could break how those dialogs, or future built-in dialogs, are meant to work. You're also messing around with default auto-sizing, again, built-in features may rely on default sizing rules, and rely on the faster performance of non auto-sizing fields. Similarly with forcing fixed record heights. And so on..

Basically, you need to stick to things that strictly affect appearance, the kinds of settings established or changed by skins. For anything else, create and use a standard ListGrid subclass in your code.

We have to ask though: are you seriously turning off reordering and frozen columns everywhere? Why cripple the grid that way?

Announcement

12.0 ListGrid filterRow width problem with fixed offset

Comment

Comment

Comment

Comment

Comment