Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

    Color Picker bug and patch

    Hi, we noticed a problem with the Advanced Color Picker and here is the patch. Not sure if a null check is the answer but it fixed our problem

    Code:
    	//null check for advanced color picker
    	if (window.isc &&  isc.version.startsWith("v8.3")){
    		
    		isc.ColorPicker.getPrototype().addProperties({
    			$564:function isc_ColorPicker__changeColor(_1){if(_1=='rgb'){var _2=isc.ColorUtils.rgbToHsl(this.$56j,this.$56k,this.$56l);this.$56f=false;this.setHue(_2.h);this.setSaturation(_2.s);this.setLuminosity(_2.l,true);this.setHtmlColor(isc.ColorUtils.rgbToHtml(this.$56j,this.$56k,this.$56l));this.$56f=true;this.$563(this.$56o,this.$56p)}else if(_1=='hsl'){if(!this.$105z)this.$56q=120;var _3=isc.ColorUtils.hslToRgb(this.$56o,this.$56p,this.$56q);this.$56f=false;this.setRed(_3.r);this.setGreen(_3.g);this.setBlue(_3.b);this.setHtmlColor(isc.ColorUtils.rgbToHtml(this.$56j,this.$56k,this.$56l));this.$56f=true;if(this.$56o!=this.$565||this.$56p!=this.$566){this.$563(this.$56o,this.$56p)}}else if(_1=='html'){var _3=isc.ColorUtils.htmlToRgb(this.$56m);this.$56f=false;this.setRed(_3.r);this.setGreen(_3.g);this.setBlue(_3.b);var _2=isc.ColorUtils.rgbToHsl(this.$56j,this.$56k,this.$56l);this.setHue(_2.h);this.setSaturation(_2.s);this.setLuminosity(_2.l,true);this.$56f=true;this.$563(this.$56o,this.$56p)}
    			if(this.$56c=='complex'){this.$56x.setValue(this.$56q);this.$56n.setValue("pickerLumVal",this.$56q)}
    			if(this.$56c=='complex'){this.$56u.setBackgroundColor(isc.ColorUtils.hslToHtml(this.$56o,this.$56p,this.$56q))}
    			if(this.$56o!=this.$565||this.$56p!=this.$566){this.$56h()}
    			if(this.$56c=='complex'){
    				this.$56u.setOpacity(this.$56d);
    				var _4=this.$56y
    				//4/18/13
    				//added null check here to avoid script error
    				if(_4!=null){
    					var _5=_4.getValue()
    					var _6=this.$56d;					
    					if(_6===null)_6=100;
    					if(_5!=_6)this.$56y.setValue(this.$56d)
    
    				}
    			}
    			this.$565=this.$56o;this.$566=this.$56p;if(this.colorChanged)this.colorChanged()}
    
    		})
    		
    	}

    #2
    We haven't seen a problem with this, but we've rolled your null guard into the 8.3 and 9.0 codebase as a precaution

    Regards
    Isomorphic Software

    Comment

    Working...
    X